ModernUO/Projects/UOContent/Engines/Veteran Rewards/RewardConfirmGump.cs
Kamron Batman ab5f615840
perf: Migrate Veteran Reward gumps to DynamicGump/StaticGump (#2415)
## Summary

Migrates 16 player-facing legacy `Gump` subclasses in the Veteran Rewards system to `DynamicGump` or `StaticGump<T>`, renames every nested `InternalGump`/`ConfirmGump` to system-prefixed names, and updates external callers to use new static `DisplayTo` entry points.

### Reward chain (Engines/Veteran Rewards)

| Gump | Base type | Reasoning |
|---|---|---|
| `RewardNoticeGump` | `StaticGump<T>` | Fixed layout |
| `RewardChoiceGump` | `DynamicGump` | Layout shape varies (per-player categories, entries, pages) |
| `RewardConfirmGump` | `DynamicGump` | `entry.Name` is a dynamic cliloc per reward (cliloc rule) |
| `RewardOptionGump` | `DynamicGump` | Title cliloc and per-option clilocs are dynamic (cliloc rule) |
| `RewardDemolitionGump` | `DynamicGump` | `question` cliloc is dynamic per caller (cliloc rule) |

### Statue (Engines/Veteran Rewards/Character Statue Maker)

| Gump | Base type | Reasoning |
|---|---|---|
| `CharacterStatueGump` | `DynamicGump` | Pose/Direction/Material labels are dynamic clilocs (cliloc rule) |
| `CharacterPlinthGump` | `DynamicGump` | `statue.Name`, sculpted-on date, and statue-type cliloc are dynamic (cliloc rule) |

### Decorations (Items/Special/Veteran Rewards) — every `InternalGump` renamed

| Original | New name | Base type | Reasoning |
|---|---|---|---|
| `Banner.InternalGump` | `BannerGump` | `StaticGump<T>` | Fully fixed item-id picker over `Start..End` range |
| `Brazier.InternalGump` | `BrazierGump` | `StaticGump<T>` | Fixed two-item picker |
| `Cannon.InternalGump` | `CannonGump` | `DynamicGump` | `keg.Validate()` value passed as `~1_CHARGES~` arg (cliloc-arg rule) |
| `DecorativeShield.InternalGump` | `DecorativeShieldGump` | `StaticGump<T>` | Fixed item picker over a constant range |
| `DecorativeShield.FacingGump` | `DecorativeShieldFacingGump` | `DynamicGump` | Item ids depend on instance state |
| `HangingSkeleton.InternalGump` | `HangingSkeletonGump` | `StaticGump<T>` | Fixed item picker (5 hard-coded ids) |
| `PottedCactus.InternalGump` | `PottedCactusGump` | `StaticGump<T>` | Fixed 6-item picker |
| `StoneAnkh.InternalGump` | `StoneAnkhGump` | `StaticGump<T>` | Fixed two-direction picker |
| `WallBanner.InternalGump` | `WallBannerGump` | `StaticGump<T>` | Fixed 30-banner picker across 5 pages |
| `WeaponEngravingTool.InternalGump` | `WeaponEngravingToolGump` | `StaticGump<T>` | Fixed text-entry dialog |
| `WeaponEngravingTool.ConfirmGump` | `WeaponEngravingToolConfirmGump` | `DynamicGump` | Layout branches on `guildmaster != null` |

### External callers updated

`RewardSystem`, `CharacterStatue`, `FireFliesDeed`, `FlamingHead`, `Banner`, `DecorativeShield`, `HangingSkeleton`, `StoneAnkh` (RewardDemolitionGump callers); `AnkhOfSacrifice`, `Cannon`, `MiningCart`, `MinotaurStatue`, `TreeStump` (RewardOptionGump callers); `TinkerGuildmaster` (engraver confirm gump).

The pre-existing `FacingGump` inside `Banner.cs` (already `DynamicGump`) was left as-is — it is private, nested inside `InternalTarget`, and never referenced outside.
2026-04-25 20:09:27 -07:00

98 lines
2.7 KiB
C#

using Server.Gumps;
using Server.Items;
using Server.Network;
namespace Server.Engines.VeteranRewards;
public class RewardConfirmGump : DynamicGump
{
private readonly RewardEntry _entry;
private readonly Mobile _from;
public override bool Singleton => true;
private RewardConfirmGump(Mobile from, RewardEntry entry) : base(0, 0)
{
_from = from;
_entry = entry;
}
public static void DisplayTo(Mobile from, RewardEntry entry)
{
if (from?.NetState == null || entry == null)
{
return;
}
from.SendGump(new RewardConfirmGump(from, entry));
}
protected override void BuildLayout(ref DynamicGumpBuilder builder)
{
builder.AddPage();
builder.AddBackground(10, 10, 500, 300, 2600);
builder.AddHtmlLocalized(30, 55, 300, 35, 1006000); // You have selected:
if (_entry.NameString != null)
{
builder.AddHtml(335, 55, 150, 35, _entry.NameString);
}
else
{
builder.AddHtmlLocalized(335, 55, 150, 35, _entry.Name);
}
builder.AddHtmlLocalized(30, 95, 300, 35, 1006001); // This will be assigned to this character:
builder.AddLabel(335, 95, 0, _from.RawName);
// Are you sure you wish to select this reward for this character?
// You will not be able to transfer this reward to another character on another shard.
// Click 'ok' below to confirm your selection or 'cancel' to go back to the selection screen.
builder.AddHtmlLocalized(35, 160, 450, 90, 1006002, true, true);
builder.AddButton(60, 265, 4005, 4007, 1);
builder.AddHtmlLocalized(95, 266, 150, 35, 1006044); // Ok
builder.AddButton(295, 265, 4017, 4019, 0);
builder.AddHtmlLocalized(330, 266, 150, 35, 1006045); // Cancel
}
public override void OnResponse(NetState sender, in RelayInfo info)
{
if (info.ButtonID == 1)
{
if (!RewardSystem.HasAccess(_from, _entry))
{
return;
}
var item = _entry.Construct();
if (item != null)
{
if (item is RedSoulstone soulstone)
{
soulstone.Account = _from.Account.Username;
}
if (RewardSystem.ConsumeRewardPoint(_from))
{
_from.AddToBackpack(item);
}
else
{
item.Delete();
}
}
}
RewardSystem.ComputeRewardInfo(_from, out var cur, out var max);
if (cur < max)
{
RewardNoticeGump.DisplayTo(_from);
}
}
}