## Summary Migrates 16 player-facing legacy `Gump` subclasses in the Veteran Rewards system to `DynamicGump` or `StaticGump<T>`, renames every nested `InternalGump`/`ConfirmGump` to system-prefixed names, and updates external callers to use new static `DisplayTo` entry points. ### Reward chain (Engines/Veteran Rewards) | Gump | Base type | Reasoning | |---|---|---| | `RewardNoticeGump` | `StaticGump<T>` | Fixed layout | | `RewardChoiceGump` | `DynamicGump` | Layout shape varies (per-player categories, entries, pages) | | `RewardConfirmGump` | `DynamicGump` | `entry.Name` is a dynamic cliloc per reward (cliloc rule) | | `RewardOptionGump` | `DynamicGump` | Title cliloc and per-option clilocs are dynamic (cliloc rule) | | `RewardDemolitionGump` | `DynamicGump` | `question` cliloc is dynamic per caller (cliloc rule) | ### Statue (Engines/Veteran Rewards/Character Statue Maker) | Gump | Base type | Reasoning | |---|---|---| | `CharacterStatueGump` | `DynamicGump` | Pose/Direction/Material labels are dynamic clilocs (cliloc rule) | | `CharacterPlinthGump` | `DynamicGump` | `statue.Name`, sculpted-on date, and statue-type cliloc are dynamic (cliloc rule) | ### Decorations (Items/Special/Veteran Rewards) — every `InternalGump` renamed | Original | New name | Base type | Reasoning | |---|---|---|---| | `Banner.InternalGump` | `BannerGump` | `StaticGump<T>` | Fully fixed item-id picker over `Start..End` range | | `Brazier.InternalGump` | `BrazierGump` | `StaticGump<T>` | Fixed two-item picker | | `Cannon.InternalGump` | `CannonGump` | `DynamicGump` | `keg.Validate()` value passed as `~1_CHARGES~` arg (cliloc-arg rule) | | `DecorativeShield.InternalGump` | `DecorativeShieldGump` | `StaticGump<T>` | Fixed item picker over a constant range | | `DecorativeShield.FacingGump` | `DecorativeShieldFacingGump` | `DynamicGump` | Item ids depend on instance state | | `HangingSkeleton.InternalGump` | `HangingSkeletonGump` | `StaticGump<T>` | Fixed item picker (5 hard-coded ids) | | `PottedCactus.InternalGump` | `PottedCactusGump` | `StaticGump<T>` | Fixed 6-item picker | | `StoneAnkh.InternalGump` | `StoneAnkhGump` | `StaticGump<T>` | Fixed two-direction picker | | `WallBanner.InternalGump` | `WallBannerGump` | `StaticGump<T>` | Fixed 30-banner picker across 5 pages | | `WeaponEngravingTool.InternalGump` | `WeaponEngravingToolGump` | `StaticGump<T>` | Fixed text-entry dialog | | `WeaponEngravingTool.ConfirmGump` | `WeaponEngravingToolConfirmGump` | `DynamicGump` | Layout branches on `guildmaster != null` | ### External callers updated `RewardSystem`, `CharacterStatue`, `FireFliesDeed`, `FlamingHead`, `Banner`, `DecorativeShield`, `HangingSkeleton`, `StoneAnkh` (RewardDemolitionGump callers); `AnkhOfSacrifice`, `Cannon`, `MiningCart`, `MinotaurStatue`, `TreeStump` (RewardOptionGump callers); `TinkerGuildmaster` (engraver confirm gump). The pre-existing `FacingGump` inside `Banner.cs` (already `DynamicGump`) was left as-is — it is private, nested inside `InternalTarget`, and never referenced outside.
130 lines
3.7 KiB
C#
130 lines
3.7 KiB
C#
using ModernUO.Serialization;
|
|
using Server.Engines.VeteranRewards;
|
|
using Server.Gumps;
|
|
|
|
namespace Server.Items;
|
|
|
|
public enum MinotaurStatueType
|
|
{
|
|
AttackSouth = 100,
|
|
AttackEast = 101,
|
|
DefendSouth = 102,
|
|
DefendEast = 103
|
|
}
|
|
|
|
[SerializationGenerator(0)]
|
|
public partial class MinotaurStatue : BaseAddon, IRewardItem
|
|
{
|
|
[InvalidateProperties]
|
|
[SerializableField(0)]
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
private bool _isRewardItem;
|
|
|
|
[Constructible]
|
|
public MinotaurStatue(MinotaurStatueType type)
|
|
{
|
|
switch (type)
|
|
{
|
|
case MinotaurStatueType.AttackSouth:
|
|
{
|
|
AddComponent(new AddonComponent(0x306C), 0, 0, 0);
|
|
AddComponent(new AddonComponent(0x306D), -1, 0, 0);
|
|
AddComponent(new AddonComponent(0x306E), 0, -1, 0);
|
|
break;
|
|
}
|
|
case MinotaurStatueType.AttackEast:
|
|
{
|
|
AddComponent(new AddonComponent(0x3074), 0, 0, 0);
|
|
AddComponent(new AddonComponent(0x3075), -1, 0, 0);
|
|
AddComponent(new AddonComponent(0x3076), 0, -1, 0);
|
|
break;
|
|
}
|
|
case MinotaurStatueType.DefendSouth:
|
|
{
|
|
AddComponent(new AddonComponent(0x3072), 0, 0, 0);
|
|
AddComponent(new AddonComponent(0x3073), 0, -1, 0);
|
|
break;
|
|
}
|
|
case MinotaurStatueType.DefendEast:
|
|
{
|
|
AddComponent(new AddonComponent(0x306F), 0, 0, 0);
|
|
AddComponent(new AddonComponent(0x3070), -1, 0, 0);
|
|
AddComponent(new AddonComponent(0x3071), 0, -1, 0);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
public override BaseAddonDeed Deed =>
|
|
new MinotaurStatueDeed
|
|
{
|
|
IsRewardItem = _isRewardItem
|
|
};
|
|
}
|
|
|
|
[SerializationGenerator(0)]
|
|
public partial class MinotaurStatueDeed : BaseAddonDeed, IRewardItem, IRewardOption
|
|
{
|
|
[InvalidateProperties]
|
|
[SerializableField(0)]
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
private bool _isRewardItem;
|
|
|
|
private MinotaurStatueType _statueType;
|
|
|
|
[Constructible]
|
|
public MinotaurStatueDeed() => LootType = LootType.Blessed;
|
|
|
|
public override int LabelNumber => 1080409; // Minotaur Statue Deed
|
|
|
|
public override BaseAddon Addon =>
|
|
new MinotaurStatue(_statueType)
|
|
{
|
|
IsRewardItem = _isRewardItem
|
|
};
|
|
|
|
public void GetOptions(RewardOptionList list)
|
|
{
|
|
list.Add((int)MinotaurStatueType.AttackSouth, 1080410); // Minotaur Attack South
|
|
list.Add((int)MinotaurStatueType.AttackEast, 1080411); // Minotaur Attack East
|
|
list.Add((int)MinotaurStatueType.DefendSouth, 1080412); // Minotaur Defend South
|
|
list.Add((int)MinotaurStatueType.DefendEast, 1080413); // Minotaur Defend East
|
|
}
|
|
|
|
public void OnOptionSelected(Mobile from, int option)
|
|
{
|
|
_statueType = (MinotaurStatueType)option;
|
|
|
|
if (!Deleted)
|
|
{
|
|
base.OnDoubleClick(from);
|
|
}
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (_isRewardItem && !RewardSystem.CheckIsUsableBy(from, this))
|
|
{
|
|
return;
|
|
}
|
|
|
|
if (IsChildOf(from.Backpack))
|
|
{
|
|
RewardOptionGump.DisplayTo(from, this);
|
|
}
|
|
else
|
|
{
|
|
from.SendLocalizedMessage(1062334); // This item must be in your backpack to be used.
|
|
}
|
|
}
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
if (_isRewardItem)
|
|
{
|
|
list.Add(1076218); // 2nd Year Veteran Reward
|
|
}
|
|
}
|
|
}
|