ModernUO/Projects/UOContent/Mobiles/Townfolk
Kamron Batman 4b392079e9
fix: Fixes exploits with bank box deposits. Makes stacking more efficient (#2337)
### Summary

- Fix AccountGold gold duplication exploit: When AccountGold.Enabled was true, double-clicking a BankCheck deposited
the full value to the account but then continued creating physical gold piles for the same amount, duplicating the
value
- Fix Deposit/DepositUpTo partial deposit exploit: Both methods created new max-size gold piles and checks without
first filling existing partial stacks, wasting container slots and causing premature "bank full" failures that could
be leveraged to manipulate gold distribution
- Fix BagOfSending bank stacking: Gold and BankCheck items sent via BagOfSending now use Banker.Deposit for efficient
stacking instead of naive TryDropItem, which could fail on a full bank even when existing piles had room
- Improve gold/check deposit efficiency: Banker.Deposit and Banker.DepositUpTo now top off existing gold piles (up to
60k) and bank checks (up to 1M) before creating new items, maximizing use of available container slots
2026-02-13 20:34:35 -08:00
..
Actor.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
Artist.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
Banker.cs fix: Fixes exploits with bank box deposits. Makes stacking more efficient (#2337) 2026-02-13 20:34:35 -08:00
BaseEscortable.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
BrideGroom.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
EscortableMage.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Gypsy.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
HarborMaster.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
Merchant.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Messenger.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Minter.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Ninja.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Noble.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Peasant.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Prisoner.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Samurai.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Sculptor.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
SeekerOfAdventure.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
TownCrier.cs fix: Adds null-conditional checks when stopping timers for TownCrier (#2206) 2025-06-01 10:33:09 -10:00