## Summary ### Changes - Adds `[IgnoreDupe]` and `[SerializedIgnoreDupe]` - Updates all _known_ classes that need the attribute. Some might be missing, please helps us find them! - Adds `Item.Dupe()` command and encapsulates `CopyProperties` and `OnAfterDuped`. This is also overridable. - Updates Dupe command to use the new logic. - Fixes duping multiple kinds of objects that used to be outright broken. ### Bug Fixes - Fixes issue with durability after duping - Fixes issue with hue after duping > [!Note] > **Developer Note** > Customizing how duping an item works now requires two steps: > 1. Add `[IgnoreDupe]` or `[SerializedIgnoreDupe]` to the property/field > 2. Add custom logic in an `OnAfterDuped` override > > When do you need to do this? > *When the property being copied is not a primitive, and you need to manually deep-clone the contents of the property such as with Lists, Dictionaries, or sub classes.*
92 lines
2.7 KiB
C#
92 lines
2.7 KiB
C#
using Server;
|
|
using Server.Items;
|
|
using Server.Network;
|
|
using Server.Tests;
|
|
using Server.Tests.Network;
|
|
using Xunit;
|
|
|
|
namespace UOContent.Tests;
|
|
|
|
public class TestBook : BaseBook
|
|
{
|
|
public TestBook(int itemID, int pageCount = 20, bool writable = true) : base(itemID, pageCount, writable)
|
|
{
|
|
}
|
|
|
|
public TestBook(int itemID, string title, string author, int pageCount, bool writable) : base(itemID, title, author, pageCount, writable)
|
|
{
|
|
}
|
|
|
|
public TestBook(int itemID, bool writable) : base(itemID, writable)
|
|
{
|
|
}
|
|
|
|
public TestBook(Serial serial) : base(serial)
|
|
{
|
|
Pages = new BookPageInfo[20];
|
|
|
|
for (var i = 0; i < Pages.Length; ++i)
|
|
{
|
|
Pages[i] = new BookPageInfo();
|
|
}
|
|
}
|
|
}
|
|
|
|
public class BookPacketTests : IClassFixture<ServerFixture>
|
|
{
|
|
[Theory]
|
|
[InlineData("🅵🅰🅽🅲🆈 🆃🅴🆇🆃 Author", "🅵🅰🅽🅲🆈 🆃🅴🆇🆃 Title")]
|
|
public void TestBookCover(string author, string title)
|
|
{
|
|
var m = new Mobile((Serial)0x1);
|
|
m.DefaultMobileInit();
|
|
|
|
Serial serial = (Serial)0x1001;
|
|
var book = new TestBook(serial) { Author = author, Title = title };
|
|
|
|
var expected = new BookHeader(m, book).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendBookCover(m, book);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestBookContent()
|
|
{
|
|
var m = new Mobile((Serial)0x1);
|
|
m.DefaultMobileInit();
|
|
|
|
Serial serial = (Serial)0x1001;
|
|
var book = new TestBook(serial) { Author = "Some Author", Title = "Some Title" };
|
|
book.Pages[0].Lines = new[]
|
|
{
|
|
"Some books start with actual content",
|
|
"This book does not have any actual content",
|
|
"Instead it has several pages of useless text"
|
|
};
|
|
|
|
book.Pages[1].Lines = new[]
|
|
{
|
|
"Another page exists but this page:",
|
|
"Has lots of: 🅵🅰🅽🅲🆈 🆃🅴🆇🆃",
|
|
"And just more: 🅵🅰🅽🅲🆈 🆃🅴🆇🆃",
|
|
"So everyone can read: 🅵🅰🅽🅲🆈 🆃🅴🆇🆃"
|
|
};
|
|
|
|
book.Pages[2].Lines = new[]
|
|
{
|
|
"The end"
|
|
};
|
|
|
|
var expected = new BookPageDetails(book).Compile();
|
|
|
|
var ns = PacketTestUtilities.CreateTestNetState();
|
|
ns.SendBookContent(book);
|
|
|
|
var result = ns.SendPipe.Reader.AvailableToRead();
|
|
AssertThat.Equal(result, expected);
|
|
}
|
|
}
|