## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
195 lines
5.1 KiB
C#
195 lines
5.1 KiB
C#
using Server.Engines.VeteranRewards;
|
|
using Server.Gumps;
|
|
using Server.Network;
|
|
|
|
namespace Server.Items
|
|
{
|
|
public class RewardPottedCactus : Item, IRewardItem
|
|
{
|
|
private bool m_IsRewardItem;
|
|
|
|
[Constructible]
|
|
public RewardPottedCactus() : this(Utility.RandomMinMax(0x1E0F, 0x1E14))
|
|
{
|
|
}
|
|
|
|
[Constructible]
|
|
public RewardPottedCactus(int itemID) : base(itemID) => Weight = 5.0;
|
|
|
|
public RewardPottedCactus(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
public override bool ForceShowProperties => ObjectPropertyList.Enabled;
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public bool IsRewardItem
|
|
{
|
|
get => m_IsRewardItem;
|
|
set
|
|
{
|
|
m_IsRewardItem = value;
|
|
InvalidateProperties();
|
|
}
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.WriteEncodedInt(1); // version
|
|
|
|
writer.Write(m_IsRewardItem);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadEncodedInt();
|
|
|
|
m_IsRewardItem = version switch
|
|
{
|
|
1 => reader.ReadBool(),
|
|
_ => m_IsRewardItem
|
|
};
|
|
}
|
|
}
|
|
|
|
public class PottedCactusDeed : Item, IRewardItem
|
|
{
|
|
private bool m_IsRewardItem;
|
|
|
|
[Constructible]
|
|
public PottedCactusDeed() : base(0x14F0)
|
|
{
|
|
LootType = LootType.Blessed;
|
|
Weight = 1.0;
|
|
}
|
|
|
|
public PottedCactusDeed(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
public override int LabelNumber => 1080407; // Potted Cactus Deed
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public bool IsRewardItem
|
|
{
|
|
get => m_IsRewardItem;
|
|
set
|
|
{
|
|
m_IsRewardItem = value;
|
|
InvalidateProperties();
|
|
}
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (m_IsRewardItem && !RewardSystem.CheckIsUsableBy(from, this))
|
|
{
|
|
return;
|
|
}
|
|
|
|
if (IsChildOf(from.Backpack))
|
|
{
|
|
from.CloseGump<InternalGump>();
|
|
from.SendGump(new InternalGump(this));
|
|
}
|
|
else
|
|
{
|
|
from.SendLocalizedMessage(1042038); // You must have the object in your backpack to use it.
|
|
}
|
|
}
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
if (m_IsRewardItem)
|
|
{
|
|
list.Add(1076219); // 3rd Year Veteran Reward
|
|
}
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.WriteEncodedInt(0); // version
|
|
|
|
writer.Write(m_IsRewardItem);
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadEncodedInt();
|
|
|
|
m_IsRewardItem = reader.ReadBool();
|
|
}
|
|
|
|
private class InternalGump : Gump
|
|
{
|
|
private readonly PottedCactusDeed m_Cactus;
|
|
|
|
public InternalGump(PottedCactusDeed cactus) : base(100, 200)
|
|
{
|
|
m_Cactus = cactus;
|
|
|
|
Closable = true;
|
|
Disposable = true;
|
|
Draggable = true;
|
|
Resizable = false;
|
|
|
|
AddPage(0);
|
|
AddBackground(0, 0, 425, 250, 0xA28);
|
|
|
|
AddPage(1);
|
|
AddLabel(45, 15, 0, "Choose a Potted Cactus:");
|
|
|
|
AddItem(45, 75, 0x1E0F);
|
|
AddButton(55, 50, 0x845, 0x846, 0x1E0F);
|
|
|
|
AddItem(105, 75, 0x1E10);
|
|
AddButton(115, 50, 0x845, 0x846, 0x1E10);
|
|
|
|
AddItem(160, 75, 0x1E14);
|
|
AddButton(175, 50, 0x845, 0x846, 0x1E14);
|
|
|
|
AddItem(220, 75, 0x1E11);
|
|
AddButton(235, 50, 0x845, 0x846, 0x1E11);
|
|
|
|
AddItem(280, 75, 0x1E12);
|
|
AddButton(295, 50, 0x845, 0x846, 0x1E12);
|
|
|
|
AddItem(340, 75, 0x1E13);
|
|
AddButton(355, 50, 0x845, 0x846, 0x1E13);
|
|
}
|
|
|
|
public override void OnResponse(NetState sender, RelayInfo info)
|
|
{
|
|
if (m_Cactus?.Deleted != false || info.ButtonID is < 0x1E0F or > 0x1E14)
|
|
{
|
|
return;
|
|
}
|
|
|
|
var cactus = new RewardPottedCactus(info.ButtonID)
|
|
{
|
|
IsRewardItem = m_Cactus.IsRewardItem
|
|
};
|
|
|
|
if (!sender.Mobile.PlaceInBackpack(cactus))
|
|
{
|
|
cactus.Delete();
|
|
sender.Mobile.SendLocalizedMessage(1078837); // Your backpack is full! Please make room and try again.
|
|
}
|
|
else
|
|
{
|
|
m_Cactus.Delete();
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|