## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```
## Notes
1. All API uses that require a formatter like this:
```cs
list.Add(500002, "{0}\t{1}", arg1, arg2);
```
Should be changed to use string interpolation, for example:
```cs
list.Add(500002, $"{arg1}\t{arg2}");
```
2. The following paradigm should no longer be used:
```cs
list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
```
The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
```cs
list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
```
### Benchmarks
```cs
| Method | Mean | Error | StdDev | Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
| BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 | 88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns | - | - |
```
### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
348 lines
9.4 KiB
C#
348 lines
9.4 KiB
C#
using Server.Gumps;
|
|
using Server.Multis;
|
|
using Server.Network;
|
|
using Server.Targeting;
|
|
|
|
namespace Server.Items
|
|
{
|
|
public class MistletoeAddon : Item, IDyable, IAddon
|
|
{
|
|
[Constructible]
|
|
public MistletoeAddon() : this(Utility.RandomDyedHue())
|
|
{
|
|
}
|
|
|
|
[Constructible]
|
|
public MistletoeAddon(int hue) : base(0x2375)
|
|
{
|
|
Hue = hue;
|
|
Movable = false;
|
|
}
|
|
|
|
public MistletoeAddon(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
public bool CouldFit(IPoint3D p, Map map)
|
|
{
|
|
if (!map.CanFit(p.X, p.Y, p.Z, ItemData.Height))
|
|
{
|
|
return false;
|
|
}
|
|
|
|
if (ItemID == 0x2375)
|
|
{
|
|
return BaseAddon.IsWall(p.X, p.Y - 1, p.Z, map); // North wall
|
|
}
|
|
|
|
return BaseAddon.IsWall(p.X - 1, p.Y, p.Z, map); // West wall
|
|
}
|
|
|
|
public Item Deed => new MistletoeDeed(Hue);
|
|
|
|
public virtual bool Dye(Mobile from, DyeTub sender)
|
|
{
|
|
if (Deleted)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
var house = BaseHouse.FindHouseAt(this);
|
|
|
|
if (house?.IsCoOwner(from) == true)
|
|
{
|
|
if (from.InRange(GetWorldLocation(), 1))
|
|
{
|
|
Hue = sender.DyedHue;
|
|
return true;
|
|
}
|
|
|
|
from.SendLocalizedMessage(500295); // You are too far away to do that.
|
|
return false;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(0); // version
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
|
|
Timer.StartTimer(FixMovingCrate);
|
|
}
|
|
|
|
private void FixMovingCrate()
|
|
{
|
|
if (Deleted)
|
|
{
|
|
return;
|
|
}
|
|
|
|
if (Movable || IsLockedDown)
|
|
{
|
|
var deed = Deed;
|
|
|
|
if (Parent is Item item)
|
|
{
|
|
item.AddItem(deed);
|
|
deed.Location = Location;
|
|
}
|
|
else
|
|
{
|
|
deed.MoveToWorld(Location, Map);
|
|
}
|
|
|
|
Delete();
|
|
}
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
var house = BaseHouse.FindHouseAt(this);
|
|
|
|
if (house?.IsCoOwner(from) == true)
|
|
{
|
|
if (from.InRange(GetWorldLocation(), 3))
|
|
{
|
|
from.CloseGump<MistletoeAddonGump>();
|
|
from.SendGump(new MistletoeAddonGump(from, this));
|
|
}
|
|
else
|
|
{
|
|
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
|
|
}
|
|
}
|
|
}
|
|
|
|
private class MistletoeAddonGump : Gump
|
|
{
|
|
private readonly MistletoeAddon m_Addon;
|
|
private readonly Mobile m_From;
|
|
|
|
public MistletoeAddonGump(Mobile from, MistletoeAddon addon) : base(150, 50)
|
|
{
|
|
m_From = from;
|
|
m_Addon = addon;
|
|
|
|
AddPage(0);
|
|
|
|
AddBackground(0, 0, 220, 170, 0x13BE);
|
|
AddBackground(10, 10, 200, 150, 0xBB8);
|
|
AddHtmlLocalized(20, 30, 180, 60, 1062839); // Do you wish to re-deed this decoration?
|
|
AddHtmlLocalized(55, 100, 160, 25, 1011011); // CONTINUE
|
|
AddButton(20, 100, 0xFA5, 0xFA7, 1);
|
|
AddHtmlLocalized(55, 125, 160, 25, 1011012); // CANCEL
|
|
AddButton(20, 125, 0xFA5, 0xFA7, 0);
|
|
}
|
|
|
|
public override void OnResponse(NetState sender, RelayInfo info)
|
|
{
|
|
if (m_Addon.Deleted || info.ButtonID != 1)
|
|
{
|
|
return;
|
|
}
|
|
|
|
if (m_From.InRange(m_Addon.GetWorldLocation(), 3))
|
|
{
|
|
m_From.AddToBackpack(m_Addon.Deed);
|
|
m_Addon.Delete();
|
|
}
|
|
else
|
|
{
|
|
m_From.SendLocalizedMessage(500295); // You are too far away to do that.
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
[Flippable(0x14F0, 0x14EF)]
|
|
public class MistletoeDeed : Item
|
|
{
|
|
[Constructible]
|
|
public MistletoeDeed(int hue = 0) : base(0x14F0)
|
|
{
|
|
Hue = hue;
|
|
Weight = 1.0;
|
|
LootType = LootType.Blessed;
|
|
}
|
|
|
|
public MistletoeDeed(Serial serial) : base(serial)
|
|
{
|
|
}
|
|
|
|
public override int LabelNumber => 1070882; // Mistletoe Deed
|
|
|
|
public override void Serialize(IGenericWriter writer)
|
|
{
|
|
base.Serialize(writer);
|
|
|
|
writer.Write(0); // version
|
|
}
|
|
|
|
public override void Deserialize(IGenericReader reader)
|
|
{
|
|
base.Deserialize(reader);
|
|
|
|
var version = reader.ReadInt();
|
|
}
|
|
|
|
public override void OnSingleClick(Mobile from)
|
|
{
|
|
base.OnSingleClick(from);
|
|
|
|
LabelTo(from, 1070880); // Winter 2004
|
|
}
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
list.Add(1070880); // Winter 2004
|
|
}
|
|
|
|
public override void OnDoubleClick(Mobile from)
|
|
{
|
|
if (IsChildOf(from.Backpack))
|
|
{
|
|
var house = BaseHouse.FindHouseAt(from);
|
|
|
|
if (house?.IsCoOwner(from) == true)
|
|
{
|
|
from.SendLocalizedMessage(1062838); // Where would you like to place this decoration?
|
|
from.BeginTarget(-1, true, TargetFlags.None, Placement_OnTarget);
|
|
}
|
|
else
|
|
{
|
|
from.SendLocalizedMessage(502092); // You must be in your house to do this.
|
|
}
|
|
}
|
|
else
|
|
{
|
|
from.SendLocalizedMessage(1042001); // That must be in your pack for you to use it.
|
|
}
|
|
}
|
|
|
|
public void Placement_OnTarget(Mobile from, object targeted)
|
|
{
|
|
if (targeted is not IPoint3D p)
|
|
{
|
|
return;
|
|
}
|
|
|
|
var loc = new Point3D(p);
|
|
|
|
var house = BaseHouse.FindHouseAt(loc, from.Map, 16);
|
|
|
|
if (house?.IsCoOwner(from) == true)
|
|
{
|
|
var northWall = BaseAddon.IsWall(loc.X, loc.Y - 1, loc.Z, from.Map);
|
|
var westWall = BaseAddon.IsWall(loc.X - 1, loc.Y, loc.Z, from.Map);
|
|
|
|
if (northWall && westWall)
|
|
{
|
|
from.SendGump(new MistletoeDeedGump(from, loc, this));
|
|
}
|
|
else
|
|
{
|
|
PlaceAddon(from, loc, northWall, westWall);
|
|
}
|
|
}
|
|
else
|
|
{
|
|
from.SendLocalizedMessage(1042036); // That location is not in your house.
|
|
}
|
|
}
|
|
|
|
private void PlaceAddon(Mobile from, Point3D loc, bool northWall, bool westWall)
|
|
{
|
|
if (Deleted)
|
|
{
|
|
return;
|
|
}
|
|
|
|
var house = BaseHouse.FindHouseAt(loc, from.Map, 16);
|
|
|
|
if (house?.IsCoOwner(from) != true)
|
|
{
|
|
from.SendLocalizedMessage(1042036); // That location is not in your house.
|
|
return;
|
|
}
|
|
|
|
var itemID = 0;
|
|
|
|
if (northWall)
|
|
{
|
|
itemID = 0x2374;
|
|
}
|
|
else if (westWall)
|
|
{
|
|
itemID = 0x2375;
|
|
}
|
|
else
|
|
{
|
|
from.SendLocalizedMessage(1070883); // The mistletoe must be placed next to a wall.
|
|
}
|
|
|
|
if (itemID > 0)
|
|
{
|
|
Item addon = new MistletoeAddon(Hue);
|
|
|
|
addon.ItemID = itemID;
|
|
addon.MoveToWorld(loc, from.Map);
|
|
|
|
house.Addons.Add(addon);
|
|
Delete();
|
|
}
|
|
}
|
|
|
|
private class MistletoeDeedGump : Gump
|
|
{
|
|
private readonly MistletoeDeed m_Deed;
|
|
private readonly Mobile m_From;
|
|
private readonly Point3D m_Loc;
|
|
|
|
public MistletoeDeedGump(Mobile from, Point3D loc, MistletoeDeed deed) : base(150, 50)
|
|
{
|
|
m_From = from;
|
|
m_Loc = loc;
|
|
m_Deed = deed;
|
|
|
|
AddBackground(0, 0, 300, 150, 0xA28);
|
|
|
|
AddPage(0);
|
|
|
|
AddItem(90, 30, 0x2375);
|
|
AddItem(180, 30, 0x2374);
|
|
AddButton(50, 35, 0x868, 0x869, 1);
|
|
AddButton(145, 35, 0x868, 0x869, 2);
|
|
}
|
|
|
|
public override void OnResponse(NetState sender, RelayInfo info)
|
|
{
|
|
if (m_Deed.Deleted)
|
|
{
|
|
return;
|
|
}
|
|
|
|
switch (info.ButtonID)
|
|
{
|
|
case 1:
|
|
m_Deed.PlaceAddon(m_From, m_Loc, false, true);
|
|
break;
|
|
case 2:
|
|
m_Deed.PlaceAddon(m_From, m_Loc, true, false);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|