ModernUO/Projects/UOContent/Network
Kamron Batman e801a69554 fix(network): do not consume an auth id until ownership is proven
ConsumeAuthId removed the entry before checking the address or the account, so
anyone landing on a live id burned it. Its owner then arrived to "unable to find
auth id" and had to start the login over -- from a packet they had no part in.

Look, then take. A mismatch leaves the id alone and yields no entry; only a
presenter that matches both the address and the account spends it.

The reason given for taking it unconditionally -- that a guessed id must not be
reusable to probe for its owner -- does not survive checking the order. The
address is compared first, so a guesser from anywhere else is rejected before a
username is ever looked at, and one from the victim's own address is already on
their network.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-08 01:21:19 -07:00
..
AutoDenylist feat(network): allowlist false-positive IPs, escalate on behavior (#2556) 2026-07-30 23:12:17 -07:00
Blocklist feat(network): allowlist false-positive IPs, escalate on behavior (#2556) 2026-07-30 23:12:17 -07:00
CrowdSec feat(network): allowlist false-positive IPs, escalate on behavior (#2556) 2026-07-30 23:12:17 -07:00
Firewall feat(network): allowlist false-positive IPs, escalate on behavior (#2556) 2026-07-30 23:12:17 -07:00
LoginAllowlist feat(network): allowlist false-positive IPs, escalate on behavior (#2556) 2026-07-30 23:12:17 -07:00
Packets fix(network): do not consume an auth id until ownership is proven 2026-08-08 01:21:19 -07:00
BanExemptions.cs feat(network): allowlist false-positive IPs, escalate on behavior (#2556) 2026-07-30 23:12:17 -07:00
ContainerGridPacketHandler.cs fix: Bumps deps. Updates copyrights (#2353) 2026-03-05 19:36:54 -08:00
EntityPackets.cs fix: Bumps deps. Updates copyrights (#2353) 2026-03-05 19:36:54 -08:00
FreeshardProtocol.cs fix: Bumps deps. Updates copyrights (#2353) 2026-03-05 19:36:54 -08:00
GameServer.cs perf(network): skip the redundant password verify on game login 2026-08-08 00:18:10 -07:00
GatewayServer.cs feat: Moves network related events to UOContent using code generation (#1945) 2024-09-06 16:57:10 -07:00
MapUO.cs fix: Bumps deps. Updates copyrights (#2353) 2026-03-05 19:36:54 -08:00
NetworkCommands.cs fix: Adds command help, webpage, and fixes issues with other commands (#1669) 2024-02-10 00:19:19 -08:00
ProtocolExtensions.cs fix: Bumps deps. Updates copyrights (#2353) 2026-03-05 19:36:54 -08:00
UOGateway.cs fix: Bumps deps. Updates copyrights (#2353) 2026-03-05 19:36:54 -08:00