ModernUO/Projects/UOContent
Kamron Batman ecbee17690
fix: Optimizes OPL using string interpolation (#1041)
## Breaking Changes (New API)
ObjectPropertyList supports the following API:
```cs
list.Add(500000);
list.Add(500001, stringArgument);
list.Add("Some text");
list.Add($"Some text with {argument}");
list.Add(500002, $"{arg1}\t{arg2}");
```

## Notes
1. All API uses that require a formatter like this:
    ```cs
    list.Add(500002, "{0}\t{1}", arg1, arg2);
    ```
    Should be changed to use string interpolation, for example:
    ```cs
    list.Add(500002, $"{arg1}\t{arg2}");
    ```
2. The following paradigm should no longer be used:
    ```cs
    list.Add(1061170, prop.ToString()); // strength requirement ~1_val~
    ```
    The new string interpolation API will avoid having to convert the argument to a string before writing it to the packet. Instead use the following:
    ```cs
    list.Add(1061170, $"{prop}"); // strength requirement ~1_val~
    ```

### Benchmarks
```cs
|                         Method |     Mean |   Error |  StdDev |  Gen 0 | Allocated |
|------------------------------- |---------:|--------:|--------:|-------:|----------:|
|                BenchmarkOldOPL | 241.0 ns | 0.56 ns | 0.47 ns | 0.0105 |      88 B |
| BenchmarkStringInterpolatedOPL | 199.9 ns | 2.44 ns | 2.39 ns |      - |         - |
```

### Changes
- [X] Removes crash in STArray.Return when array is null.
- [X] Fixes NPE in OPL when entity is null. Serial in packet will be 0 when entity is null.
- [X] Fixes NPE in AosAttributes when Parent is null.
- [X] Changes OPL to use string interpolation.
- [X] Introduces `IPropertyList` to allow extending PropertyList for other uses.
2022-06-02 10:09:53 -07:00
..
Accounting fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
Commands fix: Fixes ValueStringBuilder empty ctor issue (#1035) 2022-05-27 17:49:36 -07:00
Compression fix: Fixes ValueStringBuilder empty ctor issue (#1035) 2022-05-27 17:49:36 -07:00
Configuration cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
Context Menus cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
Engines fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Gumps fix: Fixes ValueStringBuilder empty ctor issue (#1035) 2022-05-27 17:49:36 -07:00
Holiday Stuff fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Items fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Json/Converters Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
Migrations fix: Codegens Food & Beverages (#1021) 2022-05-15 21:56:04 -07:00
Misc fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Mobiles fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Multis fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Network chore: Deletes ConnectUO support (#999) 2022-04-17 09:06:24 -07:00
Regions chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
Skills fix: Removes scale speed by dex for monsters, fixes NPC movement/thinking speed (#1019) 2022-05-15 10:01:14 -07:00
Special Systems fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Spells fix: Optimizes OPL using string interpolation (#1041) 2022-06-02 10:09:53 -07:00
Targets fix: Cleans up Point checks and removes statics (#966) 2022-03-20 23:15:59 -07:00
Utilities fix: Fixes string set in properties (#779) 2021-09-12 12:03:30 -07:00
World Saves feat: Updates to .NET 6 (#843) 2021-11-13 13:38:01 -08:00
UOContent.csproj fix: Updates dependencies & adds Fedora 35/36 support (#1029) 2022-05-19 10:51:24 -07:00