ModernUO/Projects/Server.Tests/Tests/Items/LiftRejectResyncTests.cs
Kamron Batman 00134cac33
test: fix shared state, CI-vacuous tests and harness duplication (#2722)
Follow-up to #2721. It fixes how the remaining tests behave and changes no production code.

## CI
- Both `dotnet test` steps pass `--filter "Category!=Manual"`. Before this, Manual-tagged tests ran on CI anyway.
- The one surviving movement-throttle latency test is the only coverage of burst forgiveness over a full, wrapped history. It loses its Manual tag, so it runs on CI.

## Tests that passed on CI without testing anything
- **Corpse and throwing tests.** They relied on tiledata for the weapon `Layer`, so on CI the equip silently failed and they asserted against empty lists. They now set `Layer` explicitly and assert the equip took effect. `TestThrown` also pins its own strength and range values, so a shard retuning SoulGlaive no longer breaks them.
- **Healthbar poison rows.** Server.Tests registers no poisons, so every row tested `null`. They now use real poison levels.
- **Account packet tests.** The mock accounts reported `Length` 0, so the character-list tests only ever encoded empty slots. They now encode the real characters.
- **Pathing and AI tests that only mean something on real Trammel/Felucca terrain** are now guarded with `TileDataRequirement.SkipIfMissing()`: Britain desk and clutter scenes, house footprints (no MultiData on CI) and fingerprints. Tests that are valid on flat blank terrain stay unguarded. (A synthetic tiledata fixture to run these on CI is a planned follow-up.)
- **Assertions that couldn't fail now check their claim.** Affected tests include the `DefaultWalker` cache use, cache on/off parity requiring a path, the recorder capability flags, the idle-pet gate, the monthly DST recurrence, the AdvancedSearch `Record.Exception` wrappers, `CanFitItem` with no branch-guarded assert, the Firewall callback, and `Import_NoMap`. The Geometry Parse asserts also now use the same input as their TryParse.

## Shared state
Every test that changes process-wide state now restores it, even when an assert fails:
- **The clock.** A new `TimerWheelScope` saves and restores `Core._tickCount`, `Core._now` and the timer wheel. `SimulatedClockScope` covers decay tests.
- **StepCache settings and caches**, via `StepCacheStateScope`.
- **Network state.** The ManualAllowlist, LoginAllowlist, firewall and BanChannel reporters are restored. Global packet handlers are now registered per test and removed afterwards, so they no longer stay registered for later tests.
- **Data and config tables.** `ArchiveJournal` statics, `TileData.ItemTable`, `ObjectPropertyList.Enabled`, `Core.Expansion` and the localization table are restored. One `MobileStatusVersion` restore was resetting a different expansion than the one the test changed.
- **Entities.** Tests with fixed serials now delete what they create. Fixed mobile serials moved to `World.NewMobile`, because deleting a hard-coded serial could unregister a live entity.
- **Collection race.** `SpiralScanTests` no longer clears the spawn cache from a separate collection that could run in parallel with the cache-manager tests.
- **Shared statics.** Classes reading shared static allowlists joined the sequential collection.

## Duplication
New shared helpers replace copy-pasted harness code:
- **Server.Tests:** `PacketAssert.Sends`, used by about 130 packet tests; `TestClientHarness`, `PersistencePipelineScope`, `NetTestHelpers`, `EntityCleanup` and one `TestMulti`.
- **UOContent.Tests:** `TimerWheelScope`, which also holds one wraparound-safe `RunFor`/`RunUntil`; `AiTestStubs`, which merges six walker copies and five identical creature stubs; `MobileTestHarness`, `CommandTestHarness` and `TempDirectory`.

Dead oracle packet classes are removed.

## Cost
| Test | Before | After |
|---|---|---|
| `VirtualSerialTests` | 1.57s | 2ms (starts near the wrap via reflection instead of drawing ~17.9M serials) |
| Event scheduler recurrence loop | 473ms | 1ms |
| CrowdSec drain | 517ms | 16ms (event-driven instead of a fixed 500ms wait) |
| AuthId tests | 248ms | 99ms (SHA2 except the two GameLogin tests) |
| Container cap tests | 5,000 items | 3,449 / 3,277 (one past each protocol cap) |
| Bulk removal | 100k children | 20k children |
| OPL hash distribution | 60k builds | 10k builds |

## Shard-tuning decoupling
- AI assertions read `ReacquireDelay` and `FollowMoveSpeed` instead of hard-coding production tuning.
- The guard friendly-fire test uses an `AI_Mage` stub instead of WhiteWyrm.
- Argon2 assertions pin the `argon2id` variant and `v=19` but read the cost parameters from the configured hasher.

## Tests
| Run | Server.Tests | UOContent.Tests |
|---|---|---|
| With client files | 812 pass | 1,123 pass |
| Without client files (CI simulation) | 800 pass, 12 skip | 1,021 pass, 102 skip |

- The UOContent fixture reads `MODERNUO_TEST_DATA_DIR`; Server.Tests reads `MODERNUO_CLIENT_PATH`.
- The 15 new UOContent skips are the map-dependent guards above.
- Total run time with client files is about 5s, down from about 8s.
2026-10-18 20:11:33 -07:00

264 lines
8.2 KiB
C#

using Server.Items;
using Server.Network;
using Xunit;
using static Server.Tests.TestClientHarness;
namespace Server.Tests;
[Collection("Sequential Server Tests")]
public class LiftRejectResyncTests
{
private static readonly Point3D _baseLoc = new(2200, 2200, 0);
[Fact]
public void PrivateNestedItem_RejectedLift_DoesNotResyncBystander()
{
var (ownerNs, owner) = CreateClient(_baseLoc);
var (bystanderNs, bystander) = CreateClient(new Point3D(_baseLoc.X + 1, _baseLoc.Y, 0));
var backpack = new Container(0xE75) { Layer = Layer.Backpack };
owner.AddItem(backpack);
var pouch = new Container(0xE75);
backpack.DropItem(pouch);
var item = new Item(0x1234);
pouch.DropItem(item);
try
{
bystander.Lift(item, item.Amount, out var rejected, out _);
// Whichever check trips first (CheckNonlocalLift, accessibility, ...), the bystander was
// never sent this private child, so the rejection must not resynchronize it to them.
Assert.True(rejected);
Assert.False(ReceivedContentUpdate(bystanderNs, item.Serial));
}
finally
{
DisposeClient(ownerNs, owner);
DisposeClient(bystanderNs, bystander);
}
}
[Fact]
public void OwnerAlreadyHolding_RejectedLift_ResyncsPrivateChildToOwner()
{
var (ownerNs, owner) = CreateClient(_baseLoc);
var backpack = new Container(0xE75) { Layer = Layer.Backpack };
owner.AddItem(backpack);
var item = new Item(0x1234);
backpack.DropItem(item);
owner.Holding = new Item(0x1);
try
{
owner.Lift(item, item.Amount, out var rejected, out var reject);
Assert.True(rejected);
Assert.Equal(LRReason.AreHolding, reject);
Assert.True(ReceivedContentUpdate(ownerNs, item.Serial));
}
finally
{
owner.Holding?.Delete();
DisposeClient(ownerNs, owner);
}
}
[Fact]
public void GroundItemOutOfRange_RejectedLift_DoesNotResyncRequester()
{
var (requesterNs, requester) = CreateClient(_baseLoc);
var item = new Item(0x1234);
item.MoveToWorld(new Point3D(_baseLoc.X, _baseLoc.Y + 100, 0), Map.Felucca);
try
{
requester.Lift(item, item.Amount, out var rejected, out var reject);
Assert.True(rejected);
Assert.Equal(LRReason.OutOfRange, reject);
Assert.False(ReceivedWorldItem(requesterNs, item));
}
finally
{
DisposeClient(requesterNs, requester);
item.Delete();
}
}
[Fact]
public void GroundContainerOpener_ForcedRejection_ResyncsPrivateChildToOpener()
{
var (requesterNs, requester) = CreateClient(_baseLoc);
var container = new Container(0xE75);
container.MoveToWorld(new Point3D(_baseLoc.X + 1, _baseLoc.Y, 0), Map.Felucca);
var item = new Item(0x1234);
container.DropItem(item);
container.Openers = [requester];
requester.Holding = new Item(0x1);
try
{
requester.Lift(item, item.Amount, out var rejected, out var reject);
Assert.True(rejected);
Assert.Equal(LRReason.AreHolding, reject);
Assert.True(ReceivedContentUpdate(requesterNs, item.Serial));
}
finally
{
requester.Holding?.Delete();
DisposeClient(requesterNs, requester);
container.Delete();
}
}
[Fact]
public void TradePartner_RejectedLift_ResyncsNestedItemToTradePartner()
{
var (aNs, a) = CreateClient(_baseLoc);
var (bNs, b) = CreateClient(new Point3D(_baseLoc.X + 1, _baseLoc.Y, 0));
var trade = new SecureTrade(a, b);
var pouch = new Container(0xE75);
trade.From.Container.DropItem(pouch);
var item = new Item(0x1234);
pouch.DropItem(item);
b.Holding = new Item(0x1);
try
{
// b is a's trade partner: not the item's root and never an Opener of the pouch, but a
// sanctioned recipient of this private child through the trade relationship.
b.Lift(item, item.Amount, out var rejected, out var reject);
Assert.True(rejected);
Assert.Equal(LRReason.AreHolding, reject);
Assert.True(ReceivedContentUpdate(bNs, item.Serial));
}
finally
{
b.Holding?.Delete();
trade.From.Container.Delete();
trade.To.Container.Delete();
DisposeClient(aNs, a);
DisposeClient(bNs, b);
}
}
[Fact]
public void InvisibleItem_RejectedLift_DoesNotResyncToNonStaffOwner()
{
var (ownerNs, owner) = CreateClient(_baseLoc);
var backpack = new Container(0xE75) { Layer = Layer.Backpack };
owner.AddItem(backpack);
var item = new Item(0x1234) { Visible = false };
backpack.DropItem(item);
owner.Holding = new Item(0x1);
try
{
owner.Lift(item, item.Amount, out var rejected, out var reject);
// ProcessDelta never sends an invisible item to a non-staff owner (CanSee gates every
// private recipient); the rejection resync must honor the same gate.
Assert.True(rejected);
Assert.Equal(LRReason.AreHolding, reject);
Assert.False(ReceivedContentUpdate(ownerNs, item.Serial));
}
finally
{
owner.Holding?.Delete();
DisposeClient(ownerNs, owner);
}
}
[Fact]
public void InvisibleItem_RejectedLift_ResyncsToStaffOwner()
{
var (ownerNs, owner) = CreateClient(_baseLoc);
owner.AccessLevel = AccessLevel.GameMaster;
var backpack = new Container(0xE75) { Layer = Layer.Backpack };
owner.AddItem(backpack);
var item = new Item(0x1234) { Visible = false };
backpack.DropItem(item);
owner.Holding = new Item(0x1);
try
{
owner.Lift(item, item.Amount, out var rejected, out var reject);
Assert.True(rejected);
Assert.Equal(LRReason.AreHolding, reject);
Assert.True(ReceivedContentUpdate(ownerNs, item.Serial));
}
finally
{
owner.Holding?.Delete();
DisposeClient(ownerNs, owner);
}
}
[Fact]
public void EquippedItemOnHiddenMobile_RejectedLift_NoEquipResync()
{
var (ownerNs, owner) = CreateClient(_baseLoc);
var (requesterNs, requester) = CreateClient(new Point3D(_baseLoc.X + 1, _baseLoc.Y, 0));
owner.Hidden = true;
var weapon = new Item(0x1234) { Layer = Layer.OneHanded };
owner.AddItem(weapon);
try
{
requester.Lift(weapon, weapon.Amount, out var rejected, out var reject);
// The requester can't see a hidden, non-staff owner: the lift is rejected OutOfSight and
// IsSentTo's CanSee gate must suppress the equip resync.
Assert.True(rejected);
Assert.Equal(LRReason.OutOfSight, reject);
Assert.False(ReceivedEquipUpdate(requesterNs, weapon.Serial));
}
finally
{
weapon.Delete();
DisposeClient(ownerNs, owner);
DisposeClient(requesterNs, requester);
}
}
[Fact]
public void InvisibleGroundItemInRange_RejectedLift_NoWorldResync()
{
var (requesterNs, requester) = CreateClient(_baseLoc);
var item = new Item(0x1234) { Visible = false };
item.MoveToWorld(new Point3D(_baseLoc.X + 1, _baseLoc.Y, 0), Map.Felucca);
try
{
requester.Lift(item, item.Amount, out var rejected, out var reject);
// In range this time (unlike GroundItemOutOfRange above): only Visible gates it, so the
// rejection resync must not hand the requester a world packet for an item they can't see.
Assert.True(rejected);
Assert.Equal(LRReason.OutOfSight, reject);
Assert.False(ReceivedWorldItem(requesterNs, item));
}
finally
{
DisposeClient(requesterNs, requester);
item.Delete();
}
}
}