ModernUO/Projects/Server/Events
Kamron Batman f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
..
AccountLoginEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
AggressiveActionEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
CharacterCreatedEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
EventSink.cs fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
FastwalkEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
GameLoginEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
MovementEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
ServerCrashedEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
ServerListEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
SocketConnectionEvent.cs fix: Cleans up core code (#1187) 2022-10-10 21:47:08 -07:00
SpeechEvent.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00