b042edcf0b
## Summary
Folds **113** hand-written `[SerializableProperty]` members into plain `[SerializableField]` declarations using the v4 setter hooks — value coercion/vetoes via `allowFieldChange`, post-change side effects via `fieldChanged` (whose `oldValue` parameter covers the old-house/old-sender unsubscribe patterns). Net **-450 lines** of setter boilerplate.
```cs
// before
[SerializableProperty(1)]
[CommandProperty(AccessLevel.GameMaster)]
public int Charges
{
get => _charges;
set
{
_charges = Math.Clamp(value, 0, MaxCharges);
InvalidateProperties();
this.MarkDirty();
}
}
// after
[SerializableField(1, allowFieldChange: nameof(AllowChargesChange))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
[InvalidateProperties]
private int _charges;
private bool AllowChargesChange(ref int value)
{
value = Math.Clamp(value, 0, MaxCharges);
return true;
}
```
## How sites were selected
A classifier parsed all 204 `[SerializableProperty]` sites and converted only those matching strict shapes: getter is exactly `get => _field;`, the assignment comes first (after at most an equality guard), and relocated side effects contain no `return`, no `value` mutation, and no field re-assignment. Everything else was left alone deliberately:
- **~34 custom getters** (fallback defaults like `_x == -1 ? Default : _x`, self-healing refs) — no setter hook can express these.
- **~35 pre-assignment logic** (durability Unscale/Scale sandwiches, old-state captures like PotionKeg's pile weight).
- **virtual/override members, name-mismatched backing fields (`m_`), exotic semantics** (guards' `Focus` does work on *equal* assignment; `ChampionSpawn.Active` never assigns its field).
Five sites the classifier refused were converted by hand where the hooks fit cleanly: `ReceiverCrystal.Sender`, `PlayerVendor.House`, `PlayerBarkeeper.House` (old-value unsubscribe via `oldValue`), `BaseSuit.AccessLevel` (its existing virtual `OnAccessLevelChanged` already had the exact callback shape), and `DyeTub.DyedHue` (a true veto: `AllowDyedHueChange(ref int value) => _redyable`).
## Verification
- Build: **0 errors, 0 warnings**.
- **Schema regeneration produces zero Migrations changes** — the conversion is wire- and schema-neutral by construction (same orders, types, and property names), and CI's schema diff check enforces it.
- **835 + 708 tests green.**
## Behavioral notes (all strict improvements, called out for review)
- Generated setters skip everything when the incoming value equals the current one; a few converted setters previously re-ran side effects on equal assignment (redundant `Update()`-style refreshes).
- Generated setters always `MarkDirty()` on change; several converted setters never did (e.g. `DyeTub.DyedHue`, `MorphItem` ranges) — their changes only persisted if something else dirtied the entity. Those latent persistence bugs are fixed by construction.
143 lines
4.5 KiB
C#
143 lines
4.5 KiB
C#
using ModernUO.Serialization;
|
|
using Server.Items;
|
|
|
|
namespace Server.Mobiles
|
|
{
|
|
[SerializationGenerator(2, false)]
|
|
public partial class SwampDragon : BaseMount
|
|
{
|
|
public override string DefaultName => "a swamp dragon";
|
|
|
|
[Constructible]
|
|
public SwampDragon() : base(0x31A, 0x3EBD, AIType.AI_Melee, FightMode.Aggressor)
|
|
{
|
|
BaseSoundID = 0x16A;
|
|
|
|
SetStr(201, 300);
|
|
SetDex(66, 85);
|
|
SetInt(61, 100);
|
|
|
|
SetHits(121, 180);
|
|
|
|
SetDamage(3, 4);
|
|
|
|
SetDamageType(ResistanceType.Physical, 75);
|
|
SetDamageType(ResistanceType.Poison, 25);
|
|
|
|
SetResistance(ResistanceType.Physical, 35, 40);
|
|
SetResistance(ResistanceType.Fire, 20, 30);
|
|
SetResistance(ResistanceType.Cold, 20, 40);
|
|
SetResistance(ResistanceType.Poison, 20, 30);
|
|
SetResistance(ResistanceType.Energy, 30, 40);
|
|
|
|
SetSkill(SkillName.Anatomy, 45.1, 55.0);
|
|
SetSkill(SkillName.MagicResist, 45.1, 55.0);
|
|
SetSkill(SkillName.Tactics, 45.1, 55.0);
|
|
SetSkill(SkillName.Wrestling, 45.1, 55.0);
|
|
|
|
Fame = 2000;
|
|
Karma = -2000;
|
|
|
|
Hue = 0x851;
|
|
|
|
Tamable = true;
|
|
ControlSlots = 1;
|
|
MinTameSkill = 93.9;
|
|
}
|
|
|
|
public override string CorpseName => "a swamp dragon corpse";
|
|
|
|
[InvalidateProperties]
|
|
[SerializableField(0)]
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
private bool _bardingExceptional;
|
|
|
|
[InvalidateProperties]
|
|
[SerializableField(1)]
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
private string _bardingCraftedBy;
|
|
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
[InvalidateProperties]
|
|
[SerializableField(3)]
|
|
private int _bardingHP;
|
|
|
|
[SerializableField(2, fieldChanged: nameof(OnHasBardingChanged))]
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
[InvalidateProperties]
|
|
private bool _hasBarding;
|
|
|
|
private void OnHasBardingChanged(bool oldValue, bool newValue)
|
|
{
|
|
if (_hasBarding)
|
|
{
|
|
Hue = CraftResources.GetHue(_bardingResource);
|
|
Body = 0x31F;
|
|
ItemID = 0x3EBE;
|
|
}
|
|
else
|
|
{
|
|
Hue = 0x851;
|
|
Body = 0x31A;
|
|
ItemID = 0x3EBD;
|
|
}
|
|
}
|
|
|
|
[SerializableField(4, fieldChanged: nameof(OnBardingResourceChanged))]
|
|
[SerializedCommandProperty(AccessLevel.GameMaster)]
|
|
[InvalidateProperties]
|
|
private CraftResource _bardingResource;
|
|
|
|
private void OnBardingResourceChanged(CraftResource oldValue, CraftResource newValue)
|
|
{
|
|
if (_hasBarding)
|
|
{
|
|
Hue = CraftResources.GetHue(newValue);
|
|
}
|
|
}
|
|
|
|
[CommandProperty(AccessLevel.GameMaster)]
|
|
public int BardingMaxHP => _bardingExceptional ? 2500 : 1000;
|
|
|
|
public override int StepsMax => 4480;
|
|
public override bool ReacquireOnMovement => true;
|
|
public override bool AutoDispel => !Controlled;
|
|
public override FoodType FavoriteFood => FoodType.Meat;
|
|
public override int Meat => 19;
|
|
public override int Hides => 20;
|
|
public override int Scales => 5;
|
|
public override ScaleType ScaleType => ScaleType.Green;
|
|
public override bool CanAngerOnTame => true;
|
|
|
|
public override bool OverrideBondingReqs() => true;
|
|
|
|
public override int GetIdleSound() => 0x2CE;
|
|
|
|
public override int GetDeathSound() => 0x2CC;
|
|
|
|
public override int GetHurtSound() => 0x2D1;
|
|
|
|
public override int GetAttackSound() => 0x2C8;
|
|
|
|
public override double GetControlChance(Mobile m, bool useBaseSkill = false) => 1.0;
|
|
|
|
public override void GetProperties(IPropertyList list)
|
|
{
|
|
base.GetProperties(list);
|
|
|
|
if (_hasBarding && _bardingExceptional && _bardingCraftedBy != null)
|
|
{
|
|
list.Add(1060853, _bardingCraftedBy); // armor exceptionally crafted by ~1_val~
|
|
}
|
|
}
|
|
|
|
private void Deserialize(IGenericReader reader, int version)
|
|
{
|
|
_bardingExceptional = reader.ReadBool();
|
|
_bardingCraftedBy = reader.ReadString();
|
|
_hasBarding = reader.ReadBool();
|
|
_bardingHP = reader.ReadInt();
|
|
_bardingResource = (CraftResource)reader.ReadInt();
|
|
}
|
|
}
|
|
}
|