Code cleanup (#188)

Projects/UOContent/Items/Misc/Bola.cs

@@ -84,7 +84,7 @@ namespace Server.Items
 
       to.Damage(1);
 
-      Timer.DelayCall(TimeSpan.FromSeconds(2.0), () => from.EndAction<Bola>());
+      Timer.DelayCall(TimeSpan.FromSeconds(2.0), from.EndAction<Bola>);
     }
 
     private static bool HasFreeHands(Mobile from)
@@ -191,7 +191,7 @@ namespace Server.Items
             from.Animate(11, 5, 1, true, false, 0);
             from.MovingEffect(to, 0x26AC, 10, 0, false, false);
 
-            Timer.DelayCall(TimeSpan.FromSeconds(0.5), () => FinishThrow(from, to));
+            Timer.DelayCall(TimeSpan.FromSeconds(0.5), FinishThrow, from, to);
           }
           else
           {

Projects/UOContent/Items/Misc/Corpses/Corpse.cs

@@ -391,7 +391,7 @@ namespace Server.Items
           }
 
           if (remainder == 0)
-            m_InstancedItems.Add(item, new InstancedItemInfo(item, attackers[attackers.Count - 1]));
+            m_InstancedItems.Add(item, new InstancedItemInfo(item, attackers[^1]));
           else
             m_Unstackables.Add(item);
         }

Projects/UOContent/Items/Misc/DeceitBrazier.cs

@@ -131,6 +131,19 @@ namespace Server.Items
       Effects.PlaySound(loc, map, 0x225);
     }
 
+    private void SummonCreatureToWorld(BaseCreature bc, Point3D spawnLoc, Map map)
+    {
+      bc.Home = Location;
+      bc.RangeHome = SpawnRange;
+      bc.FightMode = FightMode.Closest;
+
+      bc.MoveToWorld(spawnLoc, map);
+
+      DoEffect(spawnLoc, map);
+
+      bc.ForceReacquire();
+    }
+
     public override void OnDoubleClick(Mobile from)
     {
       if (Utility.InRange(from.Location, Location, 2))
@@ -146,18 +159,7 @@ namespace Server.Items
 
             DoEffect(spawnLoc, map);
 
-            Timer.DelayCall(TimeSpan.FromSeconds(1), () =>
-            {
-              bc.Home = Location;
-              bc.RangeHome = SpawnRange;
-              bc.FightMode = FightMode.Closest;
-
-              bc.MoveToWorld(spawnLoc, map);
-
-              DoEffect(spawnLoc, map);
-
-              bc.ForceReacquire();
-            });
+            Timer.DelayCall(TimeSpan.FromSeconds(1), SummonCreatureToWorld, bc, spawnLoc, map);
 
             NextSpawn = DateTime.UtcNow + NextSpawnDelay;
           }

Projects/UOContent/Items/Misc/Firebomb.cs

@@ -167,7 +167,7 @@ namespace Server.Items
 
       Effects.SendMovingEffect(from, to, ItemID, 7, 0, false, false, Hue);
 
-      Timer.DelayCall(TimeSpan.FromSeconds(1.0), () => FirebombReposition_OnTick(p, Map));
+      Timer.DelayCall(TimeSpan.FromSeconds(1.0), FirebombReposition_OnTick, p, Map);
       Internalize();
     }
 

Projects/UOContent/Items/Misc/MorphItem.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Linq;
 
 namespace Server.Items
@@ -118,7 +117,7 @@ namespace Server.Items
           }
       }
 
-      Timer.DelayCall(TimeSpan.Zero, Refresh);
+      Timer.DelayCall(Refresh);
     }
   }
 }

Projects/UOContent/Items/Misc/OilCloth.cs

@@ -33,7 +33,7 @@ namespace Server.Items
       if (Deleted || !from.CanSee(this))
         return false;
 
-      this.ScissorHelper(from, new Bandage(), 1);
+      ScissorHelper(from, new Bandage(), 1);
 
       return true;
     }

Projects/UOContent/Items/Misc/PowerGenerator.cs

@@ -358,7 +358,7 @@ namespace Server.Items
           hues[n.X, n.Y] = NodeHue.Blue;
         }
 
-        Node lastNode = path[path.Length - 1];
+        Node lastNode = path[^1];
         hues[lastNode.X, lastNode.Y] = NodeHue.Red;
 
         for (int i = 0; i < sideLength; i++)

Projects/UOContent/Items/Misc/Teleporter.cs

@@ -401,7 +401,7 @@ namespace Server.Items
             m.Send(new MessageLocalized(Serial, ItemID, MessageType.Regular, 0x3B2, 3, m_MessageNumber, null,
               ""));
 
-          Timer.DelayCall(TimeSpan.FromSeconds(5.0), () => m.EndAction(this));
+          Timer.DelayCall(TimeSpan.FromSeconds(5.0), m.EndAction, this);
         }
 
         return false;

Projects/UOContent/Items/Misc/WarningItem.cs

@@ -105,10 +105,10 @@ namespace Server.Items
           list[i].Broadcast(triggerer);
       }
 
-      Timer.DelayCall(TimeSpan.Zero, InternalCallback);
+      Timer.DelayCall(StopBroadcasting);
     }
 
-    private void InternalCallback()
+    private void StopBroadcasting()
     {
       m_Broadcasting = false;
     }
@@ -207,4 +207,4 @@ namespace Server.Items
       }
     }
   }
-}
+}