fix: Cleans up Point checks and removes statics (#966)
- [X] Removes static freezing/unfreezing. Use other tools for this. - [X] Cleans up IPoint3D allocations - [X] Removes IPoint3D constructors since the compiler may not optimize the constructor path and allow allocations. Note: Instead of `new Point3D(m)`, do something like `new Point3D(m.Location)`. Sorry for the inconvenience. In the long run this will prevent abuse of hot paths that will cause performance issues.
This commit is contained in:
parent
23532db603
commit
0925a2d435
18 changed files with 184 additions and 958 deletions
|
|
@ -554,21 +554,19 @@ namespace Server.Commands.Generic
|
|||
|
||||
public override void Execute(CommandEventArgs e, object obj)
|
||||
{
|
||||
if (obj is not IPoint3D p)
|
||||
if (obj is not IPoint3D ip)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
if (p is Item item)
|
||||
Point3D p = ip switch
|
||||
{
|
||||
p = item.GetWorldTop();
|
||||
}
|
||||
else if (p is Mobile m)
|
||||
{
|
||||
p = m.Location;
|
||||
}
|
||||
Item item => item.GetWorldTop(),
|
||||
Mobile m => m.Location,
|
||||
_ => new Point3D(ip)
|
||||
};
|
||||
|
||||
Add.Invoke(e.Mobile, new Point3D(p), new Point3D(p), e.Arguments);
|
||||
Add.Invoke(e.Mobile, p, p, e.Arguments);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue