warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Cleans up Point checks and removes statics (#966)

Browse source 
- [X] Removes static freezing/unfreezing. Use other tools for this.
- [X] Cleans up IPoint3D allocations
- [X] Removes IPoint3D constructors since the compiler may not optimize the constructor path and allow allocations.


Note: Instead of `new Point3D(m)`, do something like `new Point3D(m.Location)`. Sorry for the inconvenience. In the long run this will prevent abuse of hot paths that will cause performance issues.
This commit is contained in:
Kamron Batman 2022-03-20 23:15:59 -07:00 • committed by GitHub
parent 23532db603
commit 0925a2d435
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
18 changed files with 184 additions and 958 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/UOContent/Items/Misc/InteriorDecorator.cs
View file

@ -320,7 +320,7 @@ namespace Server.Items
if (floorZ > int.MinValue && item.Z < floorZ + 15) // Confirmed : no height checks here
{
item.Location = new Point3D(item.Location, item.Z + 1);
item.Location = new Point3D(item.Location.X, item.Location.Y, item.Z + 1);
}
else
{
@ -334,7 +334,7 @@ namespace Server.Items
if (floorZ > int.MinValue && item.Z > GetFloorZ(item))
{
item.Location = new Point3D(item.Location, item.Z - 1);
item.Location = new Point3D(item.Location.X, item.Location.Y, item.Z - 1);
}
else
{