fix: Changes Map.Sector.Mobiles to link list & Fixes various related crash bugs (#1553)
### Summary
Eliminates `IPooledEnumerable<T>` and `eable.Free()` from `Map` for mobiles. This drastically simplifies code that iterates in range, for example:
```cs
foreach (var m in m.GetMobilesInRange(5))
{
}
```
The code above no longer requires an eable and calling `Free()`.
- [X] Fixed several locations where an NPC that was damaged would cause a server crash.
- [X] Removed an unnecessary allocation in guard fake calls (NPCs calling guards on you)
- [X] Fixes damage precision loss in Poison Strike Spell
- [X] BogThing no longer attempts to "search" for boglings to eat when it is at full health
This commit is contained in:
parent
27f0cec1fa
commit
28c06c1cc0
71 changed files with 796 additions and 591 deletions
|
|
@ -39,8 +39,7 @@ namespace Server.Items
|
|||
|
||||
bool didEffect = false;
|
||||
|
||||
var eable = attacker.GetMobilesInRange(1);
|
||||
foreach (var m in eable)
|
||||
foreach (var m in attacker.GetMobilesInRange(1))
|
||||
{
|
||||
if (m?.Deleted == false && m != defender && m != attacker &&
|
||||
SpellHelper.ValidIndirectTarget(attacker, m) &&
|
||||
|
|
|
|||
|
|
@ -36,10 +36,9 @@ namespace Server.Items
|
|||
attacker.FixedEffect(0x3728, 10, 15);
|
||||
attacker.PlaySound(0x2A1);
|
||||
|
||||
var eable = attacker.GetMobilesInRange(1);
|
||||
using var queue = PooledRefQueue<Mobile>.Create();
|
||||
|
||||
foreach (var m in eable)
|
||||
foreach (var m in attacker.GetMobilesInRange(1))
|
||||
{
|
||||
if (m?.Deleted == false && m != defender && m != attacker &&
|
||||
m.Map == attacker.Map && m.Alive &&
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue