warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(core): Fixes several serialization issues (#355)

Browse source 
- [X] Fixes an issue where a buffer smaller than 8 bytes would not double with enough space in some cases.
- [X] Fixes an issue with dupe copying the savebuffer reference (ugh).
- [X] Streamlines the IGenericWriter API to use better generics.
- [X] Streamlines the IGenericReader API to use better generics.
- [X] Forces `tidying` of a List/HashSet to be done externally since Writers/Readers should not have side effects.
- [X] Fixes an issue where Tidying a list didn't TrimExcess, causing memory leaks.
- [X] Reverted the meaning of `World.Running` to specifically refer to any world state post world loading.
  - NOTE: Do not use this if you want to block on world saves. Instead use checks against `WorldState.Saving` states.
- [X] Fixes an issue with serializing negative DateTime deltas.
- [X] Fixes a potential issue with serializing non-UTC DateTime.

Bumps release version
This commit is contained in:
Kamron Batman 2020-12-23 07:11:41 -08:00 • committed by GitHub
parent 0888ab9b86
commit 4ddb3de026
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
162 changed files with 652 additions and 1045 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Projects/UOContent/Engines/Spawners/BaseSpawner.cs
View file

@ -981,7 +981,7 @@ namespace Server.Engines.Spawners
case 3:
case 2:
{
WayPoint = reader.ReadItem() as WayPoint;
WayPoint = reader.ReadEntity<WayPoint>();
goto case 1;
}
@ -1040,23 +1040,27 @@ namespace Server.Engines.Spawners
for (var i = 0; i < count; ++i)
{
if (reader.ReadEntity() is ISpawnable e)
var e = reader.ReadEntity<ISpawnable>();
if (e == null)
{
if (e is BaseCreature creature)
{
creature.RemoveIfUntamed = true;
}
continue;
}
e.Spawner = this;
if (e is BaseCreature creature)
{
creature.RemoveIfUntamed = true;
}
for (var j = 0; j < Entries.Count; j++)
e.Spawner = this;
for (var j = 0; j < Entries.Count; j++)
{
if (AssemblyHandler.FindFirstTypeForName(Entries[j].SpawnedName) == e.GetType())
{
if (AssemblyHandler.FindFirstTypeForName(Entries[j].SpawnedName) == e.GetType())
{
Entries[j].Spawned.Add(e);
Spawned.Add(e, Entries[j]);
break;
}
Entries[j].Spawned.Add(e);
Spawned.Add(e, Entries[j]);
break;
}
}
}