Clean up: Bugs, LINQ, constructors, default values, and null checks (#18)

This commit is contained in:
Kamron Batman 2019-03-11 14:29:59 -07:00 • committed by GitHub
parent e748af4430
commit 513e54f70e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1094 changed files with 15913 additions and 21892 deletions

View file

@ -107,7 +107,7 @@ namespace Server.Engines.MyRunUO
[Description("Initially creates the database schema.")]
public static void InitMyRunUO_OnCommand(CommandEventArgs e)
{
if (m_Command != null && m_Command.HasCompleted)
if (m_Command?.HasCompleted == true)
{
TableCreation();
e.Mobile.SendMessage("MyRunUO table creation process has been started.");
@ -120,7 +120,7 @@ namespace Server.Engines.MyRunUO
public static void TableCreation()
{
if (m_Command != null && !m_Command.HasCompleted)
if (m_Command?.HasCompleted == false)
return;
// DateTime start = DateTime.Now;
Console.WriteLine("MyRunUO: Creating tables");
@ -154,7 +154,7 @@ namespace Server.Engines.MyRunUO
[Description("Starts the process of updating the MyRunUO character and guild database.")]
public static void UpdateMyRunUO_OnCommand(CommandEventArgs e)
{
if (m_Command != null && m_Command.HasCompleted)
if (m_Command?.HasCompleted == true)
m_Command = null;
if (m_Timer == null && m_Command == null)
@ -170,7 +170,7 @@ namespace Server.Engines.MyRunUO
public static void Begin()
{
if (m_Command != null && m_Command.HasCompleted)
if (m_Command?.HasCompleted == true)
m_Command = null;
if (m_Timer != null || m_Command != null)
@ -252,7 +252,7 @@ namespace Server.Engines.MyRunUO
{
Mobile mob = acct[j];
if (mob != null && mob.AccessLevel < Config.HiddenAccessLevel)
if (mob?.AccessLevel < Config.HiddenAccessLevel)
m_List.Add(mob);
}
@ -713,4 +713,4 @@ namespace Server.Engines.MyRunUO
Complete
}
}
}
}

View file

@ -36,7 +36,7 @@ namespace Server.Engines.MyRunUO
public static void Begin()
{
if (m_Command != null && !m_Command.HasCompleted)
if (m_Command?.HasCompleted == false)
return;
Console.WriteLine("MyRunUO: Updating status database");
@ -69,4 +69,4 @@ namespace Server.Engines.MyRunUO
m_Command?.Enqueue(null);
}
}
}
}