Clean up: Bugs, LINQ, constructors, default values, and null checks (#18)

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/AnimateDeadScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class AnimateDeadScroll : SpellScroll
   {
     [Constructible]
-    public AnimateDeadScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public AnimateDeadScroll(int amount) : base(100, 0x2260, amount)
+    public AnimateDeadScroll(int amount = 1) : base(100, 0x2260, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/BloodOathScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class BloodOathScroll : SpellScroll
   {
     [Constructible]
-    public BloodOathScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public BloodOathScroll(int amount) : base(101, 0x2261, amount)
+    public BloodOathScroll(int amount = 1) : base(101, 0x2261, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/CorpseSkinScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class CorpseSkinScroll : SpellScroll
   {
     [Constructible]
-    public CorpseSkinScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public CorpseSkinScroll(int amount) : base(102, 0x2262, amount)
+    public CorpseSkinScroll(int amount = 1) : base(102, 0x2262, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/CurseWeaponScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class CurseWeaponScroll : SpellScroll
   {
     [Constructible]
-    public CurseWeaponScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public CurseWeaponScroll(int amount) : base(103, 0x2263, amount)
+    public CurseWeaponScroll(int amount = 1) : base(103, 0x2263, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/EvilOmenScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class EvilOmenScroll : SpellScroll
   {
     [Constructible]
-    public EvilOmenScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public EvilOmenScroll(int amount) : base(104, 0x2264, amount)
+    public EvilOmenScroll(int amount = 1) : base(104, 0x2264, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/ExorcismScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class ExorcismScroll : SpellScroll
   {
     [Constructible]
-    public ExorcismScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public ExorcismScroll(int amount) : base(116, 0x2270, amount)
+    public ExorcismScroll(int amount = 1) : base(116, 0x2270, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/HorrificBeastScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class HorrificBeastScroll : SpellScroll
   {
     [Constructible]
-    public HorrificBeastScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public HorrificBeastScroll(int amount) : base(105, 0x2265, amount)
+    public HorrificBeastScroll(int amount = 1) : base(105, 0x2265, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/LichFormScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class LichFormScroll : SpellScroll
   {
     [Constructible]
-    public LichFormScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public LichFormScroll(int amount) : base(106, 0x2266, amount)
+    public LichFormScroll(int amount = 1) : base(106, 0x2266, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/MindRotScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class MindRotScroll : SpellScroll
   {
     [Constructible]
-    public MindRotScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public MindRotScroll(int amount) : base(107, 0x2267, amount)
+    public MindRotScroll(int amount = 1) : base(107, 0x2267, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/PainSpikeScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class PainSpikeScroll : SpellScroll
   {
     [Constructible]
-    public PainSpikeScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public PainSpikeScroll(int amount) : base(108, 0x2268, amount)
+    public PainSpikeScroll(int amount = 1) : base(108, 0x2268, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/PoisonStrikeScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class PoisonStrikeScroll : SpellScroll
   {
     [Constructible]
-    public PoisonStrikeScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public PoisonStrikeScroll(int amount) : base(109, 0x2269, amount)
+    public PoisonStrikeScroll(int amount = 1) : base(109, 0x2269, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/StrangleScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class StrangleScroll : SpellScroll
   {
     [Constructible]
-    public StrangleScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public StrangleScroll(int amount) : base(110, 0x226A, amount)
+    public StrangleScroll(int amount = 1) : base(110, 0x226A, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/SummonFamiliarScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class SummonFamiliarScroll : SpellScroll
   {
     [Constructible]
-    public SummonFamiliarScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public SummonFamiliarScroll(int amount) : base(111, 0x226B, amount)
+    public SummonFamiliarScroll(int amount = 1) : base(111, 0x226B, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/VampiricEmbraceScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class VampiricEmbraceScroll : SpellScroll
   {
     [Constructible]
-    public VampiricEmbraceScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public VampiricEmbraceScroll(int amount) : base(112, 0x226C, amount)
+    public VampiricEmbraceScroll(int amount = 1) : base(112, 0x226C, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/VengefulSpiritScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class VengefulSpiritScroll : SpellScroll
   {
     [Constructible]
-    public VengefulSpiritScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public VengefulSpiritScroll(int amount) : base(113, 0x226D, amount)
+    public VengefulSpiritScroll(int amount = 1) : base(113, 0x226D, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/WitherScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class WitherScroll : SpellScroll
   {
     [Constructible]
-    public WitherScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public WitherScroll(int amount) : base(114, 0x226E, amount)
+    public WitherScroll(int amount = 1) : base(114, 0x226E, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}

Scripts/Items/Skill Items/Magical/Scrolls/Necromancy/WraithFormScroll.cs

@@ -3,12 +3,7 @@ namespace Server.Items
   public class WraithFormScroll : SpellScroll
   {
     [Constructible]
-    public WraithFormScroll() : this(1)
-    {
-    }
-
-    [Constructible]
-    public WraithFormScroll(int amount) : base(115, 0x226F, amount)
+    public WraithFormScroll(int amount = 1) : base(115, 0x226F, amount)
     {
     }
 
@@ -30,4 +25,4 @@ namespace Server.Items
       int version = reader.ReadInt();
     }
   }
-}
+}