Clean up: Bugs, LINQ, constructors, default values, and null checks (#18)

This commit is contained in:
Kamron Batman 2019-03-11 14:29:59 -07:00 • committed by GitHub
parent e748af4430
commit 513e54f70e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1094 changed files with 15913 additions and 21892 deletions

View file

@ -47,7 +47,7 @@ namespace Server.Items
{
Container pack = from.Backpack;
if (pack != null && pack.ConsumeTotal(typeof(Gold), 250))
if (pack?.ConsumeTotal(typeof(Gold), 250) == true)
{
m_GamblePot += 150;
InvalidateProperties();
@ -74,7 +74,7 @@ namespace Server.Items
else if (roll <= 20) // Chance for a regbag
{
from.SendMessage(0x35, "You win a bag of reagents!");
from.AddToBackpack(new BagOfReagents(50));
from.AddToBackpack(new BagOfReagents());
}
else if (roll <= 40) // Chance for gold
{
@ -123,4 +123,4 @@ namespace Server.Items
}
}
}
}
}

View file

@ -17,7 +17,7 @@ namespace Server.Items
public override void OnDoubleClick(Mobile from)
{
BagOfingots ingotBag = new BagOfingots(5000);
BagOfingots ingotBag = new BagOfingots();
if (!from.AddToBackpack(ingotBag))
ingotBag.Delete();

View file

@ -17,7 +17,7 @@ namespace Server.Items
public override void OnDoubleClick(Mobile from)
{
BagOfReagents regBag = new BagOfReagents(50);
BagOfReagents regBag = new BagOfReagents();
if (!from.AddToBackpack(regBag))
regBag.Delete();

View file

@ -17,7 +17,7 @@ namespace Server.Items
public override void OnDoubleClick(Mobile from)
{
SmithBag SmithBag = new SmithBag(5000);
SmithBag SmithBag = new SmithBag();
if (!from.AddToBackpack(SmithBag))
SmithBag.Delete();