Clean up: Bugs, LINQ, constructors, default values, and null checks (#18)

Scripts/Spells/First/Clumsy.cs

@@ -13,7 +13,7 @@ namespace Server.Spells.First
       Reagent.Nightshade
     );
 
-    public ClumsySpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public ClumsySpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -77,4 +77,4 @@ namespace Server.Spells.First
       }
     }
   }
-}
+}

Scripts/Spells/First/CreateFood.cs

@@ -28,7 +28,7 @@ namespace Server.Spells.First
       new FoodInfo(typeof(Peach), "a peach")
     };
 
-    public CreateFoodSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public CreateFoodSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -85,4 +85,4 @@ namespace Server.Spells.First
       return item;
     }
   }
-}
+}

Scripts/Spells/First/Feeblemind.cs

@@ -13,7 +13,7 @@ namespace Server.Spells.First
       Reagent.Nightshade
     );
 
-    public FeeblemindSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public FeeblemindSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -77,4 +77,4 @@ namespace Server.Spells.First
       }
     }
   }
-}
+}

Scripts/Spells/First/Heal.cs

@@ -17,7 +17,7 @@ namespace Server.Spells.First
       Reagent.SpidersSilk
     );
 
-    public HealSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public HealSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -112,4 +112,4 @@ namespace Server.Spells.First
       }
     }
   }
-}
+}

Scripts/Spells/First/MagicArrow.cs

@@ -11,7 +11,7 @@ namespace Server.Spells.First
       Reagent.SulfurousAsh
     );
 
-    public MagicArrowSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public MagicArrowSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -90,4 +90,4 @@ namespace Server.Spells.First
       }
     }
   }
-}
+}

Scripts/Spells/First/NightSight.cs

@@ -12,7 +12,7 @@ namespace Server.Spells.First
       Reagent.SpidersSilk
     );
 
-    public NightSightSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public NightSightSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -72,4 +72,4 @@ namespace Server.Spells.First
       }
     }
   }
-}
+}

Scripts/Spells/First/ReactiveArmor.cs

@@ -1,4 +1,3 @@
-using System.Collections;
 using System.Collections.Generic;
 
 namespace Server.Spells.First
@@ -16,7 +15,7 @@ namespace Server.Spells.First
 
     private static Dictionary<Mobile, ResistanceMod[]> m_Table = new Dictionary<Mobile, ResistanceMod[]>();
 
-    public ReactiveArmorSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public ReactiveArmorSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 

Scripts/Spells/First/Weaken.cs

@@ -13,7 +13,7 @@ namespace Server.Spells.First
       Reagent.Nightshade
     );
 
-    public WeakenSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public WeakenSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -77,4 +77,4 @@ namespace Server.Spells.First
       }
     }
   }
-}
+}