Clean up: Bugs, LINQ, constructors, default values, and null checks (#18)

Scripts/Spells/Second/Agility.cs

@@ -14,7 +14,7 @@ namespace Server.Spells.Second
       Reagent.MandrakeRoot
     );
 
-    public AgilitySpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public AgilitySpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -81,4 +81,4 @@ namespace Server.Spells.Second
       }
     }
   }
-}
+}

Scripts/Spells/Second/Cunning.cs

@@ -14,7 +14,7 @@ namespace Server.Spells.Second
       Reagent.Nightshade
     );
 
-    public CunningSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public CunningSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -81,4 +81,4 @@ namespace Server.Spells.Second
       }
     }
   }
-}
+}

Scripts/Spells/Second/Cure.cs

@@ -13,7 +13,7 @@ namespace Server.Spells.Second
       Reagent.Ginseng
     );
 
-    public CureSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public CureSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -97,4 +97,4 @@ namespace Server.Spells.Second
       }
     }
   }
-}
+}

Scripts/Spells/Second/Harm.cs

@@ -12,7 +12,7 @@ namespace Server.Spells.Second
       Reagent.SpidersSilk
     );
 
-    public HarmSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public HarmSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -105,4 +105,4 @@ namespace Server.Spells.Second
       }
     }
   }
-}
+}

Scripts/Spells/Second/MagicTrap.cs

@@ -14,7 +14,7 @@ namespace Server.Spells.Second
       Reagent.SulfurousAsh
     );
 
-    public MagicTrapSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public MagicTrapSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -90,4 +90,4 @@ namespace Server.Spells.Second
       }
     }
   }
-}
+}

Scripts/Spells/Second/Protection.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections;
 using System.Collections.Generic;
 
 namespace Server.Spells.Second
@@ -17,7 +16,7 @@ namespace Server.Spells.Second
 
     private static Dictionary<Mobile, Tuple<ResistanceMod, DefaultSkillMod>> m_Table = new Dictionary<Mobile, Tuple<ResistanceMod, DefaultSkillMod>>();
 
-    public ProtectionSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public ProtectionSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 

Scripts/Spells/Second/RemoveTrap.cs

@@ -13,7 +13,7 @@ namespace Server.Spells.Second
       Reagent.SulfurousAsh
     );
 
-    public RemoveTrapSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public RemoveTrapSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -76,4 +76,4 @@ namespace Server.Spells.Second
       }
     }
   }
-}
+}

Scripts/Spells/Second/Strength.cs

@@ -14,7 +14,7 @@ namespace Server.Spells.Second
       Reagent.Nightshade
     );
 
-    public StrengthSpell(Mobile caster, Item scroll) : base(caster, scroll, m_Info)
+    public StrengthSpell(Mobile caster, Item scroll = null) : base(caster, scroll, m_Info)
     {
     }
 
@@ -81,4 +81,4 @@ namespace Server.Spells.Second
       }
     }
   }
-}
+}