Code Cleanup & Fixes Warnings (#74)

This commit is contained in:
Kamron Batman 2020-01-18 14:56:45 -08:00 • committed by GitHub
parent e11d1f3ad9
commit 57b14ad690
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
143 changed files with 2960 additions and 3427 deletions

View file

@ -1,3 +1,4 @@
using System;
using Server.Guilds;
using Server.Network;
@ -48,12 +49,10 @@ namespace Server.Gumps
if (fealty == null || !guild.IsMember(fealty))
fealty = leader;
if (fealty == null)
fealty = beholder;
fealty ??= beholder;
string fealtyName;
if ((fealtyName = fealty.Name) == null || (fealtyName = fealtyName.Trim()).Length <= 0)
string fealtyName = fealty.Name?.Trim();
if (string.IsNullOrWhiteSpace(fealtyName))
fealtyName = "(empty)";
if (beholder == fealty)

View file

@ -185,9 +185,7 @@ namespace Server.Guilds
public override void OnResponse(NetState sender, RelayInfo info)
{
PlayerMobile pm = sender.Mobile as PlayerMobile;
if (!IsMember(pm, guild))
if (!(sender.Mobile is PlayerMobile pm && IsMember(pm, guild)))
return;
RankDefinition playerRank = pm.GuildRank;