warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

perf: Zero-alloc interpolation for SendMessage/Overhead APIs (#2434)

Browse source 
## Summary

Phase 1 of a multi-phase optimization to eliminate intermediate string allocations between `$"..."` interpolation and the packet text region for ModernUO's player-facing message APIs.

- Adds `[InterpolatedStringHandler]` overloads to every `Send*`/`Public/Local/Private/NonlocalOverheadMessage`/`Say`/`Emote`/`Whisper`/`Yell`/`SendLocalizedMessageTo` API in `OutgoingMessagePackets`, `Mobile`, and `Item`. Each overload is a 3-line shim that forwards `handler.Text` to the existing span-based path then calls `handler.Clear()` to return the rented `STArrayPool<char>` buffer (matches the established `SpanWriter.WriteAscii(ref RawInterpolatedStringHandler)` precedent).
- Converts `string text/args/affix/name` parameters to `ReadOnlySpan<char>` for consistency with the handler path. `lang` intentionally stays `string` (it's never interpolated and the `??= "ENU"` fallback stays cleaner).
- Adds `int charCount` overloads of the three `GetMaxMessage*Length` helpers so stackalloc sizing can avoid the redundant `ROS<char>` round-trip.
- Moves `Mobile` (17 methods) and `Item` (4 methods) message methods into new partial-class files (`Mobile.Messages.cs`, `Item.Messages.cs`) for organization.

No UOContent call sites change in this PR — existing `string`/`ROS<char>` calls compile unchanged via implicit conversion. Phase 2 (intermediate-string audit) and Phase 3 (cleanup PRs) follow.

## Files

- `Projects/Server/Network/Packets/OutgoingMessagePackets.cs` — `string` → `ROS<char>` for text params, `int charCount` length helpers added, class made `partial`
- `Projects/Server/Network/Packets/OutgoingMessagePackets.Interpolated.cs` (new) — 3 `ref RawInterpolatedStringHandler` extension overloads
- `Projects/Server/Mobiles/Mobile.cs` — message methods extracted (-262 lines)
- `Projects/Server/Mobiles/Mobile.Messages.cs` (new, 463 lines) — moved + ROS-converted methods + 25 handler overloads
- `Projects/Server/Items/Item.cs` — message methods extracted (-93 lines)
- `Projects/Server/Items/Item.Messages.cs` (new, 142 lines) — moved + ROS-converted methods + 4 handler overloads
- `Projects/Server.Tests/Tests/Network/Packets/Outgoing/MessagePacketTests.cs` — 3 new regression tests verifying byte-equivalence for the handler overloads
This commit is contained in:
Kamron Batman 2026-05-03 18:04:02 -07:00 • committed by GitHub
parent b150c48328
commit 5f9fa88220
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 904 additions and 409 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Projects/UOContent/Engines/ML Quests/MLQuestSystem.cs
View file

@ -730,7 +730,7 @@ namespace Server.Engines.MLQuests
}
else if (quester is Item item)
{
item.SendLocalizedMessageTo(pm, cliloc, args, SpeechColor);
item.SendLocalizedMessageTo(pm, cliloc, SpeechColor, args);
}
else
{

4
Projects/UOContent/Items/Special/Solen Items/PowderOfTranslocation.cs
View file

@ -88,11 +88,11 @@ public partial class PowderOfTranslocation : Item
// The ~1_translocationItem~ glows with green energy and absorbs magical power from the powder.
if (_transItemName.Number > 0)
{
item.SendLocalizedMessageTo(from, 1054139, $"#{_transItemName.Number}", 0x43);
item.SendLocalizedMessageTo(from, 1054139, 0x43, $"#{_transItemName.Number}");
}
else if (_transItemName.String != null)
{
item.SendLocalizedMessageTo(from, 1054139, _transItemName.String, 0x43);
item.SendLocalizedMessageTo(from, 1054139, 0x43, _transItemName.String);
}
}
}

21
Projects/UOContent/Misc/MessageHelper.cs
View file

@ -1,21 +0,0 @@
using Server.Network;
namespace Server;
public static class MessageHelper
{
public static void SendLocalizedMessageTo(this Item from, Mobile to, int number, int hue)
{
SendLocalizedMessageTo(from, to, number, "", hue);
}
public static void SendLocalizedMessageTo(this Item from, Mobile to, int number, string args, int hue)
{
to?.NetState.SendMessageLocalized(from.Serial, from.ItemID, MessageType.Regular, hue, 3, number, "", args);
}
public static void SendMessageTo(this Item from, Mobile to, string text, int hue)
{
to?.NetState.SendMessage(from.Serial, from.ItemID, MessageType.Regular, hue, 3, false, "ENU", "", text);
}
}