warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: Adds Mobile.Murderer virtual property, consolidates kill-threshold checks (#2355)

Browse source 
## Summary

- Adds `public virtual bool Murderer => Kills >= 5` property to `Mobile`, replacing ~30 scattered `Kills >= 5` / `Kills < 5` magic-number checks across the codebase
- `BaseCreature` overrides `Murderer` to also return `true` when `AlwaysMurderer` is set
- Updates `Corpse` serialization to v15, storing `_murderer` as a `bool` field (migrated from `int Kills >= 5` in earlier versions)
This commit is contained in:
Jack 2026-03-07 05:36:41 +13:00 • committed by GitHub
parent 192f092ee7
commit 6745cf2075
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
31 changed files with 200 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/Server/Items/Item.cs
View file

@ -2192,7 +2192,7 @@ public partial class Item : IHued, IComparable<Item>, ISpawnable, IObjectPropert
return DeathMoveResult.MoveToBackpack;
}
if (CheckNewbied() && parent.Kills < 5)
if (CheckNewbied() && !parent.Murderer)
{
return DeathMoveResult.MoveToBackpack;
}
@ -2222,7 +2222,7 @@ public partial class Item : IHued, IComparable<Item>, ISpawnable, IObjectPropert
return DeathMoveResult.MoveToBackpack;
}
if (CheckNewbied() && parent.Kills < 5)
if (CheckNewbied() && !parent.Murderer)
{
return DeathMoveResult.MoveToBackpack;
}

4
Projects/Server/Mobiles/Mobile.cs
View file

@ -1642,7 +1642,7 @@ public partial class Mobile : IHued, IComparable<Mobile>, ISpawnable, IObjectPro
{
m_Kills = Math.Max(value, 0);
if (oldValue >= 5 != m_Kills >= 5)
if (oldValue >= 5 != Murderer)
{
Delta(MobileDelta.Noto);
InvalidateProperties();
@ -1653,6 +1653,8 @@ public partial class Mobile : IHued, IComparable<Mobile>, ISpawnable, IObjectPro
}
}
public virtual bool Murderer => Kills >= 5;
[CommandProperty(AccessLevel.Counselor, AccessLevel.GameMaster)]
public virtual bool Criminal
{