warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: Adds Mobile.Murderer virtual property, consolidates kill-threshold checks (#2355)

Browse source 
## Summary

- Adds `public virtual bool Murderer => Kills >= 5` property to `Mobile`, replacing ~30 scattered `Kills >= 5` / `Kills < 5` magic-number checks across the codebase
- `BaseCreature` overrides `Murderer` to also return `true` when `AlwaysMurderer` is set
- Updates `Corpse` serialization to v15, storing `_murderer` as a `bool` field (migrated from `int Kills >= 5` in earlier versions)
This commit is contained in:
Jack 2026-03-07 05:36:41 +13:00 • committed by GitHub
parent 192f092ee7
commit 6745cf2075
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
31 changed files with 200 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Projects/UOContent/Mobiles/BaseCreature.cs
View file

@ -557,6 +557,8 @@ namespace Server.Mobiles
public virtual bool AlwaysMurderer => false;
public override bool Murderer => AlwaysMurderer || base.Murderer;
public virtual bool AlwaysAttackable => false;
[CommandProperty(AccessLevel.GameMaster)]
@ -2806,7 +2808,7 @@ namespace Server.Mobiles
return;
}
if (!Body.IsHuman || Kills >= 5 || AlwaysMurderer || AlwaysAttackable || m.Kills < 5 ||
if (!Body.IsHuman || Murderer || AlwaysAttackable || !m.Murderer ||
!m.InRange(Location, 12) || !m.Alive)
{
return;