feat: adopt serialization generator v4 (field-side linkage, anchored timers) (#2586)

## Summary

Adopts ModernUO.Serialization 4.0.0 across the engine. Three commits, reviewable independently:

1. **Package + tool bump to 4.0.0** (`Server.csproj`, `UOContent.csproj`, `dotnet-tools.json`).
2. **Timers → `[DeserializeTimer]`** — the 8 drifting timers (BaseLight, TreasureMapChest, MarkContainer, FillableContainer, DeathRobe, DecayedCorpse, Corpse, BaseEscortable) now store their next tick as **anchored time**: server downtime no longer consumes the remaining delay, and idle-world saves are byte-stable. This changes their wire format, so each class bumps its serialization version with a `MigrateFrom` that replays the old delta-time read through the migration schema (the new `vN.json` files carry `@AnchoredTimer`; the old ones keep `@TimerDrift`, which the generator reads forever). The 2 wall-clock timers (Aquarium, FountainOfLife) keep their exact format via `wallClock: true` — no bump. Restart methods drop their `TimeSpan.MinValue` sentinel checks: v4 invokes them **only when a timer was actually running at save**.
3. **Linkage → field-side declarations** — 175 conversions across 25 files: `[SerializableFieldSaveFlag(order)]`/`[SerializableFieldDefault(order)]` become `[SaveFlag(nameof(...), nameof(...))]` on the field, and `[SerializableFieldChanged(order)]` becomes the `fieldChanged:` argument of `[SerializableField]`. **Wire-neutral: zero migration schemas changed.**

## Verification

- Solution builds with **0 errors, 0 warnings**; all three 4.0.0 packages verified indexed on nuget.org (no local feed needed).
- **835 + 708 tests green.**
- Generated output inspected: old-version content structs replay `ReadDeltaTime` (e.g. `V3Content.DecayTimerNext = reader.ReadDeltaTime()`), current versions write/read anchored time with the gated restart, and the wall-clock classes emit byte-identical `Write`/`ReadDateTime` framing.
- Schema tool run is committed (CI's `git diff --exit-code` schema check passes): exactly the 8 expected new `vN.json` files, nothing else touched.
- The conversion was scripted with a class-scoped resolver (order → same-class `[SerializableField(order)]`/`[SerializableProperty(order)]`); it planned 175/175 with zero ambiguities before applying.

## Notes

- New `MigrateFrom`s use the content structs' provided `XxxDelay` property, matching the pre-existing idiom in Corpse's and TreasureMapChest's older migrations.
- Follow-up candidate (separate PR, wire-neutral, any time): fold the ~150 eligible hand-written `[SerializableProperty]` setters (clamps, post-change side effects) down to `[SerializableField]` with `allowFieldChange`/`fieldChanged` hooks.
This commit is contained in:
Kamron Batman 2026-08-22 17:54:02 -07:00 committed by GitHub
parent 126a10ce53
commit 73f9688083
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
43 changed files with 667 additions and 278 deletions

View file

@ -11,64 +11,62 @@ public partial class BaseQuiver : Container, ICraftable, IAosItem
[SerializedIgnoreDupe]
[SerializableField(0, setter: "private")]
[SaveFlag(nameof(ShouldSerializeAosAttributes), nameof(AttributesDefaultValue))]
[SerializedCommandProperty(AccessLevel.GameMaster, canModify: true)]
private AosAttributes _attributes;
[SerializableFieldSaveFlag(0)]
private bool ShouldSerializeAosAttributes() => !_attributes.IsEmpty;
[SerializableFieldDefault(0)]
private AosAttributes AttributesDefaultValue() => new(this);
[InvalidateProperties]
[SerializableField(1)]
[SaveFlag(nameof(ShouldSerializeLowerAmmoCost))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private int _lowerAmmoCost;
[SerializableFieldSaveFlag(1)]
private bool ShouldSerializeLowerAmmoCost() => _lowerAmmoCost != 0;
[InvalidateProperties]
[SerializableField(2)]
[SaveFlag(nameof(ShouldSerializeWeightReduction))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private int _weightReduction;
[SerializableFieldSaveFlag(2)]
private bool ShouldSerializeWeightReduction() => _weightReduction != 0;
[InvalidateProperties]
[SerializableField(3)]
[SaveFlag(nameof(ShouldSerializeDamageIncrease))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private int _damageIncrease;
[SerializableFieldSaveFlag(3)]
private bool ShouldSerializeDamageIncrease() => _damageIncrease != 0;
[InvalidateProperties]
[SerializableField(4)]
[SaveFlag(nameof(ShouldSerializeCrafter))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private string _crafter;
[SerializableFieldSaveFlag(4)]
private bool ShouldSerializeCrafter() => !string.IsNullOrEmpty(_crafter);
[InvalidateProperties]
[SerializableField(5)]
[SaveFlag(nameof(ShouldSerializeQuality), nameof(QualityDefaultValue))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private ClothingQuality _quality;
[SerializableFieldSaveFlag(5)]
private bool ShouldSerializeQuality() => _quality != ClothingQuality.Regular;
[SerializableFieldDefault(5)]
private ClothingQuality QualityDefaultValue() => ClothingQuality.Regular;
[InvalidateProperties]
[SerializableField(6)]
[SaveFlag(nameof(ShouldSerializeCapacity))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private int _capacity;
[SerializableFieldSaveFlag(6)]
private bool ShouldSerializeCapacity() => _capacity != 0;
public BaseQuiver(int itemID = 0x2FB7) : base(itemID)