fix: Fixes spell mechanics and misc bugs (#1118)

- [X] Fixes NPE from account tags.
- [X] Fixes bad skill check due to missing cast to double.
- [X] Fixes water elemental duration.
- [X] Standardizes spell summon duration by expansion.
This commit is contained in:
Kamron Batman 2022-07-14 22:01:59 -07:00 • committed by GitHub
parent 2ab0a0e063
commit d6d02de296
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
24 changed files with 74 additions and 66 deletions

View file

@ -33,8 +33,8 @@ namespace Server.Items
public override void OnDoubleClick(Mobile from)
{
if (!IsChildOf(from.Backpack) && Parent != from
) // TODO: These checks don't match EA, but they match BaseTool for now
// TODO: These checks don't match EA, but they match BaseTool for now
if (!IsChildOf(from.Backpack) && Parent != from)
{
from.SendLocalizedMessage(1042001); // That must be in your pack for you to use it.
}

View file

@ -61,7 +61,7 @@ namespace Server.Items
}
else
{
_table.Add(attacker, new List<ForceArrowInfo>() { info });
_table.Add(attacker, new List<ForceArrowInfo> { info });
}
BuffInfo.AddBuff(defender, new BuffInfo(BuffIcon.ForceArrow, 1151285, 1151286, info.DefenseChanceMalus.ToString()));

View file

@ -11,7 +11,7 @@ namespace Server.Items
IncomingPackets.RegisterEncoded(0x19, true, &SetAbility);
}
public static unsafe void SetAbility(NetState state, IEntity e, EncodedReader reader)
public static void SetAbility(NetState state, IEntity e, EncodedReader reader)
{
var m = state.Mobile;
var index = reader.ReadInt32();