warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Fixes serious stacking issue (#1225)

Browse source 
* Fixes a major bug where players can stack items into their backpack infinitely even if they get a message saying they can't.
* Fixes other minor issues and cleans up code.
This commit is contained in:
Kamron Batman 2022-11-02 22:18:44 -07:00 • committed by GitHub
parent d0ba94aa83
commit e47b62c0ae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 17 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Projects/Server/Client/ClientVersion.cs
View file

@ -56,7 +56,7 @@ public class ClientVersion : IComparable<ClientVersion>, IComparer<ClientVersion
Patch = pat;
Type = type;
SourceString = Utility.Intern(ToStringImpl());
SourceString = ToStringImpl().Intern();
}
public ClientVersion(string fmt)

2
Projects/Server/Items/Item.cs
View file

@ -2311,7 +2311,7 @@ public class Item : IHued, IComparable<Item>, ISpawnable, IObjectPropertyListEnt
public virtual bool OnDragDrop(Mobile from, Item dropped)
{
var success = Parent is Container container && container.OnStackAttempt(from, this, dropped) ||
var success = (Parent as Container)?.OnStackAttempt(from, this, dropped) ??
StackWith(from, dropped);
if (success && Spawner != null)