warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Prevent setting properties of higher privileged mobiles (#1420)

Browse source 
---------

Co-authored-by: Kamron Batman <3953314+kamronbatman@users.noreply.github.com>
This commit is contained in:
Mink80 2023-07-16 07:01:33 +02:00 • committed by GitHub
parent 8ff105ac46
commit e9fa2bf9fa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Projects/UOContent/Commands/Properties.cs
View file

@ -363,6 +363,14 @@ namespace Server.Commands
{
try
{
// Don't allow staff to be modified if they are under StaffAccess command
if (obj is Mobile mob &&
(mob.AccessLevel > from.AccessLevel ||
mob.Account?.AccessLevel > from.AccessLevel))
{
return "You cannot modify a higher privileged mobile.";
}
if (toSet is AccessLevel newLevel)
{
var reqLevel = newLevel switch

9
Projects/UOContent/Gumps/Props/SetCustomEnumGump.cs
View file

@ -1,6 +1,7 @@
using System;
using System.Reflection;
using Server.Commands;
using Server.Commands.Generic;
using Server.Network;
namespace Server.Gumps
@ -16,6 +17,14 @@ namespace Server.Gumps
public override void OnResponse(NetState sender, RelayInfo relayInfo)
{
var from = sender.Mobile;
if (!BaseCommand.IsAccessible(from, m_Object))
{
from.SendMessage("You may no longer access their properties.");
return;
}
var index = relayInfo.ButtonID - 1;
if (index >= 0 && index < m_Names.Length)

9
Projects/UOContent/Gumps/Props/SetListOptionGump.cs
View file

@ -1,5 +1,6 @@
using System.Reflection;
using Server.Commands;
using Server.Commands.Generic;
using Server.Network;
using static Server.Gumps.PropsConfig;
@ -164,6 +165,14 @@ namespace Server.Gumps
public override void OnResponse(NetState sender, RelayInfo info)
{
var from = sender.Mobile;
if (!BaseCommand.IsAccessible(from, m_Object))
{
from.SendMessage("You may no longer access their properties.");
return;
}
var index = info.ButtonID - 1;
if (index >= 0 && index < m_Values.Length)