fix(party): Converts party packets (#401)

- [X] Converts party packets

Projects/Server/Network/Packets/OutgoingEntityPackets.cs

@@ -28,6 +28,11 @@ namespace Server.Network
 
         public static void CreateOPLInfo(Span<byte> buffer, Serial serial, int hash)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0xDC); // Packet ID
             writer.Write(serial);

Projects/Server/Network/Packets/OutgoingItemPackets.cs

@@ -25,6 +25,11 @@ namespace Server.Network
 
         public static int CreateWorldItem(Span<byte> buffer, Item item)
         {
+            if (buffer[0] != 0)
+            {
+                return buffer.Length;
+            }
+            
             var itemID = item is BaseMulti ? item.ItemID | 0x4000 : item.ItemID & 0x3FFF;
             var hasAmount = item.Amount != 0;
             var amount = item.Amount;
@@ -95,6 +100,11 @@ namespace Server.Network
 
         public static int CreateWorldItemNew(Span<byte> buffer, Item item, bool isHS)
         {
+            if (buffer[0] != 0)
+            {
+                return buffer.Length;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0xF3); // Packet ID
             writer.Write((short)0x1); // command

Projects/Server/Network/Packets/OutgoingMessagePackets.cs

@@ -49,6 +49,7 @@ namespace Server.Network
             ns.Send(buffer.Slice(0, length));
         }
 
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static int GetMaxMessageLocalizedLength(string args) => 50 + (args?.Length ?? 0) * 2;
 
         public static int CreateMessageLocalized(
@@ -104,6 +105,7 @@ namespace Server.Network
             ns.Send(buffer.Slice(0, length));
         }
 
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static int GetMaxMessageLocalizedAffixLength(string affix, string args) =>
             52 + (affix?.Length ?? 0) + (args?.Length ?? 0) * 2;
 
@@ -145,7 +147,6 @@ namespace Server.Network
             return writer.Position;
         }
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static void SendMessage(
             this NetState ns,
             Serial serial, int graphic, MessageType type, int hue, int font, bool ascii, string lang, string name, string text

Projects/Server/Network/Packets/OutgoingMobilePackets.cs

@@ -39,6 +39,11 @@ namespace Server.Network
 
         public static void CreateBondedStatus(Span<byte> buffer, Serial serial, bool bonded)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0xBF); // Packet ID
             writer.Write((ushort)11); // Length
@@ -68,6 +73,11 @@ namespace Server.Network
 
         public static void CreateDeathAnimation(Span<byte> buffer, Serial killed, Serial corpse)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0xAF); // Packet ID
             writer.Write(killed);
@@ -194,6 +204,11 @@ namespace Server.Network
 
         public static void CreateMobileHits(Span<byte> buffer, Mobile m, bool normalize = false)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0xA1); // Packet ID
             writer.Write(m.Serial);
@@ -214,6 +229,11 @@ namespace Server.Network
 
         public static void CreateMobileMana(Span<byte> buffer, Mobile m, bool normalize = false)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0xA2); // Packet ID
             writer.Write(m.Serial);
@@ -234,6 +254,11 @@ namespace Server.Network
 
         public static void CreateMobileStam(Span<byte> buffer, Mobile m, bool normalize = false)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0xA3); // Packet ID
             writer.Write(m.Serial);
@@ -254,6 +279,11 @@ namespace Server.Network
 
         public static void CreateMobileAttributes(Span<byte> buffer, Mobile m, bool normalize = false)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0x2D); // Packet ID
             writer.Write(m.Serial);
@@ -355,6 +385,11 @@ namespace Server.Network
 
         public static void CreateMobileHealthbar(Span<byte> buffer, Mobile m, Healthbar healthbar)
         {
+            if (buffer[0] != 0)
+            {
+                return;
+            }
+
             switch (healthbar)
             {
                 case Healthbar.Poison:
@@ -442,20 +477,20 @@ namespace Server.Network
             Span<byte> buffer, Mobile beholder, Mobile beheld, int version, bool canBeRenamed
         )
         {
+            if (buffer[0] != 0)
+            {
+                return buffer.Length;
+            }
+
             var name = beheld.Name ?? "";
 
             var writer = new SpanWriter(buffer);
             writer.Write((byte)0x11); // Packet ID
             writer.Seek(2, SeekOrigin.Current);
-
             writer.Write(beheld.Serial);
-
             writer.WriteAscii(name, 30);
-
             writer.WriteAttribute(beheld.HitsMax, beheld.Hits, version == 0, true);
-
             writer.Write(canBeRenamed);
-
             writer.Write((byte)version);
 
             if (version <= 0)