Commit graph

339 commits

Author SHA1 Message Date
Kamron Batman
a48ebb3a5f Fixes FindItemsByType and FindItemByType and new override of IsLockedDown and IsSecure by renaming their methods. 2018-09-15 15:50:35 -07:00
Kamron Batman
970fd563b2 Fixes code according to modern code style. Fixes a few expression bugs. 2018-09-15 09:58:51 -07:00
Kamron Batman
eeabc3d0e8 Removes redundant returns 2018-09-14 15:40:02 -07:00
Kamron Batman
06fa31a7bf Changes properties to use automatic property initializers 2018-09-14 15:23:29 -07:00
Kamron Batman
f0a48ad431 Removes default value initializers 2018-09-14 15:13:14 -07:00
Kamron Batman
ff26dfa375 Fixes implicit ternary expressions 2018-09-14 14:56:48 -07:00
Kamron Batman
c85b0a740c Removes redundant delegate type declarations 2018-09-14 14:32:04 -07:00
Kamron Batman
3c9842ee5a Fixes null propogation 2018-09-14 13:49:23 -07:00
Kamron Batman
22ab83ea9e Replaces types with built-in types. 2018-09-14 13:22:16 -07:00
Kamron Batman
fee83ce560 Fixes implicit array initializers 2018-09-14 13:14:20 -07:00
Kamron Batman
7d3a0ca265 Fixes string interpolation 2018-09-14 13:07:43 -07:00
Kamron Batman
42d0b6271f Fixes sequential checks 2018-09-14 13:00:41 -07:00
Kamron Batman
83dcf536d8 Removes implicit this. 2018-09-14 12:56:58 -07:00
Kamron Batman
04b4cfe75b Removes implicit types 2018-09-14 08:48:39 -07:00
Kamron Batman
33f5e77a24 Fixes body expression style. 2018-09-14 08:46:14 -07:00
Kamron Batman
3f0a72a62f Removes unused namespaces 2018-09-14 08:41:38 -07:00
Kamron Batman
d6c0bf2d4c Sets a default parameter for OnHit. More casting cleanup. 2018-09-09 08:54:10 -07:00
Kamron Batman
aba9452161 More cast conversion fixes 2018-09-06 18:07:42 -07:00
Kamron Batman
6ef32ce910 Fixes unavailable syntax for Mono. 2018-09-03 09:34:36 -07:00
Kamron Batman
f674ec2be0 Adds more formatting 2018-08-19 21:28:24 +08:00
Kamron Batman
e77d695684 Fixes more casting 2018-08-19 11:04:07 +08:00
Kamron Batman
03dd5f1926 Fixes casting checks 2018-08-19 01:38:55 +08:00
Kamron Batman
6987d0c18e
Replaces corpse name (#23) 2018-08-14 23:50:00 +08:00
Kamron Batman
632e8b4757
Upgrades code style - First batch (#22) 2018-08-14 06:16:50 +08:00
Kamron Batman
8ee42c8ea2
Add DefaultName property to Mobiles & Items (#18) 2018-08-09 17:18:41 -07:00
Kamron Batman
b06f5bf60d
Adds better type support for pooled enumerables. Refactors code. (#16) 2018-08-09 14:08:34 -07:00
Kamron Batman
0d9fe76b2b
Fix/consume - Closes #10 (#14)
* Fixes stacking, consumption instead of deletion, and a few other minor issues. Server-side only.
* Fixes stacking of ore.
* Fixes cooking consumption.
2018-02-22 00:57:07 -08:00
Kamron Batman
d8ed7c1da9
Changes to new Gold Ledger system (#3)
Changes new gold system to use separate gold/platinum with DivRem instead of relying on doubles.
2018-02-20 22:47:16 -08:00
Kamron Batman
20ae1b3989
Fixes lots more spelling errors (#5)
* Renames constructable to constructible
* Fixes project references.
* Fixes BaseEquippableLight file name
* Replaces payed with paid.
* Fixes various other spelling errors
2018-02-20 16:01:41 -08:00
Kamron Batman
9a4aeaba0d
Renames trapable to trappable. (#4) 2018-02-20 11:08:02 -08:00
Kamron Batman
bb8f09752f
Renames equiped to equipped. (#1) 2018-02-19 21:51:13 -08:00
Pedro Pardal
7df658cd00 Basic support for mysticism spells, scrolls, inscription craftables, mystic reagents, 6 new spells 2017-03-21 17:31:08 +01:00
VitaNex
7af0579875 + RunUO 2.7 with initial TOL expansion support. 2016-01-27 02:59:11 +00:00
Mark Sturgill
0be4162ae7 fix minor patch errata 2015-07-20 20:46:36 -07:00
Vorspire
1e5bc72366 Infinite Loop Breakout
There is a very rare potential, mostly in custom situations, for the 'BaseRunicTool' 'ApplySkillBonus' method to cause the server to become unresponsive.
The reason for this is that, if you call the method on a 'Spellbook' which already has all 4 of the skills listed by default in 'm_PossibleSpellbookSkills', then 'found' is always true.

This issue has been reproduced on a shard that calls 'ApplySkillBonus' more than once when crafting 'Spellbooks'; the rarity is that the 'ApplyAttributesTo' method may call the 'ApplySkillBonus' more than once; the off-chance of 5 consecutive calls, where each preceding call applies one unique skill of the 'possibleSkills', would result in the 5th call entering the deadlock state.

The fix is quite simple, evaluate the 'count' in the while statement and decrement it for each skill that is checked; removing each skill from the 'possibleSkills' list as they are checked, to prevent them being checked multiple times due to the random indices selection.
2015-07-21 00:45:43 +01:00
Mark Sturgill
d2349164ce edge-case bandaid for disguise kits
this should really be fully rewritten to not be so dependent on the underlying timer state
2014-02-27 13:46:12 -07:00
Mark Sturgill
76b7fa6f30 add OnSingleClick for BulkOrderBook and Aquarium
allow primary LadderController instance to be deleted
add MessageRuleset method to DuelContext
2014-02-22 12:56:58 -07:00
Mark Sturgill
12826da7c4 remove ParentEntity and RootParentEntity
Parent and RootParent are now IEntity properties
refactor object arguments to IEntity for parent related methods
branch and version bump to 2.6
2014-02-15 13:21:28 -07:00
Mark Sturgill
705236b923 proper disguise persistence using kvp instead of dictionary entries 2014-02-15 13:11:50 -07:00
Mark Sturgill
1d2d51b1de change communication crystals to always return true for HandlesOnSpeech
we will be making some changes to the way child items that handle speech events are processed
2014-02-14 21:41:24 -07:00
Mark Sturgill
af0ec21a07 disguisekit generics 2014-02-13 23:12:23 -07:00
Mark Sturgill
436e8f054a add Deleted property to IEntity
cleanup Map.GetObjectsInRange
additional hashtable -> dictionary conversions
generic timer impl for EffectController
2013-11-02 10:52:08 -07:00
Mark Sturgill
1f3569aefc generic explosion potion user list
whitespace
2013-10-24 15:22:56 -07:00
Mark Sturgill
2d60d61a6b misc merge/tidy from Zenvera 2013-10-24 14:23:03 -07:00
Mark Sturgill
88488bc616 generic pooled enumerators
guild event bcp
2013-10-15 21:15:59 -07:00
Mark Sturgill
2061a88da3 correct spelling (thanks Andre Grobler) 2013-10-11 04:03:13 -07:00
Mark Sturgill
ddcc4e7a20 parallel delta queue processing
thread safe packet construction, compilation, compression, gump compilation, sending, coalescing, and many other fixes
TODO:  delta queue recursion fixups, ipooledenumerable fixups/generics
2013-10-11 00:01:05 -07:00
Mark Sturgill
7b6cf66b87 rework Core.TickCount 2013-10-07 00:22:11 -07:00
Mark Sturgill
be920e0c31 Core.TickCount for some AI actions
Correction in NewAsyncSockets
2013-10-06 17:21:40 -07:00
Mark Sturgill
d2c670f5c3 Implement Core.TickCount
Convert movement, actions (lift/use), combat, and spells to use Core.TickCount and avoid DateTime caveats (performance, system time dependency, etc)
Refactor DateTime.Now to DateTime.UtcNow
Add LOS check for Iron Maiden addon
2013-10-06 03:21:18 -07:00