## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
86 lines
3 KiB
C#
86 lines
3 KiB
C#
using System;
|
|
using System.Linq;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests;
|
|
|
|
/// <summary>
|
|
/// Tests for the Html.EscapeHtml extension methods.
|
|
/// These tests verify correct HTML entity escaping and edge cases.
|
|
/// </summary>
|
|
[Collection("Sequential Server Tests")]
|
|
public class HtmlEscapeTests
|
|
{
|
|
[Theory(DisplayName = "No escaping needed")]
|
|
[InlineData("")]
|
|
[InlineData("Hello World")]
|
|
[InlineData("Plain text without special characters")]
|
|
[InlineData("123456789")]
|
|
[InlineData("!@#$%^*()_+-=[]{}|;:,.?")]
|
|
public void EscapeHtml_NoSpecialCharacters_ReturnsUnchanged(string input)
|
|
{
|
|
var result = input.EscapeHtml();
|
|
Assert.Equal(input, result);
|
|
}
|
|
|
|
[Theory(DisplayName = "Single character escaping")]
|
|
[InlineData("<", "<")]
|
|
[InlineData(">", ">")]
|
|
[InlineData("&", "&")]
|
|
[InlineData("\"", """)]
|
|
[InlineData("'", "'")]
|
|
public void EscapeHtml_SingleSpecialCharacter_EscapesCorrectly(string input, string expected)
|
|
{
|
|
var result = input.EscapeHtml();
|
|
Assert.Equal(expected, result);
|
|
}
|
|
|
|
[Theory(DisplayName = "Complex mixed scenarios")]
|
|
[InlineData("<p>Hello & goodbye</p>", "<p>Hello & goodbye</p>")]
|
|
[InlineData("<already>", "&lt;already&gt;")]
|
|
[InlineData("<tag attr=\"value\" data='test'>", "<tag attr="value" data='test'>")]
|
|
[InlineData("a<b>c&d\"e'f", "a<b>c&d"e'f")]
|
|
[InlineData(" ", "&nbsp;")]
|
|
public void EscapeHtml_ComplexScenarios_EscapesAllSpecialCharacters(string input, string expected)
|
|
{
|
|
var result = input.EscapeHtml();
|
|
Assert.Equal(expected, result);
|
|
}
|
|
|
|
[Fact(DisplayName = "Null string input")]
|
|
public void EscapeHtml_NullString_ReturnsEmpty()
|
|
{
|
|
string? input = null;
|
|
var result = input.EscapeHtml();
|
|
Assert.Empty(result);
|
|
}
|
|
|
|
[Fact(DisplayName = "Consecutive special characters")]
|
|
public void EscapeHtml_ConsecutiveSpecialCharacters_EscapesAll()
|
|
{
|
|
const string input = "<<>>&&\"\"''";
|
|
const string expected = "<<>>&&""''";
|
|
var result = input.EscapeHtml();
|
|
Assert.Equal(expected, result);
|
|
}
|
|
|
|
[Fact(DisplayName = "Performance: long string with special characters")]
|
|
public void EscapeHtml_LongStringWithSpecialCharacters_HandlesCorrectly()
|
|
{
|
|
var input = $"Start{new string('<', 100)}End{new string('&', 100)}Final";
|
|
var expected =
|
|
$"Start{string.Join("", Enumerable.Repeat("<", 100))}End{string.Join("", Enumerable.Repeat("&", 100))}Final";
|
|
|
|
var result = input.EscapeHtml();
|
|
Assert.Equal(expected, result);
|
|
}
|
|
|
|
[Fact(DisplayName = "Unicode characters")]
|
|
public void EscapeHtml_UnicodeCharacters_PreservedWithSpecialCharsEscaped()
|
|
{
|
|
const string input = "Hello 世界 <test> & 🎉";
|
|
const string expected = "Hello 世界 <test> & 🎉";
|
|
var result = input.EscapeHtml();
|
|
Assert.Equal(expected, result);
|
|
}
|
|
}
|