9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
64 lines
2 KiB
C#
64 lines
2 KiB
C#
using Server.Engines.Pathing.Cache;
|
|
using Server.Items;
|
|
using Xunit;
|
|
using Xunit.Abstractions;
|
|
|
|
namespace Server.Tests.Pathfinding;
|
|
|
|
[Collection("Sequential Pathfinding Tests")]
|
|
public class BoatPathTests
|
|
{
|
|
private readonly ITestOutputHelper _output;
|
|
|
|
public BoatPathTests(ITestOutputHelper output) => _output = output;
|
|
|
|
// Open water in the south-Britain bay (Trammel), used by the existing swim-bake test.
|
|
private const int MapId = 1;
|
|
private const int WaterX = 1450;
|
|
private const int WaterY = 1770;
|
|
|
|
[SkippableFact]
|
|
public void BoatDeck_HasWalkableSurfaceCells()
|
|
{
|
|
TileDataRequirement.SkipIfMissing();
|
|
StepCache.Instance.Clear();
|
|
var map = Map.Maps[MapId];
|
|
|
|
// SmallBoat North heading = multiID 0x0. A deck is made of surface tiles.
|
|
var boat = new TestMulti(0x0);
|
|
map.GetAverageZ(WaterX, WaterY, out _, out var z, out _);
|
|
boat.MoveToWorld(new Point3D(WaterX, WaterY, (sbyte)z), map);
|
|
|
|
try
|
|
{
|
|
var floor = MultiArt.FindFloorCell(boat);
|
|
Assert.True(floor.HasValue, "non-vacuity: boat deck must have surface (floor) tiles");
|
|
|
|
// The deck cell falls through to the live multi-aware path.
|
|
var mask = StepCache.Instance.TryGetMask(map, floor.Value.X, floor.Value.Y, (sbyte)z);
|
|
Assert.Equal(CacheHitKind.Fallthrough_Multi, mask.HitKind);
|
|
_output.WriteLine($"boat deck floor cell at ({floor.Value.X},{floor.Value.Y})");
|
|
}
|
|
finally
|
|
{
|
|
boat.Delete();
|
|
}
|
|
}
|
|
|
|
private static System.Collections.Generic.HashSet<(int lx, int ly)> LocalShape(BaseMulti multi)
|
|
{
|
|
var mcl = multi.Components;
|
|
var set = new System.Collections.Generic.HashSet<(int, int)>();
|
|
for (var lx = 0; lx < mcl.Width; lx++)
|
|
{
|
|
for (var ly = 0; ly < mcl.Height; ly++)
|
|
{
|
|
if (mcl.Tiles[lx][ly].Length > 0)
|
|
{
|
|
set.Add((lx, ly));
|
|
}
|
|
}
|
|
}
|
|
return set;
|
|
}
|
|
}
|