9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
67 lines
2.8 KiB
C#
67 lines
2.8 KiB
C#
using Server;
|
|
using Server.Engines.Pathing.Cache;
|
|
using Server.Items;
|
|
using Xunit;
|
|
using Xunit.Abstractions;
|
|
|
|
namespace Server.Tests.Pathfinding;
|
|
|
|
[Collection("Sequential Pathfinding Tests")]
|
|
public class FoundationRedesignTests
|
|
{
|
|
private readonly ITestOutputHelper _output;
|
|
|
|
public FoundationRedesignTests(ITestOutputHelper output) => _output = output;
|
|
|
|
private const int MapId = 1;
|
|
private const int PlaceX = 1500;
|
|
private const int PlaceY = 1600;
|
|
|
|
[SkippableFact]
|
|
public void RedesignReRegistered_RoutesNewFootprintToLivePath()
|
|
{
|
|
TileDataRequirement.SkipIfMissing();
|
|
StepCache.Instance.Clear();
|
|
var map = Map.Maps[MapId];
|
|
Assert.NotNull(map);
|
|
|
|
var foundation = new SwappableFoundation(0x74);
|
|
map.GetAverageZ(PlaceX, PlaceY, out _, out var z, out _);
|
|
var loc = new Point3D(PlaceX, PlaceY, (sbyte)z);
|
|
foundation.MoveToWorld(loc, map);
|
|
|
|
try
|
|
{
|
|
// Current design's covered cells route to the live (multi-aware) path.
|
|
var before = MultiArt.FindFloorCell(foundation);
|
|
Assert.True(before.HasValue, "non-vacuity: initial design must have a floor cell");
|
|
var maskBefore = StepCache.Instance.TryGetMask(map, before.Value.X, before.Value.Y, (sbyte)z);
|
|
Assert.Equal(CacheHitKind.Fallthrough_Multi, maskBefore.HitKind);
|
|
|
|
// Redesign, RE-REGISTERED so sectors track the new footprint (model a real commit).
|
|
// Internalize() moves the multi to Map.Internal, which fires Map.OnLeave and removes
|
|
// the OLD footprint's sector registration. We then swap the MCL and MoveToWorld back,
|
|
// which fires Map.OnEnter -> AddMulti against the fresh Components (new footprint).
|
|
foundation.Internalize();
|
|
foundation.Redesign(MultiData.GetComponents(0x7A));
|
|
foundation.MoveToWorld(loc, map);
|
|
|
|
var after = MultiArt.FindFloorCell(foundation);
|
|
Assert.True(after.HasValue, "non-vacuity: redesigned design must have a floor cell");
|
|
// The new footprint cell must be registered (HasMultis) and route to the live path.
|
|
var sector = map.GetRealSector(after.Value.X >> 4, after.Value.Y >> 4);
|
|
Assert.True(sector.HasMultis, "redesigned footprint must re-register its sector");
|
|
var maskAfter = StepCache.Instance.TryGetMask(map, after.Value.X, after.Value.Y, (sbyte)z);
|
|
Assert.Equal(CacheHitKind.Fallthrough_Multi, maskAfter.HitKind);
|
|
|
|
_output.WriteLine($"redesign re-registered: before {before.Value.X},{before.Value.Y} after {after.Value.X},{after.Value.Y}");
|
|
}
|
|
finally
|
|
{
|
|
if (!foundation.Deleted)
|
|
{
|
|
foundation.Delete();
|
|
}
|
|
}
|
|
}
|
|
}
|