9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
62 lines
2.2 KiB
C#
62 lines
2.2 KiB
C#
using System;
|
|
using Server.Mobiles;
|
|
using Server.Spells.Ninjitsu;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Spells.Ninjitsu;
|
|
|
|
[Collection("Sequential UOContent Tests")]
|
|
public class AnimalFormTests
|
|
{
|
|
private static int IndexOf(Type type) => Array.FindIndex(AnimalForm.Entries, e => e.Type == type);
|
|
|
|
private static Mobile NewMobileWithNinjitsu(double skill)
|
|
{
|
|
var m = new Mobile(World.NewMobile);
|
|
m.DefaultMobileInit();
|
|
m.Skills.Ninjitsu.Base = skill;
|
|
return m;
|
|
}
|
|
|
|
// Issue #2452: with only 30 Ninjitsu the gump showed every form (including Dog, which needs 40)
|
|
// because the selectable check compared Skill.Fixed (value x10) against the raw ReqSkill.
|
|
[Fact]
|
|
public void CanSelectEntry_FormAboveSkill_IsNotSelectable()
|
|
{
|
|
var m = NewMobileWithNinjitsu(30.0);
|
|
|
|
Assert.False(AnimalForm.CanSelectEntry(m, AnimalForm.Entries[IndexOf(typeof(Dog))])); // ReqSkill 40
|
|
Assert.False(AnimalForm.CanSelectEntry(m, AnimalForm.Entries[IndexOf(typeof(Cat))])); // ReqSkill 40
|
|
|
|
m.Delete();
|
|
}
|
|
|
|
[Fact]
|
|
public void CanSelectEntry_FormAtOrBelowSkill_IsSelectable()
|
|
{
|
|
var m = NewMobileWithNinjitsu(40.0);
|
|
|
|
Assert.True(AnimalForm.CanSelectEntry(m, AnimalForm.Entries[IndexOf(typeof(Dog))])); // ReqSkill 40 (== boundary)
|
|
Assert.True(AnimalForm.CanSelectEntry(m, AnimalForm.Entries[IndexOf(typeof(Rat))])); // ReqSkill 20
|
|
Assert.True(AnimalForm.CanSelectEntry(m, AnimalForm.Entries[IndexOf(typeof(Rabbit))])); // ReqSkill 20
|
|
|
|
m.Delete();
|
|
}
|
|
|
|
// Talisman-gated forms are never selectable without the matching talisman, regardless of skill.
|
|
// Issue #2452: attempting a form above your skill must report NoSkill (so the caller can
|
|
// refrain from charging mana) and must not actually transform the caster.
|
|
[Fact]
|
|
public void Morph_InsufficientSkill_ReturnsNoSkillAndDoesNotTransform()
|
|
{
|
|
var m = NewMobileWithNinjitsu(30.0);
|
|
|
|
var result = AnimalForm.Morph(m, IndexOf(typeof(Dog))); // needs 40
|
|
|
|
Assert.Equal(AnimalForm.MorphResult.NoSkill, result);
|
|
Assert.Null(AnimalForm.GetContext(m));
|
|
Assert.Equal(0, (int)m.BodyMod);
|
|
|
|
m.Delete();
|
|
}
|
|
}
|