warrentyexpired/ModernUO
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ModernUO/dev-docs/claude-skills/migrate-from-runuo/migrate-items-mobiles.md
Kamron Batman e52d54b7da
perf: keep damage entries in an inline intrusive list (#2605) 
## Summary

`Mobile.DamageEntries` was a `List<DamageEntry>` allocated for every mobile, including the ~99% that never take damage. It is now an inline `ValueLinkList<DamageEntry>` (24 bytes in the `Mobile` object, no separate allocation) ordered least recent → most recent.

- `DamageEntry` implements `IValueLinkListNode<DamageEntry>`.
- `RegisterDamage` moves the entry to the tail in O(1) instead of `Remove` + `Add` on a list.
- Expired entries are always a head prefix, so pruning walks from the head and stops at the first live entry. The `DamageEntries` getter prunes on access.
- `DamageEntries` is exposed as `ref readonly`; enumerate with `foreach` or `.ByDescending()`. Mutation goes through `RegisterDamage` / `ClearDamageEntries`.
- `BaseCreature.GetLootingRights` and `BaseCreature.ComputeBonusDamage` take `in ValueLinkList<DamageEntry>`; all callers compile unchanged. Files that `foreach` over `DamageEntries` need `using Server.Collections;` for the enumerator extension.
- RunUO migration docs (`dev-docs/runuo-migration-docs/09`, `11`) and the `migrate-items-mobiles` skill document the change.

Saves one object and 16 bytes per mobile (~8 MB and 500k gen2 objects on a 500k world). Second of three PRs from the lazy per-mobile collections design (first: #2604). Branched from `main`; the two diffs touch disjoint hunks of `Mobile.cs`.

## Breaking change

- `Mobile.DamageEntries` is no longer a `List<DamageEntry>`. Indexing, `.Clear()`, `.Add()`, `.Remove()` no longer compile; use `foreach`, `.ByDescending()`, `.Count`, `ClearDamageEntries()`, and `RegisterDamage`. Calling a `ValueLinkList` mutator on the `ref readonly` property compiles but operates on a copy while still unlinking the real nodes; do not.
- `BaseCreature.GetLootingRights` and `BaseCreature.ComputeBonusDamage` signatures changed to `(in ValueLinkList<DamageEntry>, …)`.

Save format is untouched: damage entries are not serialized.

## Behavior

Recency order, `allowSelf`, tie-breaking in `FindMostTotal`/`FindLeastTotal` (most recent wins), `Responsible` accounting, and loot-rights ordering are unchanged and covered by the new `DamageEntryTests` and `LootingRightsTests`.

## Testing

- `dotnet build -c Release` clean.
- New `DamageEntryTests` and `LootingRightsTests` plus full `Server.Tests` and `UOContent.Tests`.
2026-09-01 23:25:14 -07:00

3.1 KiB
Raw Blame History

name description
migrate-items-mobiles Trigger: when converting RunUO Item, Mobile, or BaseCreature subclasses to ModernUO. Most common migration task. Covers: complete item/creature conversion combining serialization, timers, properties, naming.

RunUO -> ModernUO Item/Mobile/Creature Migration

When This Activates

  • Converting any Item subclass from RunUO
  • Converting any Mobile/BaseCreature subclass
  • This is the most common migration task -- combines all other systems

Item Conversion Checklist

  1. Foundation: file-scoped namespace, using ModernUO.Serialization;
  2. Class: add [SerializationGenerator(N, false)] (N = old version + 1, false if old Deserialize used ReadInt()), add partial
  3. Fields: m_X -> [SerializableField(N)] _x with [SerializedCommandProperty]
  4. Add [InvalidateProperties] where RunUO setter called InvalidateProperties()
  5. Delete: Serial constructor, Serialize, Deserialize
  6. [Constructable] -> [Constructible]
  7. Name = "text" -> public override string DefaultName => "text";
  8. Timers: nested class -> Timer.StartTimer() + TimerExecutionToken + [AfterDeserialization] + OnAfterDelete
  9. Properties: GetProperties(ObjectPropertyList) -> GetProperties(IPropertyList), apply string hole rule
  10. Context menus: List<ContextMenuEntry> -> ref PooledRefList<ContextMenuEntry>

Creature-Specific Changes

  • [CorpseName("...")] attribute -> public override string CorpseName => "...";
  • BaseCreature(AI, Fight, 10, 1, 0.2, 0.4) -> BaseCreature(AI, Fight) (extra params default)
  • Name = "text" -> public override string DefaultName => "text";
  • Expression-bodied overrides: public override int Meat { get { return 1; } } -> public override int Meat => 1;
  • AI movement calls lose the run flag: MoveTo(m, true, range) -> MoveTo(m, range) (also WalkMobileRange, ApproachTarget, MoveToPoint, PathFollower.Follow); the Running bit is derived from step pace -> dev-docs/runuo-migration-docs/09-items-mobiles-creatures.md § AI Movement
  • AcquireOnApproach (bool) -> AcquireOnApproachDelay (TimeSpan; Zero = old instant behavior) -> same doc § Target Acquisition
  • DamageEntries is an inline ref readonly ValueLinkList<DamageEntry>, not a List: indexer/Add/Remove/Clear -> foreach / .ByDescending() (needs using Server.Collections;) and ClearDamageEntries(); GetLootingRights takes it by in -> same doc § Damage Entries

Anti-Patterns

  • Using _field-- instead of Property-- (bypasses MarkDirty tracking)
  • Forgetting [AfterDeserialization] for timer restoration
  • Forgetting OnAfterDelete() for timer cancellation

See Also

  • dev-docs/runuo-migration-docs/09-items-mobiles-creatures.md -- detailed migration with before/after examples
  • dev-docs/content-patterns.md -- ModernUO content templates
  • dev-docs/claude-skills/modernuo-content-patterns.md -- ModernUO content skill
  • dev-docs/claude-skills/modernuo-serialization.md -- serialization patterns
  • dev-docs/claude-skills/modernuo-timers.md -- timer patterns