ModernUO/Projects/UOContent/Items/Addons
Kamron Batman ec85d97482
perf: Migrate Holiday and Decorative gumps to DynamicGump/StaticGump (#2413)
## Summary

Migrates 10 player-facing legacy `Gump` subclasses for holiday and decorative items to the modern `DynamicGump` / `StaticGump<T>` system. All migrated gumps are `Singleton`, use private constructors gated by static `DisplayTo(...)` entry points (empty-gump rule, CLAUDE.md §13), and replace legacy `m_X` fields with `_x` per coding standards.

Per-gump base type and rationale:

- **Mistletoe.cs** — `MistletoeAddonGump` -> `StaticGump<MistletoeAddonGump>`. Fixed re-deed confirmation layout.
- **StValentinesBears.cs** — Renamed `InternalGump` -> `StValentinesBearsGump`, base `StaticGump<T>`. Fixed sign-bear layout with three text entries; legacy `m_Bear` -> `_bear`. Switched legacy `AddTextEntry(..., size)` -> `AddTextEntryLimited(...)` (modern API split).
- **Wreath.cs** — `WreathAddonGump` -> `StaticGump<WreathAddonGump>`. Fixed re-deed confirmation layout.
- **HolidayPottedPlant.cs** — Renamed `InternalGump` -> `HolidayPottedPlantGump`, base `StaticGump<T>`. Fixed plant-picker layout.
- **SnowStatue.cs** — Renamed `InternalGump` -> `SnowStatueGump`, base `StaticGump<T>`. Fixed statue-picker layout. Dropped unused `Mobile from` ctor arg.
- **TapestryOfSosaria.cs** — Renamed `InternalGump` -> `TapestryOfSosariaGump`, base `StaticGump<T>`. Single image, fixed.
- **HouseRaffleDeed.cs** — `WritOfLeaseGump` -> `DynamicGump`. Description HTML is computed per-instance from deed expiration / days-left, so layout text varies per instance. Added `Singleton => true` (was missing implicitly via legacy default).
- **SpecialScroll.cs** — Renamed `InternalGump` -> `SpecialScrollGump`, base `DynamicGump`. **Cliloc rule**: `_scroll.Message`, `_scroll.Title`, `_scroll.SkillLabel` are dynamic cliloc numbers per scroll type — `AddHtmlLocalized` bakes the cliloc number into the cached layout, so `StaticGump<T>` cannot cache it.
- **BallotBox.cs** — Renamed `InternalGump` -> `BallotBoxGump`, base `DynamicGump`. Layout shape varies: variable topic-line count, owner-vs-voter buttons, and vote-tally bars all add/remove elements. Legacy `m_Box` -> `_box`. Updated the `TopicPrompt` callbacks to call `BallotBoxGump.DisplayTo(...)` instead of allocating a new gump directly.
- **AquariumGump.cs** — `AquariumGump` -> `DynamicGump`. Per-page layout depends on each item's `LabelNumber` and (for `BaseFish`) `GetDescription()` cliloc — those vary per fish/decoration. Two `DisplayTo` overloads (auto-detect access vs explicit edit flag) to mirror the original two call sites in `Aquarium.cs`. Legacy `m_Aquarium` -> `_aquarium`.

### Skipped

- **HouseRaffleManagementGump.cs** — Skipped as **staff-only**. Only invoked via `ManagementEntry` context entry inside `HouseRaffleStone.cs`, gated by `from.AccessLevel >= AccessLevel.Seer`. Per task instructions, staff-only gumps are out of scope for this PR.

### External callers updated

- `Aquarium.cs` — Two `new AquariumGump(...)` sites swapped to `AquariumGump.DisplayTo(...)`.

All other migrated inner classes were nested in the same file and only had local references, which were updated to call the new `DisplayTo(...)` static entry point.
2026-04-25 17:22:41 -07:00
..
AbbatoirAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AddonComponent.cs fix: Fixes null components in BaseAddon (#2208) 2025-06-02 22:11:40 -10:00
AddonContainerComponent.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
AlchemistTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AlchemistTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AnvilEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
AnvilSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcaneBookshelfEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcaneBookshelfSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcaneCircleAddon.cs fix: Fixes addons that do not give deeds (#1224) 2022-11-02 19:26:51 -07:00
ArcanistStatueEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcanistStatueSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ArcheryButteAddon.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
BallotBox.cs perf: Migrate Holiday and Decorative gumps to DynamicGump/StaticGump (#2413) 2026-04-25 17:22:41 -07:00
BaseAddon.cs fix: Fixes null components in BaseAddon (#2208) 2025-06-02 22:11:40 -10:00
BaseAddonContainer.cs fix: Fixes serialization and dirty tracking conveniences (#1627) 2023-12-03 15:55:31 -08:00
BaseAddonContainerDeed.cs fix: Moves containers/bods/traps/etc to serialization generator (#2310) 2026-01-07 21:55:55 -08:00
BaseAddonDeed.cs fix: Optimizes items to use default weights. (Part 1) (#2240) 2025-07-24 14:44:39 -07:00
BearRugs.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
BloodPentagram.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
DartBoard.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
ElvenBedEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenDresserEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenDresserSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenForgeAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenLoveseatEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenLoveseatSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenSpinningWheelEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenSpinningwheelSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenStoveEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenStoveSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenWashbasinEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ElvenWashbasinSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FancyElvenTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FancyElvenTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FireColumnAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
FlourMillEastAddon.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
FlourMillSouthAddon.cs fix: Fixes crafter deserialize, cleans up bandages, and codegens misc items (#1350) 2023-02-25 00:54:12 -08:00
FlowerTapestries.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GiantWebs.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GozaMats.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GrayBrickFireplaceEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
GrayBrickFireplaceSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
JackOLantern.cs fix: Fixes addons that do not give deeds (#1224) 2022-11-02 19:26:51 -07:00
LargeBedEastAddon.cs fix: Codegens construction items (#1520) 2023-09-29 23:28:51 -07:00
LargeBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeForgeEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeForgeSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeStoneTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LargeStoneTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LoomEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
LoomSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
MediumStoneTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
MediumStoneTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenChestEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenChestSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenTableEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
OrnateElvenTableSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ParrotPerchAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
PentagramAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
PickpocketDips.cs feat: Adds SerializedCommandProperty (#1249) 2022-11-14 18:24:33 -08:00
PyramidAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
RejuvinationAnkhs.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SandstoneFireplaceEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SandstoneFireplaceSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SandstoneFountainAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SerpentPillarAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
ShrineOfWisdomAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SHTeleporter.cs fix: Fixes missing methods. Adds more admin gump world building (#1675) 2024-02-10 20:31:25 -08:00
SkullPileAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SmallBedEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SmallBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SmallForgeAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SolenAntHole.cs fix: Fixes serialization and dirty tracking conveniences (#1627) 2023-12-03 15:55:31 -08:00
SpinningwheelEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SpinningwheelSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SquirrelStatueEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
SquirrelStatueSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneFireplaceEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneFireplaceSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneFountainAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneOvenEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StoneOvenSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
StretchedHides.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
TallElvenBedEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
TallElvenBedSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
Telescope.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
TrainingDummies.cs feat: Adds SerializedCommandProperty (#1249) 2022-11-14 18:24:33 -08:00
WarriorStatueEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WarriorStatueSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WaterTroughEastAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WaterTroughSouthAddon.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00
WaterVat.cs fix: Updates serialization to use v2.0 (#998) 2022-04-17 08:02:15 -07:00