ModernUO/Projects/UOContent/Items/Misc/PlayerBulletinBoards.cs
Kamron Batman 84153fba58
fix: Fixes dirty-tracking gaps in generated content: setters, sub-object owners, BaseVendor (#2609)
## Why

Delta world saves re-serialize an entity only when it has been marked dirty. An audit of the generated classes found three ways serialized state changes without a mark; this PR closes the ones that do not need a new generator package.

## What

- **Custom `[SerializableProperty]` setters mark dirty.** Twelve hand-written setters assigned their backing field without `this.MarkDirty()`. `PlagueBeastLord.OpenedBy` was an auto-property carrying the attribute with no backing field at all; it is now a generated field with the same name, order and command-property exposure.
- **Generated sub-objects are linked to their owner.** Without a `[DirtyTrackingEntity]` member the generator emits setters that mark nothing. Eight entity-owned sub-objects now carry the link and receive the owner through the constructor the generator calls: `BOBFilter` (owner is `IEntity`: a `PlayerMobile` or a `BulkOrderBook`), `BOBLargeSubEntry`, `PuzzleChestSolution` and `PuzzleChestSolutionAndTime`, `TalismanAttribute` (the random factories now take the talisman), `VendorItem`, `PlayerBBMessage`, `RaffleEntry`, `ShardPollOption`. Migration schemas were regenerated with the pinned tool; the only change is the value rule argument becoming `DeserializationRequiresParent`.
- **BaseVendor uses the generator; restock amounts are no longer persisted.** The only state it wrote was which buy entries had grown restock amounts, packed by index into the live `SBInfos` tables. Restock is transient now and rebuilds on load; version 1 records are read and discarded through the legacy path. Every vendor subclass now serializes through a generated chain.

## Generator 4.1.0

This PR adopts SerializationGenerator 4.1.0 (modernuo/SerializationGenerator#55): SG3019/SG3020 diagnostics, `[VolatileSerializedState]`, `StopXxx()` timer helpers, and owner-constructor preference for sub-objects (so dictionary values are constructed with their owner; the 4.0.0 relink fallback is gone). `PlayerVendor.v3.json` gains `DeserializationRequiresParent` for its `VendorItem` values so the migration content struct constructs them with their vendor.

SG3019 is an error under `TreatWarningsAsErrors` and generator diagnostics ignore pragmas, so the five contexts that live in whole-file player-keyed persistences (`ChampionTitle`, `ChampionTitleContext`, `MurderContext`, `VirtueContext`, `JailRecord`) now carry a `[DirtyTrackingEntity]` link to their `PlayerMobile`, which is where they will live once those blobs move onto the player record. `JailSystem.EmptyRecord` keeps a null player (`[CanBeNull]`). `ChampionTitle` needs both a context and a player constructor because the generator resolves the rule against the containing type but emits the call with the parent field; a comment in the file records this.

## Wire format

Unchanged. No version bumps except `BaseVendor` 1 to 2 (which now writes nothing of its own). Schema diffs are rule-argument only (`DeserializationRequiresParent`).

## Testing

Server.Tests 848 passed, UOContent.Tests 759 passed.
2026-09-06 09:43:44 -07:00

565 lines
17 KiB
C#

using System;
using System.Collections.Generic;
using ModernUO.Serialization;
using Server.Collections;
using Server.ContextMenus;
using Server.Gumps;
using Server.Mobiles;
using Server.Multis;
using Server.Network;
using Server.Prompts;
namespace Server.Items;
[SerializationGenerator(0, false)]
public partial class PlayerBBSouth : BasePlayerBB
{
[Constructible]
public PlayerBBSouth() : base(0x2311)
{
}
public override double DefaultWeight => 15.0;
public override int LabelNumber => 1062421; // bulletin board (south)
}
[SerializationGenerator(0, false)]
public partial class PlayerBBEast : BasePlayerBB
{
[Constructible]
public PlayerBBEast() : base(0x2312)
{
}
public override double DefaultWeight => 15.0;
public override int LabelNumber => 1062420; // bulletin board (east)
}
[SerializationGenerator(0, false)]
public abstract partial class BasePlayerBB : Item, ISecurable
{
[SerializedIgnoreDupe]
[SerializableField(0)]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private SecureLevel _level;
[SerializableField(1)]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private string _title;
[CanBeNull]
[SerializedIgnoreDupe]
[SerializableField(2)]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private PlayerBBMessage _greeting;
[SerializedIgnoreDupe]
[SerializableField(3)]
private List<PlayerBBMessage> _messages;
public BasePlayerBB(int itemID) : base(itemID)
{
_messages = new List<PlayerBBMessage>();
_level = SecureLevel.Anyone;
}
public override void OnAfterDuped(Item newItem)
{
if (newItem is not BasePlayerBB board)
{
return;
}
if (_greeting != null)
{
board.Greeting = new PlayerBBMessage(board, _greeting.Time, _greeting.Poster, _greeting.Message);
}
for (var i = 0; i < _messages.Count; i++)
{
var message = _messages[i];
board.AddToMessages(new PlayerBBMessage(board, message.Time, message.Poster, message.Message));
}
}
public override void GetContextMenuEntries(Mobile from, ref PooledRefList<ContextMenuEntry> list)
{
base.GetContextMenuEntries(from, ref list);
SetSecureLevelEntry.AddTo(from, this, ref list);
}
public static bool CheckAccess(BaseHouse house, Mobile from)
{
if (house.Public || !house.IsAosRules)
{
return !house.IsBanned(from);
}
return house.HasAccess(from);
}
public override void OnDoubleClick(Mobile from)
{
var house = BaseHouse.FindHouseAt(this);
if (house?.HasLockedDownItem(this) != true)
{
from.SendLocalizedMessage(1062396); // This bulletin board must be locked down in a house to be usable.
}
else if (!from.InRange(GetWorldLocation(), 2) || !from.InLOS(this))
{
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
}
else if (CheckAccess(house, from))
{
PlayerBBGump.DisplayTo(from, house, this, 0);
}
}
public class PostPrompt : Prompt
{
private BasePlayerBB _board;
private bool _greeting;
private BaseHouse _house;
private int _page;
public PostPrompt(int page, BaseHouse house, BasePlayerBB board, bool greeting)
{
_page = page;
_house = house;
_board = board;
_greeting = greeting;
}
public override void OnCancel(Mobile from)
{
OnResponse(from, "");
}
public override void OnResponse(Mobile from, string text)
{
var page = _page;
var house = _house;
var board = _board;
if (house?.HasLockedDownItem(board) != true)
{
from.SendLocalizedMessage(1062396); // This bulletin board must be locked down in a house to be usable.
return;
}
if (!from.InRange(board.GetWorldLocation(), 2) || !from.InLOS(board))
{
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
return;
}
if (!CheckAccess(house, from))
{
from.SendLocalizedMessage(1062398); // You are not allowed to post to this bulletin board.
return;
}
if (_greeting && !house.IsOwner(from))
{
return;
}
text = text.Trim();
if (text.Length > 255)
{
text = text[..255];
}
if (text.Length > 0)
{
var message = new PlayerBBMessage(board, Core.Now, from, text);
if (_greeting)
{
board.Greeting = message;
}
else
{
board.AddToMessages(message);
if (board.Messages.Count > 50)
{
board.RemoveFromMessagesAt(0);
if (page > 0)
{
--page;
}
}
}
}
PlayerBBGump.DisplayTo(from, house, board, page);
}
}
public class SetTitlePrompt : Prompt
{
private BasePlayerBB _board;
private BaseHouse _house;
private int _page;
public SetTitlePrompt(int page, BaseHouse house, BasePlayerBB board)
{
_page = page;
_house = house;
_board = board;
}
public override void OnCancel(Mobile from)
{
OnResponse(from, "");
}
public override void OnResponse(Mobile from, string text)
{
var page = _page;
var house = _house;
var board = _board;
if (house?.HasLockedDownItem(board) != true)
{
from.SendLocalizedMessage(1062396); // This bulletin board must be locked down in a house to be usable.
return;
}
if (!from.InRange(board.GetWorldLocation(), 2) || !from.InLOS(board))
{
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
return;
}
if (!CheckAccess(house, from))
{
from.SendLocalizedMessage(1062398); // You are not allowed to post to this bulletin board.
return;
}
text = text.Trim();
if (text.Length > 255)
{
text = text[..255];
}
if (text.Length > 0)
{
board.Title = text;
}
PlayerBBGump.DisplayTo(from, house, board, page);
}
}
}
[PropertyObject]
[SerializationGenerator(0)]
public partial class PlayerBBMessage
{
[DirtyTrackingEntity]
private BasePlayerBB _board;
[SerializableField(0)]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private DateTime _time;
[SerializableField(1)]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private Mobile _poster;
[SerializableField(2)]
[SerializedCommandProperty(AccessLevel.GameMaster)]
private string _message;
public PlayerBBMessage(BasePlayerBB board) => _board = board;
public PlayerBBMessage(BasePlayerBB board, DateTime time, Mobile poster, string message)
{
_board = board;
_time = time;
_poster = poster;
_message = message;
}
}
public class PlayerBBGump : DynamicGump
{
private const int LabelColor = 0x7FFF;
private const int LabelHue = 1153;
private readonly BasePlayerBB _board;
private readonly Mobile _from;
private readonly BaseHouse _house;
private int _page;
public override bool Singleton => true;
private PlayerBBGump(Mobile from, BaseHouse house, BasePlayerBB board, int page) : base(50, 10)
{
_page = page;
_from = from;
_house = house;
_board = board;
}
public static void DisplayTo(Mobile from, BaseHouse house, BasePlayerBB board, int page)
{
if (from?.NetState == null || house == null || board == null || board.Deleted)
{
return;
}
from.SendGump(new PlayerBBGump(from, house, board, page));
}
protected override void BuildLayout(ref DynamicGumpBuilder builder)
{
var page = _page;
builder.AddPage();
builder.AddImage(30, 30, 5400);
builder.AddButton(393, 145, 2084, 2084, 4); // Scroll up
builder.AddButton(390, 371, 2085, 2085, 5); // Scroll down
builder.AddButton(32, 183, 5412, 5413, 1); // Post message
if (_house.IsOwner(_from))
{
builder.AddButton(63, 90, 5601, 5605, 2);
builder.AddHtmlLocalized(81, 89, 230, 20, 1062400, LabelColor); // Set title
builder.AddButton(63, 109, 5601, 5605, 3);
builder.AddHtmlLocalized(81, 108, 230, 20, 1062401, LabelColor); // Post greeting
}
var title = _board.Title;
if (title != null)
{
builder.AddHtml(183, 68, 180, 23, title);
}
builder.AddHtmlLocalized(385, 89, 60, 20, 1062409, LabelColor); // Post
builder.AddLabel(440, 89, LabelHue, $"{page}");
builder.AddLabel(455, 89, LabelHue, "/");
builder.AddLabel(470, 89, LabelHue, $"{_board.Messages.Count}");
var message = _board.Greeting;
if (page >= 1 && page <= _board.Messages.Count)
{
message = _board.Messages[page - 1];
}
builder.AddImageTiled(150, 220, 240, 1, 2700); // Separator
builder.AddHtmlLocalized(150, 180, 100, 20, 1062405, 16715); // Posted On:
builder.AddHtmlLocalized(150, 200, 100, 20, 1062406, 16715); // Posted By:
if (message != null)
{
builder.AddHtml(255, 180, 150, 20, $"{message.Time:yyyy-MM-dd HH:mm:ss}");
var poster = message.Poster;
var posterName = poster?.Name ?? "Someone";
builder.AddHtml(255, 200, 150, 20, posterName.AsSpan().Trim());
builder.AddHtml(150, 240, 250, 100, message.Message ?? "");
if (message != _board.Greeting && _house.IsOwner(_from))
{
builder.AddButton(130, 395, 1209, 1210, 6);
builder.AddHtmlLocalized(150, 393, 150, 20, 1062410, LabelColor); // Banish Poster
builder.AddButton(310, 395, 1209, 1210, 7);
builder.AddHtmlLocalized(330, 393, 150, 20, 1062411, LabelColor); // Delete Message
}
if (_from.AccessLevel >= AccessLevel.GameMaster)
{
builder.AddButton(135, 242, 1209, 1210, 8); // Post props
}
}
}
public override void OnResponse(NetState sender, in RelayInfo info)
{
var from = _from;
var house = _house;
var board = _board;
if (house?.HasLockedDownItem(board) != true)
{
from.SendLocalizedMessage(1062396); // This bulletin board must be locked down in a house to be usable.
return;
}
if (!from.InRange(board.GetWorldLocation(), 2) || !from.InLOS(board))
{
from.LocalOverheadMessage(MessageType.Regular, 0x3B2, 1019045); // I can't reach that.
return;
}
if (!BasePlayerBB.CheckAccess(house, from))
{
from.SendLocalizedMessage(1062398); // You are not allowed to post to this bulletin board.
return;
}
switch (info.ButtonID)
{
case 1: // Post message
{
from.Prompt = new BasePlayerBB.PostPrompt(_page, house, board, false);
from.SendLocalizedMessage(1062397); // Please enter your message:
break;
}
case 2: // Set title
{
if (house.IsOwner(from))
{
from.Prompt = new BasePlayerBB.SetTitlePrompt(_page, house, board);
from.SendLocalizedMessage(1062402); // Enter new title:
}
break;
}
case 3: // Post greeting
{
if (house.IsOwner(from))
{
from.Prompt = new BasePlayerBB.PostPrompt(_page, house, board, true);
from.SendLocalizedMessage(1062404); // Enter new greeting (this will always be the first post):
}
break;
}
case 4: // Scroll up
{
if (_page == 0)
{
_page = board.Messages.Count;
}
else
{
_page -= 1;
}
from.SendGump(this);
break;
}
case 5: // Scroll down
{
_page += 1;
_page %= board.Messages.Count + 1;
from.SendGump(this);
break;
}
case 6: // Banish poster
{
if (house.IsOwner(from))
{
if (_page >= 1 && _page <= board.Messages.Count)
{
var message = board.Messages[_page - 1];
var poster = message.Poster;
if (poster == null)
{
from.SendGump(this);
return;
}
if (poster.AccessLevel > AccessLevel.Player && from.AccessLevel <= poster.AccessLevel)
{
from.SendLocalizedMessage(501354); // Uh oh...a bigger boot may be required.
}
else if (house.IsFriend(poster))
{
// That person is a friend, co-owner, or owner of this house, and therefore cannot be banished!
from.SendLocalizedMessage(1060750);
}
else if (poster is PlayerVendor)
{
from.SendLocalizedMessage(501351); // You cannot eject a vendor.
}
else if (house.Bans.Count >= BaseHouse.MaxBans)
{
from.SendLocalizedMessage(501355); // The ban limit for this house has been reached!
}
else if (house.IsBanned(poster))
{
from.SendLocalizedMessage(501356); // This person is already banned!
}
else if (poster is BaseCreature creature && creature.NoHouseRestrictions)
{
from.SendLocalizedMessage(1062040); // You cannot ban that.
}
else
{
if (!house.Bans.Contains(poster))
{
house.Bans.Add(poster);
}
from.SendLocalizedMessage(1062417); // That person has been banned from this house.
if (house.IsInside(poster) && !BasePlayerBB.CheckAccess(house, poster))
{
poster.MoveToWorld(house.BanLocation, house.Map);
}
}
}
from.SendGump(this);
}
break;
}
case 7: // Delete message
{
if (house.IsOwner(from))
{
if (_page >= 1 && _page <= board.Messages.Count)
{
board.RemoveFromMessagesAt(_page - 1);
}
_page = 0;
from.SendGump(this);
}
break;
}
case 8: // Post props
{
if (from.AccessLevel >= AccessLevel.GameMaster)
{
var message = board.Greeting;
if (_page >= 1 && _page <= board.Messages.Count)
{
message = board.Messages[_page - 1];
}
from.SendGump(this);
from.SendGump(new PropertiesGump(from, message));
}
break;
}
}
}
}