ModernUO/Projects/UOContent/Engines/ConPVP
Kamron Batman b042edcf0b
refactor: fold hand-written serializable property setters into field hooks (#2587)
## Summary

Folds **113** hand-written `[SerializableProperty]` members into plain `[SerializableField]` declarations using the v4 setter hooks — value coercion/vetoes via `allowFieldChange`, post-change side effects via `fieldChanged` (whose `oldValue` parameter covers the old-house/old-sender unsubscribe patterns). Net **-450 lines** of setter boilerplate.

```cs
// before
[SerializableProperty(1)]
[CommandProperty(AccessLevel.GameMaster)]
public int Charges
{
    get => _charges;
    set
    {
        _charges = Math.Clamp(value, 0, MaxCharges);
        InvalidateProperties();
        this.MarkDirty();
    }
}

// after
[SerializableField(1, allowFieldChange: nameof(AllowChargesChange))]
[SerializedCommandProperty(AccessLevel.GameMaster)]
[InvalidateProperties]
private int _charges;

private bool AllowChargesChange(ref int value)
{
    value = Math.Clamp(value, 0, MaxCharges);
    return true;
}
```

## How sites were selected

A classifier parsed all 204 `[SerializableProperty]` sites and converted only those matching strict shapes: getter is exactly `get => _field;`, the assignment comes first (after at most an equality guard), and relocated side effects contain no `return`, no `value` mutation, and no field re-assignment. Everything else was left alone deliberately:

- **~34 custom getters** (fallback defaults like `_x == -1 ? Default : _x`, self-healing refs) — no setter hook can express these.
- **~35 pre-assignment logic** (durability Unscale/Scale sandwiches, old-state captures like PotionKeg's pile weight).
- **virtual/override members, name-mismatched backing fields (`m_`), exotic semantics** (guards' `Focus` does work on *equal* assignment; `ChampionSpawn.Active` never assigns its field).

Five sites the classifier refused were converted by hand where the hooks fit cleanly: `ReceiverCrystal.Sender`, `PlayerVendor.House`, `PlayerBarkeeper.House` (old-value unsubscribe via `oldValue`), `BaseSuit.AccessLevel` (its existing virtual `OnAccessLevelChanged` already had the exact callback shape), and `DyeTub.DyedHue` (a true veto: `AllowDyedHueChange(ref int value) => _redyable`).

## Verification

- Build: **0 errors, 0 warnings**.
- **Schema regeneration produces zero Migrations changes** — the conversion is wire- and schema-neutral by construction (same orders, types, and property names), and CI's schema diff check enforces it.
- **835 + 708 tests green.**

## Behavioral notes (all strict improvements, called out for review)

- Generated setters skip everything when the incoming value equals the current one; a few converted setters previously re-ran side effects on equal assignment (redundant `Update()`-style refreshes).
- Generated setters always `MarkDirty()` on change; several converted setters never did (e.g. `DyeTub.DyedHue`, `MorphItem` ranges) — their changes only persisted if something else dirtied the entity. Those latent persistence bugs are fixed by construction.
2026-08-22 18:20:39 -07:00
..
Games feat: adopt serialization generator v4 (field-side linkage, anchored timers) (#2586) 2026-08-22 17:54:02 -07:00
Gumps feat: Pre-Publish 14 Crafting (supersedes #2181, #2381) (#2476) 2026-06-07 20:27:22 -07:00
AcceptDuelGump.cs perf: Migrates ConPVP lobby gumps from legacy Gump. (#2423) 2026-05-03 01:06:04 -07:00
Arena.cs fix: Fixes region priority and resolution. (#1254) 2022-11-21 10:38:20 -08:00
DuelContext.cs perf(messages): restructure format-string call sites (#2437) 2026-05-03 18:29:11 -07:00
DuelTeleporterAddon.cs fix: Converts ConPVP to serialization generator (#2338) 2026-02-14 14:50:10 -08:00
Ladder.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
Participant.cs perf(messages): restructure format-string call sites (#2437) 2026-05-03 18:29:11 -07:00
Preferences.cs perf: Migrates ConPVP lobby gumps from legacy Gump. (#2423) 2026-05-03 01:06:04 -07:00
Ruleset.cs fix: Removes unnecessary dictionary removal guards (#2565) 2026-08-08 11:50:01 -07:00
RulesetLayout.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
SafeZone.cs fix: Fixes region priority and resolution. (#1254) 2022-11-21 10:38:20 -08:00
Tournament.cs perf(conpvp): zero-alloc trophy text via TrophyRank.LowerName (#2438) 2026-05-03 18:31:40 -07:00
TournamentBracketItem.cs feat: Pre-Publish 14 Crafting (supersedes #2181, #2381) (#2476) 2026-06-07 20:27:22 -07:00
TournamentController.cs perf: Migrates ConPVP lobby gumps from legacy Gump. (#2423) 2026-05-03 01:06:04 -07:00
TournamentPyramid.cs feat: Adds Mobile.Murderer virtual property, consolidates kill-threshold checks (#2355) 2026-03-06 08:36:41 -08:00
TournamentRegistrar.cs fix: Converts ConPVP to serialization generator (#2338) 2026-02-14 14:50:10 -08:00
TournamentSignupItem.cs perf: Migrates ConPVP lobby gumps from legacy Gump. (#2423) 2026-05-03 01:06:04 -07:00
TourneyParticipant.cs feat: Add zero-alloc interpolation handler to ValueStringBuilder, replace all StringBuilder usage (#2387) 2026-03-22 14:23:44 -07:00
Trophy.cs refactor: fold hand-written serializable property setters into field hooks (#2587) 2026-08-22 18:20:39 -07:00