ModernUO/Projects/UOContent/Items/Weapons/Abilities
Kamron Batman 08dab47413
fix: check Controlled before reading ControlMaster (#2668)
Readers of `ControlMaster` that act on "this creature is a player's pet" now also require
`Controlled`. Nothing sets a master on an uncontrolled creature today, so behavior does not
change, except that the ML notoriety branch was the one read with nothing in front of it.
The guard keeps these readers correct if a creature ever keeps a master without being
controlled (a suspended-control state such as a charm or turn-pet ability, or folding
SummonMaster into one master field).

- Notoriety (ML): a creature only takes its master's notoriety while controlled
- BaseCreature.AggressiveAction: the aggressor link to the master only applies to controlled pets
- PlayerMobile.AutoStablePets: uncontrolled summons (blade spirits, energy vortexes) are skipped
- CrystalCaveBarrier: only a controlled pet passes on its owner's quest progress
- Discordance: the own-pet exception only applies to a controlled pet
- Dismount (ML): the remount block only goes to the owner of a controlled pet

Also removes the "Summons from monsters can attack players" branch in Mobile_AllowHarmful.
It has been unreachable since #2000: a creature with no player master returns from the
NPC check above it.

Tests: UOContent.Tests 1158 passed.
2026-09-23 11:45:48 -07:00
..
ArmorIgnore.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ArmorPierce.cs fix: Fixes WeaponAbility GetTactics override (#1778) 2024-05-18 10:24:29 -07:00
Bladeweave.cs fix: Fixes WeaponAbility GetTactics override (#1778) 2024-05-18 10:24:29 -07:00
BleedAttack.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
Block.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ConcussionBlow.cs fix: Fixes boat movement & moves weapon ability out of core (#750) 2021-08-30 21:30:09 -07:00
CrushingBlow.cs fix: Fixes WeaponAbility GetTactics override (#1778) 2024-05-18 10:24:29 -07:00
DefenseMastery.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
Disarm.cs fix: Fixes buffs don't start/stop properly. Streamlines constructor and Add/Remove buffs. (#2082) 2025-01-24 18:20:23 -08:00
Dismount.cs fix: check Controlled before reading ControlMaster (#2668) 2026-09-23 11:45:48 -07:00
DoubleShot.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
DoubleStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
DualWield.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
Feint.cs fix: Fixes Feint so it properly reduces damage (#1657) 2024-01-11 00:01:52 -08:00
ForceArrow.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
ForceOfNature.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
FrenziedWhirlwind.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
InfectiousStrike.cs feat: Refactor Poison system, implement Darkglow & Parasitic effects (#2385) 2026-03-21 21:27:22 -07:00
InfusedThrow.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
LightningArrow.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
MortalStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
MovingShot.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
MysticArc.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
NerveStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ParalyzingBlow.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
PsychicAttack.cs fix: Fixes buffs don't start/stop properly. Streamlines constructor and Add/Remove buffs. (#2082) 2025-01-24 18:20:23 -08:00
RidingSwipe.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
SerpentArrow.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
ShadowStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
TalonStrike.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00
WeaponAbility.cs chore: Use var everywhere (#2294) 2025-12-27 16:47:28 -08:00
WeaponAbilityPackets.cs fix: Fixes ignoring mobs, champions, party crash, slayer rarity, boat speedhack, etc (#1222) 2022-10-31 22:16:50 -07:00
WhirlwindAttack.cs fix: Fixes lightning arrow (#1583) 2023-11-05 17:36:09 -08:00