ModernUO/Projects/Server.Tests/Tests/Items/ContainerChildSkipTests.cs
Kamron Batman 9a25054809
test: remove trivial, duplicate and content-value tests (#2721)
## Summary
Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally.

Removed:
- **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior.
- **Exact duplicates** of a surviving test on the same code path.
- **Obsolete regressions** whose failure can no longer be expressed.
- **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix.

## How it was decided
1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files.
2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code.
3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way.

Whole files removed:
- `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone.
- `LordOaksTests` and `MeerEnragedTests` (single-creature tests).
- `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers).
- `NetworkStatsTests`.
- `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`).
- `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay.

## Tests
- Server.Tests: 811 pass.
- UOContent.Tests: 1,123 pass.

A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
2026-10-18 20:08:19 -07:00

125 lines
3.3 KiB
C#

using System;
using Server.Items;
using Xunit;
namespace Server.Tests;
[Collection("Sequential Server Tests")]
public class ContainerChildSkipTests
{
private class SkippingContainer : Container
{
public SkippingContainer() : base(0xE75)
{
}
public SkippingContainer(Serial serial) : base(serial)
{
}
public override bool SkipsChildSerialization => true;
}
[Fact]
public void ChildOfSkippingContainer_SkipsUntilMovedOut()
{
var pack = new SkippingContainer();
var normal = new Container(0xE75);
var item = new Item(0x1234);
try
{
pack.DropItem(item);
Assert.True(item.SkipSerialization);
Assert.False(pack.SkipSerialization);
normal.DropItem(item);
Assert.False(item.SkipSerialization);
}
finally
{
item.Delete();
pack.Delete();
normal.Delete();
}
}
[Fact]
public void GrandchildOfSkippingContainer_IsNotSkipped()
{
var pack = new SkippingContainer();
var inner = new Container(0xE75);
var item = new Item(0x1234);
try
{
pack.DropItem(inner);
inner.DropItem(item);
Assert.True(inner.SkipSerialization);
Assert.False(item.SkipSerialization);
}
finally
{
pack.Delete();
}
}
// A skipped child is not saved, so the container must load without it.
// A written child serial could resolve at load to an unrelated item that was handed the same serial.
[Fact]
public void SkippingContainer_DoesNotWriteAliveChildSerial()
{
var pack = new SkippingContainer();
var item = new Item(0x1234);
pack.DropItem(item);
var writer = new BufferWriter(true);
pack.Serialize(writer);
var buffer = new byte[writer.Position];
writer.Buffer.AsSpan(0, (int)writer.Position).CopyTo(buffer);
// item stays alive and in pack's list past this point, so its serial is still resolvable
// when copy deserializes below - deleting pack cascades to item, so both go together.
try
{
var copy = new SkippingContainer(World.NewItem);
copy.Deserialize(new BufferReader(buffer));
Assert.Empty(copy.Items);
}
finally
{
pack.Delete();
}
}
// An item can be saved naming a skipping container as parent while absent from its list; it must load
// as parentless so the missing-parent path deletes it rather than leaving an unreachable orphan.
[Fact]
public void ItemLoadingWithSkippingContainerAsParent_ClearsParent()
{
var pack = new SkippingContainer();
var item = new Item(0x1234);
pack.DropItem(item);
var writer = new BufferWriter(true);
item.Serialize(writer);
var buffer = new byte[writer.Position];
writer.Buffer.AsSpan(0, (int)writer.Position).CopyTo(buffer);
item.Delete();
try
{
var copy = new Item(World.NewItem);
copy.Deserialize(new BufferReader(buffer));
Assert.Null(copy.Parent);
}
finally
{
pack.Delete();
}
}
}