ModernUO/Projects/Server.Tests/Tests/Network
Kamron Batman 9a25054809
test: remove trivial, duplicate and content-value tests (#2721)
## Summary
Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally.

Removed:
- **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior.
- **Exact duplicates** of a surviving test on the same code path.
- **Obsolete regressions** whose failure can no longer be expressed.
- **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix.

## How it was decided
1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files.
2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code.
3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way.

Whole files removed:
- `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone.
- `LordOaksTests` and `MeerEnragedTests` (single-creature tests).
- `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers).
- `NetworkStatsTests`.
- `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`).
- `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay.

## Tests
- Server.Tests: 811 pass.
- UOContent.Tests: 1,123 pass.

A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
2026-10-18 20:08:19 -07:00
..
Bans test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
Packets/Outgoing feat: scope container child removal, skip-serialize and linearly delete container children (#2676) 2026-10-09 22:21:50 -07:00
ConnectionFiltersTests.cs feat(network): pluggable connection filters; file blocklist + contribute-first CrowdSec (#2542) 2026-07-25 11:59:37 -07:00
EventLoopIdleTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
ForeignProtocolTests.cs feat(network): allowlist false-positive IPs, escalate on behavior (#2556) 2026-07-30 23:12:17 -07:00
MovementThrottleLatencyTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
MovementThrottleTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
NetStateDisconnectTests.cs feat(network): grow the send buffer on demand instead of disconnecting (#2639) 2026-09-12 16:35:06 -07:00
NetStateRecvGuardTests.cs feat(network): lean base pools (#2641) 2026-09-20 00:24:15 -07:00
NetStateSendBufferTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
NetworkCompressionBoundsTests.cs test: remove trivial, duplicate and content-value tests (#2721) 2026-10-18 20:08:19 -07:00
NetworkCompressionTests.cs fix(network): restore huffman code for symbol 0x19 (#2528) 2026-07-14 09:26:39 -07:00