ModernUO/Projects/UOContent.Tests/Tests/Engines/Spawners/SpawnerEntryOwnershipTests.cs
Kamron Batman 9a25054809
test: remove trivial, duplicate and content-value tests (#2721)
## Summary
Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally.

Removed:
- **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior.
- **Exact duplicates** of a surviving test on the same code path.
- **Obsolete regressions** whose failure can no longer be expressed.
- **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix.

## How it was decided
1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files.
2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code.
3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way.

Whole files removed:
- `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone.
- `LordOaksTests` and `MeerEnragedTests` (single-creature tests).
- `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers).
- `NetworkStatsTests`.
- `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`).
- `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay.

## Tests
- Server.Tests: 811 pass.
- UOContent.Tests: 1,123 pass.

A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
2026-10-18 20:08:19 -07:00

150 lines
4.6 KiB
C#

using System;
using System.Diagnostics;
using System.Linq;
using System.Text.Json;
using Server;
using Server.Engines.Spawners;
using Server.Tests;
using Server.Text;
using Xunit;
namespace UOContent.Tests.Engines.Spawners;
[Collection("Sequential UOContent Tests")]
public class SpawnerEntryOwnershipTests
{
[Fact]
public void Disabled_DefaultsFalse_AndRoundTripsBinary()
{
var spawner = new Spawner(1, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(2), 0, default, "Rabbit", "Bird");
Assert.False(spawner.Entries[0].Disabled);
Assert.True(spawner.Entries[0].Enabled);
spawner.Entries[1].Disabled = true;
var bytes = SpawnerBlob.Write(spawner);
var loaded = SpawnerBlob.Read<Spawner>(bytes, (Serial)0x40001234);
Assert.Equal(2, loaded.Entries.Count);
Assert.False(loaded.Entries[0].Disabled);
Assert.True(loaded.Entries[1].Disabled);
spawner.Delete();
loaded.Delete();
}
[Fact]
public void Disabled_IsOmittedFromJsonWhenFalse_AndWrittenWhenTrue()
{
var entry = new SpawnerEntry("Rabbit");
var json = JsonSerializer.Serialize(entry, SpawnerJsonSerializer.Options);
Assert.DoesNotContain("disabled", json);
entry.Disabled = true;
json = JsonSerializer.Serialize(entry, SpawnerJsonSerializer.Options);
Assert.Contains("\"disabled\": true", json);
}
[Fact]
public void AddRemoveClear_OperateOnOwnerList()
{
var spawner = new Spawner();
Assert.Empty(spawner.Entries);
var a = spawner.AddEntry("Rabbit", 100, 2, false);
var b = spawner.AddEntry("Bird", 50, 1, false, "Hue 33", null);
Assert.Equal(2, spawner.Entries.Count);
Assert.Same(a, spawner.Entries[0]);
Assert.Equal("Hue 33", spawner.Entries[1].Properties);
spawner.RemoveEntry(a);
Assert.Single(spawner.Entries);
Assert.Same(b, spawner.Entries[0]);
spawner.RemoveAllEntries();
Assert.Empty(spawner.Entries);
spawner.Delete();
}
[Fact]
public void Dupe_ClonesEntriesIntoIndependentList()
{
var source = new Spawner(1, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(2), 0, default, "Rabbit", "Bird");
source.Entries[1].Disabled = true;
var copy = new Spawner();
source.Dupe(copy);
Assert.Equal(2, copy.Entries.Count);
Assert.NotSame(source.Entries[0], copy.Entries[0]);
Assert.Equal("Bird", copy.Entries[1].SpawnedName);
Assert.True(copy.Entries[1].Disabled);
Assert.NotEqual(source.Guid, copy.Guid);
source.AddEntry("Orc", 100, 1, false);
Assert.Equal(2, copy.Entries.Count);
source.Delete();
copy.Delete();
}
[Fact]
public void CopyEntriesTo_ReplacesTargetEntries()
{
var source = new Spawner(1, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(2), 0, default, "Rabbit");
var target = new Spawner(1, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(2), 0, default, "Orc", "Troll");
source.CopyEntriesTo(target);
Assert.Single(target.Entries);
Assert.Equal("Rabbit", target.Entries[0].SpawnedName);
Assert.NotSame(source.Entries[0], target.Entries[0]);
source.Delete();
target.Delete();
}
[Fact]
public void CopyEntriesTo_Self_IsNoOp()
{
var spawner = new Spawner(1, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(2), 0, default, "Rabbit", "Bird");
var first = spawner.Entries[0];
var second = spawner.Entries[1];
spawner.CopyEntriesTo(spawner);
Assert.Equal(2, spawner.Entries.Count);
Assert.Same(first, spawner.Entries[0]);
Assert.Same(second, spawner.Entries[1]);
spawner.Delete();
}
[Fact]
public void RemoveEntry_ForeignEntry_IsIgnored()
{
var a = new Spawner(1, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(2), 0, default, "Rabbit");
var b = new Spawner(1, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(2), 0, default, "Bird");
var foreign = b.Entries[0];
var spawned = new Item(0x1f13);
foreign.AddToSpawned(spawned);
a.RemoveEntry(foreign);
Assert.Single(a.Entries);
Assert.Equal("Rabbit", a.Entries[0].SpawnedName);
Assert.Single(b.Entries);
Assert.Same(foreign, b.Entries[0]);
Assert.False(spawned.Deleted);
Assert.Single(foreign.Spawned);
spawned.Delete();
a.Delete();
b.Delete();
}
// Manual: remove the Skip, run, and read the numbers from the thrown assertion.
}