ModernUO/Projects/UOContent/Mobiles/Townfolk
Kamron Batman 410a964789
fix: NPC outfits no longer stack two items on one layer (#2715)
Companion to #2712, which covers HireRanger's refused `EquipItem`. A sweep that built every constructible Mobile 2,000 times under each expansion found these other outfits that put two items on one layer. They don't leak, because `AddItem` skips `CheckEquip`, but the NPC wears both items and the client draws only one.

| NPC | Conflict |
|---|---|
| Miner, Ranger, Thief | Own shirt/pants/ThighBoots added on top of the random `BaseVendor.InitOutfit` (shoes doubled on every spawn) |
| MasterTheophilus | Shoes + Robe added over `EvilMageLord`'s Sandals + Robe |
| Merchant | Shirt + FancyShirt, or PlainDress + FancyDress |
| IronWorker | Bandana/JesterHat + Bascinet |
| MeerCaptain | One-handed sword + Crossbow |
| BakeKitsune | `BodyMod` isn't saved, so after a restart `RemoveDisguise` bailed and the next `Disguise()` stacked a second robe and pair of shoes |

## Changes
- `BaseCreature.ReplaceEquipment(item)` equips an item in place of whatever an inherited outfit put on its layer, and deletes the item if it still can't be equipped.
- Miner, Ranger, Thief, MasterTheophilus: their own pieces replace the inherited ones.
- Merchant and IronWorker: dropped the duplicate roll. Each kept the item the client was already drawing, which is the last one sent: the fancy set and the Bascinet.
- MeerCaptain: the sword goes into its pack as loot. **Behavior change:** `Mobile.Weapon` checks the one-handed layer first, so it was fighting with the sword despite its archer AI, its Archery skill and the bolts in its pack. It now uses the crossbow.
- BakeKitsune: `RemoveDisguise` strips the disguise without checking `IsBodyMod`.

## Testing
- I re-ran the sweep (local diagnostic, not committed; needs client tiledata) at 500 rolls × 12 expansions. Only HireRanger (#2712) and LordOaks (separate fix coming) remain.
- UOContent.Tests: 1218 passed, 2 skipped.
2026-10-17 16:17:11 -07:00
..
Actor.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
Artist.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
Banker.cs fix: Fixes exploits with bank box deposits. Makes stacking more efficient (#2337) 2026-02-13 20:34:35 -08:00
BaseEscortable.cs feat: adopt serialization generator v4 (field-side linkage, anchored timers) (#2586) 2026-08-22 17:54:02 -07:00
BrideGroom.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
EscortableMage.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Gypsy.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
HarborMaster.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
Merchant.cs fix: NPC outfits no longer stack two items on one layer (#2715) 2026-10-17 16:17:11 -07:00
Messenger.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Minter.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Ninja.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Noble.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Peasant.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Prisoner.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Samurai.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
Sculptor.cs chore: Fixes variable types for possible performance issues (#2172) 2025-05-01 21:54:41 -07:00
SeekerOfAdventure.cs fix: Fixes ML Escortables and codegens (#1525) 2023-09-30 14:11:48 -07:00
TownCrier.cs perf: Migrate NPC and Skill UI gumps to DynamicGump/StaticGump (#2414) 2026-04-25 19:51:42 -07:00