9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
113 lines
4.7 KiB
C#
113 lines
4.7 KiB
C#
using System;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests;
|
|
|
|
public class Rectangle3DTests
|
|
{
|
|
[Fact]
|
|
public void TestRectangle3DToString()
|
|
{
|
|
const int max = int.MaxValue;
|
|
const int min = int.MinValue;
|
|
Assert.Equal("(0, 0, 0)+(0, 0, 0)", new Rectangle3D(0, 0, 0, 0, 0, 0).ToString());
|
|
Assert.Equal("(1, 1, 1)+(1, 1, 1)", new Rectangle3D(1, 1, 1, 1, 1, 1).ToString());
|
|
Assert.Equal($"({max}, {max}, {max})+({max}, {max}, {max})", new Rectangle3D(max, max, max, max, max, max).ToString());
|
|
Assert.Equal($"({min}, {min}, {min})+({min}, {min}, {min})", new Rectangle3D(min, min, min, min, min, min).ToString());
|
|
}
|
|
|
|
[Fact]
|
|
public void TestRectangle3DTryFormatFails()
|
|
{
|
|
const int max = int.MaxValue;
|
|
const int min = int.MinValue;
|
|
var array = new char[1];
|
|
|
|
var p1 = new Rectangle3D(0, 0, 0, 0, 0, 0);
|
|
Assert.False(p1.TryFormat(array, out var cp1, null, null));
|
|
Assert.Equal(0, cp1);
|
|
Array.Clear(array);
|
|
|
|
var p2 = new Rectangle3D(1, 1, 1, 1, 1, 1);
|
|
Assert.False(p2.TryFormat(array, out var cp2, null, null));
|
|
Assert.Equal(0, cp2);
|
|
Array.Clear(array);
|
|
|
|
var p3 = new Rectangle3D(max, max, max, max, max, max);
|
|
Assert.False(p3.TryFormat(array, out var cp3, null, null));
|
|
Assert.Equal(0, cp3);
|
|
Array.Clear(array);
|
|
|
|
var p4 = new Rectangle3D(min, min, min, min, min, min);
|
|
Assert.False(p4.TryFormat(array, out var cp4, null, null));
|
|
Assert.Equal(0, cp4);
|
|
}
|
|
|
|
[Fact]
|
|
public void TestRectangle3DTryParse()
|
|
{
|
|
// Happy Path
|
|
Assert.True(Rectangle3D.TryParse("(101, 23, 10)+(55, 89, 1)", null, out var p));
|
|
Assert.Equal(new Rectangle3D(new Point3D(101, 23, 10), new Point3D(55, 89, 1)), p);
|
|
Assert.Equal(new Rectangle3D(new Point3D(101, 23, 10), new Point3D(55, 89, 1)), Rectangle3D.Parse("(101, 23, 10)+(55, 89, 1)", null));
|
|
|
|
// Trimming
|
|
Assert.True(Rectangle3D.TryParse(" (101,23,10)+ (55, 89,1) ", null, out p));
|
|
Assert.Equal(new Rectangle3D(new Point3D(101, 23, 10), new Point3D(55, 89, 1)), p);
|
|
Assert.Equal(new Rectangle3D(new Point3D(101, 23, 10), new Point3D(55, 89, 1)), Rectangle3D.Parse(" (101,23,10)+ (55, 89,1) ", null));
|
|
|
|
// No parenthesis
|
|
Assert.False(Rectangle3D.TryParse("101, 23, 10)+( 55, 89, 1)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("101, 23, 10)+( 55, 89, 1)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(101, 23, 10)+(55, 89, 1", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(101, 23, 10)+(55, 89, 1", null));
|
|
|
|
// No numbers
|
|
Assert.False(Rectangle3D.TryParse("()", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("()", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(,)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(,)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(|)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(|)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(101)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(101)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(101,)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(101,)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(101,23)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(101,23)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(,23)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(,23)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(,23)+(,55)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(,23)+(,55)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(,23,)+(,89)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(,23,)+(,89)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(101,,10)+(55, 89 1)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(,23,)+(,89)", null));
|
|
|
|
Assert.False(Rectangle3D.TryParse("(,,)+(55,89, 1)", null, out p));
|
|
Assert.Equal(default, p);
|
|
Assert.Throws<FormatException>(() => Rectangle3D.Parse("(,,)+(55,89, 1)", null));
|
|
}
|
|
}
|