9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
38 lines
1.3 KiB
C#
38 lines
1.3 KiB
C#
using System.Text.Json;
|
|
using Server.Json;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Json;
|
|
|
|
public class Rectangle3DConverterTests
|
|
{
|
|
private static Rectangle3D RoundTrip(Rectangle3D value)
|
|
{
|
|
var json = JsonSerializer.Serialize(value, JsonConfig.DefaultOptions);
|
|
return JsonSerializer.Deserialize<Rectangle3D>(json, JsonConfig.DefaultOptions);
|
|
}
|
|
|
|
[Theory]
|
|
// homeRange-style full vertical range (z1=-128, depth 256 -> z2=128): must survive losslessly.
|
|
[InlineData(100, 100, -128, 11, 11, 256)]
|
|
// The omitted-z sentinel itself (z1=-128, z2=127 -> depth 255).
|
|
[InlineData(100, 100, -128, 11, 11, 255)]
|
|
// Ordinary bounds with a meaningful z.
|
|
[InlineData(100, 100, 0, 11, 11, 5)]
|
|
[InlineData(100, 100, 5, 11, 11, 122)] // z2 == 127 but z1 != -128
|
|
[InlineData(100, 100, -128, 11, 11, 200)] // z1 == -128 but z2 != 127
|
|
public void RoundTrips(int x, int y, int z, int w, int h, int d)
|
|
{
|
|
var rect = new Rectangle3D(x, y, z, w, h, d);
|
|
Assert.Equal(rect, RoundTrip(rect));
|
|
}
|
|
|
|
[Fact]
|
|
public void FullRangeSentinel_OmitsZ()
|
|
{
|
|
// z1=-128, z2=127 is the only case z is omitted.
|
|
var json = JsonSerializer.Serialize(new Rectangle3D(0, 0, -128, 10, 10, 255), JsonConfig.DefaultOptions);
|
|
Assert.DoesNotContain("z1", json);
|
|
Assert.DoesNotContain("z2", json);
|
|
}
|
|
}
|