9a25054809
## Summary Many tests proved a specific change when it landed but don't need to run on every CI build forever. This removes **202 test methods and 9 files: 313 test cases, 2,247 → 1,934**. UOContent.Tests drops from about 14s to about 5s locally. Removed: - **Tautologies.** Asserting a constant, a constructor readback or a trivial getter, or testing BCL behavior. - **Exact duplicates** of a surviving test on the same code path. - **Obsolete regressions** whose failure can no longer be expressed. - **Game-content values** shard owners customize (era drop rates, loot and skill tables, single-creature tuning). Each customization would otherwise force a test fix. ## How it was decided 1. Every test was classified, with a reason, by a per-shard sweep over all 287 test files. 2. Each proposed deletion was then checked by a second, adversarial reviewer against the surviving tests and the production code. 3. Anything that was the only coverage of a separate code path was **kept**, even where it looked like a duplicate. Examples: the unsigned `SpanReader`/`SpanWriter` methods, the at-location versus bounds enumerators, null-map enumerables, the security filters, archive-journal state transitions. About 130 proposed deletions were rejected this way. Whole files removed: - `FishingTests`, apart from 3 tests: the map-edge scan, serpent cleanup, and SOS chest consumption. The SOS test now stops at the first chest instead of measuring a catch rate. The multi-million-cast rate simulations are gone. - `LordOaksTests` and `MeerEnragedTests` (single-creature tests). - `AutoArchiveHelperTests`, `JsonDiscoverableTypeAttributeTests`, `DecimalSerializationTests` and `EnumConversionTests` (tautologies, or tests of their own local helpers). - `NetworkStatsTests`. - `MigratedDataLoadTests` (a subset of `AllSpawnFilesLoadTests`). - `SpawnerFixtureCapture`: a capture tool, not a test, and its `version == 12` assert can no longer pass. The `.bin` fixtures it produced stay. ## Tests - Server.Tests: 811 pass. - UOContent.Tests: 1,123 pass. A follow-up PR, stacked on this one, fixes how the remaining tests behave: shared state, CI-vacuous tests, harness duplication.
60 lines
2.7 KiB
C#
60 lines
2.7 KiB
C#
/*************************************************************************
|
|
* ModernUO *
|
|
* Copyright 2019-2026 - ModernUO Development Team *
|
|
* Email: hi@modernuo.com *
|
|
* File: ManualAllowlistConfigurationTests.cs *
|
|
* *
|
|
* This program is free software: you can redistribute it and/or modify *
|
|
* it under the terms of the GNU General Public License as published by *
|
|
* the Free Software Foundation, either version 3 of the License, or *
|
|
* (at your option) any later version. *
|
|
* *
|
|
* You should have received a copy of the GNU General Public License *
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>. *
|
|
*************************************************************************/
|
|
|
|
using System;
|
|
using System.Text.Json;
|
|
using Server.Json;
|
|
using Server.Network.Bans;
|
|
using Xunit;
|
|
|
|
namespace Server.Tests.Network.ManualAllowlists;
|
|
|
|
public class ManualAllowlistConfigurationTests
|
|
{
|
|
// Locks the JsonConfig casing contract: JsonConfig's options are case-SENSITIVE, so every settings
|
|
// member must carry an explicit [JsonPropertyName("camelCase")] or it silently binds nothing.
|
|
[Fact]
|
|
public void ManualAllowlistSettings_RoundTripsThroughJsonConfig()
|
|
{
|
|
var original = new ManualAllowlistSettings
|
|
{
|
|
Enabled = true,
|
|
Files = ["D:/shared/ip-allowlist*.txt"],
|
|
ReloadInterval = TimeSpan.FromMinutes(5)
|
|
};
|
|
|
|
var json = JsonConfig.Serialize(original);
|
|
|
|
Assert.Contains("\"enabled\"", json);
|
|
Assert.Contains("\"files\"", json);
|
|
Assert.Contains("\"reloadInterval\"", json);
|
|
|
|
var restored = JsonSerializer.Deserialize<ManualAllowlistSettings>(json, JsonConfig.DefaultOptions);
|
|
|
|
Assert.NotNull(restored);
|
|
Assert.Equal(original.Enabled, restored.Enabled);
|
|
Assert.Equal(original.Files, restored.Files);
|
|
Assert.Equal(original.ReloadInterval, restored.ReloadInterval);
|
|
}
|
|
|
|
// The point of the flag: a shard that never opts in must not start the reload poll.
|
|
// The generator creates ip-allowlist.txt beside the blocklist; the wildcard is what picks up a
|
|
// carve-out file (-RefreshCarveouts writes ip-allowlist-starlink.txt) with no config edit.
|
|
[Fact]
|
|
public void Default_pattern_matches_the_generator_output_path()
|
|
{
|
|
Assert.Equal(["Configuration/ip-allowlist*.txt"], new ManualAllowlistSettings().Files);
|
|
}
|
|
}
|