ModernUO/Projects/UOContent/Commands/Generic/Implementors
Kamron Batman a4cabe2fa4
fix: Optimizes FindItemsByType by removing allocations. (#1515)
### Summary
Container enumeration is in dire need of optimization. Thanks to @stefanomerotta for initiating this work with PR #1443. This PR handles a small part of what Stefan started. Also included are some bug fixes.

### Method Signatures

```cs
// Use with foreach without moving/deleting items
FindItemsByTypeEnumerator<T> FindItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)

// Use with foreach when moving/deleting items
QueuedItemsEnumerator<T> EnumerateItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)

// Use when iterating multiple times or queuing
PooledRefQueue<T> QueueItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)

// Use when iterating multiples times or manipulating elements without traversing
PooledRefList<T> ListItemsByType<T>(bool recurse = true, Predicate<T> predicate = null)
```

* `FindItemsByType<T>` has changed from returning `List<T>` to `FindItemsByTypeEnumerator<T>` - This method is not safe to use in situations where an item may get consumed, deleted, or moved.

* `EnumerateItemsByType<T>` was added as a safe way to iterate and manipulate items.
  * **Note**: EnumerateItemsByType will _completely traverse the container_ before iteration starts because it uses `QueueItemsByType` under the hood.

* `QueueItemsByType<T>`  and `ListItemsByType<T>` was added to return a queue or list of items to iterate multiple times and manipulate the items. This isn't the most efficient since it uses a predicate and can result in 2 or 3 total iterations unnecessarily.

### Bug Fixes
- [X] Fishing had an error in the random check that may have caused slight bias.
2023-09-28 19:36:45 -07:00
..
AreaCommandImplementor.cs fix: Removes LINQ from Map.cs (#834) 2021-12-28 14:32:45 -08:00
BaseCommandImplementor.cs feat: Customize expansion and set maps on first boot (#1425) 2023-07-31 20:46:49 -07:00
ContainedCommandImplementor.cs fix: Optimizes FindItemsByType by removing allocations. (#1515) 2023-09-28 19:36:45 -07:00
FacetCommandImplementor.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
GlobalCommandImplementor.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
IPAddressCommandImplementor.cs Cleanup & Fixes for .NET 5 (#309) 2020-11-15 10:03:50 -08:00
MultiCommandImplementor.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
ObjectConditional.cs cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
OnlineCommandImplementor.cs Cleanup & Fixes for .NET 5 (#309) 2020-11-15 10:03:50 -08:00
RangeCommandImplementor.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
RegionCommandImplementor.cs fix: Fixes spawners, adds convertpremiumspawners, exportspawners, and replaces with neruns distro (#751) 2021-09-03 21:52:44 -07:00
ScreenCommandImplementor.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
SelfCommandImplementor.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
SerialCommandImplementor.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
SingleCommandImplementor.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00