ModernUO/Scripts/Items
Vorspire 1e5bc72366 Infinite Loop Breakout
There is a very rare potential, mostly in custom situations, for the 'BaseRunicTool' 'ApplySkillBonus' method to cause the server to become unresponsive.
The reason for this is that, if you call the method on a 'Spellbook' which already has all 4 of the skills listed by default in 'm_PossibleSpellbookSkills', then 'found' is always true.

This issue has been reproduced on a shard that calls 'ApplySkillBonus' more than once when crafting 'Spellbooks'; the rarity is that the 'ApplyAttributesTo' method may call the 'ApplySkillBonus' more than once; the off-chance of 5 consecutive calls, where each preceding call applies one unique skill of the 'possibleSkills', would result in the 5th call entering the deadlock state.

The fix is quite simple, evaluate the 'count' in the while statement and decrement it for each skill that is checked; removing each skill from the 'possibleSkills' list as they are checked, to prevent them being checked multiple times due to the random indices selection.
2015-07-21 00:45:43 +01:00
..
Addons misc merge/tidy from Zenvera 2013-10-24 14:23:03 -07:00
Aquarium add OnSingleClick for BulkOrderBook and Aquarium 2014-02-22 12:56:58 -07:00
Armor remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Body Parts 2006-06-15 04:14:30 +00:00
Books Helper methods for BaseBook 2012-01-07 01:37:17 +00:00
Champion Artifacts correct spelling (thanks Andre Grobler) 2013-10-11 04:03:13 -07:00
Clothing remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Construction - Moved BaseHouse's CheckAccount to AccountHandler for general use. 2012-04-15 02:36:01 +00:00
Containers remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Decoration Artifacts Implement Core.TickCount 2013-10-06 03:21:18 -07:00
Deeds Implement Core.TickCount 2013-10-06 03:21:18 -07:00
Facial 2006-06-15 04:14:30 +00:00
Farming ISpawner; ISpawnable, cleanup. All custom spawners should inherit from ISpawner. Also, Ridiculous, not rediculous, 2010-12-26 05:18:57 +00:00
Food revert the revert :P 2012-09-02 21:48:45 +00:00
Games Implement Core.TickCount 2013-10-06 03:21:18 -07:00
Gems 2006-06-15 04:14:30 +00:00
Guilds Uncontrolled BaseCreatures don't path around mobiles 2011-12-18 02:03:40 +00:00
Jewels remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Lights remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Maps rework Core.TickCount 2013-10-07 00:22:11 -07:00
Minor Artifacts - ConPVP: Help menu will no longer move players out of houses inside SafeZones. 2012-07-14 23:32:27 +00:00
Misc remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
New Haven Quest Rewards ML quest system; first SVN release. 2013-02-03 01:05:17 +00:00
PlantsFlowers/Potted 2006-06-15 04:14:30 +00:00
Quivers remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Resources 2012-11-10 20:06:36 +00:00
Shields 2012-11-10 20:06:36 +00:00
Skill Items Infinite Loop Breakout 2015-07-21 00:45:43 +01:00
Special remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Suits 2006-06-15 04:14:30 +00:00
Talismans remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00
Traps Implement Core.TickCount 2013-10-06 03:21:18 -07:00
TreasureChests range check mobiles, return home. On OSI they just delete and respawn. We will try to be a little more graceful, and see if we can walk back. 2013-01-19 21:52:09 +00:00
Wands add Deleted property to IEntity 2013-11-02 10:52:08 -07:00
Weapons remove ParentEntity and RootParentEntity 2014-02-15 13:21:28 -07:00