ModernUO/Projects/UOContent/Gumps
Kamron Batman f77dd91811
fix: Overhauls virtue system (#1376)
## MAJOR CHANGE (API BREAKING)

Moved the virtues to it's own system _VirtueSystem_. This should make it easier to extend or remove the virtue system. Virtues will be saved to a new folder called _Virtues_.

### Motivation

The motivation was also two-fold, performance/stability, and to fix bugs.

First, virtues is the second system (first is murders), that has a pre-world-save check on _every mobile in the game_ to atrophy virtue stats. This is taxing since it freexes the world and makes world saves take longer. Every mobile had Gain/Loss dates for each virtue, whether they needed them or not. Most players don't even use the virtue system, so this will increase performance considerably.

Second, when I tried to optimize/refactor the code, I found several bugs that needed to be fixed.

### Major API Changes

- [X] The properties on players related to virtues are gone. Use `pm.GetVirtues()?.<PropertyName>` instead.
- [X] Virtues were removed from non-player Mobiles.
- [X] `pm.JusticeProtectors` was removed. Use `JusticeVirtue.GetProtector()` or `JusticeVirtue.GetProtected()` instead.

### Screenshots

<img width="221" alt="Props-1" src="https://github.com/modernuo/ModernUO/assets/3953314/5c09cb83-b8d5-44a2-b899-a7ed7cd736ac">
<img width="220" alt="props-2" src="https://github.com/modernuo/ModernUO/assets/3953314/aeade4d3-8df0-47bd-955a-a864d0946cf7">
2023-07-19 21:43:47 -07:00
..
Go fix(cleanup): Consolidate the duplicate code in Properties, PropsGump, and PropsConfig (#540) 2021-04-14 22:58:56 -07:00
Guilds fix: Cleans up create guild gump (#1326) 2023-01-31 23:51:01 -08:00
Props fix: Prevent setting properties of higher privileged mobiles (#1420) 2023-07-15 22:01:33 -07:00
AddDoorGump.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
AdminGump.cs fix: Exclude higher privileged mobiles in AdminGump (#1423) 2023-07-15 22:12:38 -07:00
BanDurationGump.cs fix: Update LabelTo, SendMessage, etc to Interpolated Strings (#1283) 2022-11-28 19:58:12 -08:00
BaseConfirmGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
BaseGridGump.cs feat: Adds [Spawn command & Gump Grids (#917) 2022-06-30 22:22:51 -07:00
BaseImageTileButtonsGump.cs feat: Adds TextDefinition serialization support. (#1217) 2022-10-30 01:42:48 -07:00
ClientGump.cs fix: Update LabelTo, SendMessage, etc to Interpolated Strings (#1283) 2022-11-28 19:58:12 -08:00
CommentsGump.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
ConfirmBreakCrystalGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
ConfirmHeritageGump.cs Fixes dupe exception (#258) 2020-09-19 15:46:07 -07:00
ConfirmHouseResize.cs cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
ConfirmReleaseGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
HeritageTokenGump.cs fix(core): Removes some uses of Linq (#421) 2021-01-18 21:05:11 -08:00
HonorSelf.cs fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
HouseDemolishGump.cs fix: Fixes bank checks falling to the floor. (#972) 2022-03-26 21:06:46 -07:00
HouseGump.cs fix(core): Optimizes strings / .NET 5 compatibility changes (#354) 2020-12-20 23:21:55 -08:00
HouseGumpAOS.cs fix(core): Caches DateTime.NowUtc (#548) 2021-03-13 01:32:04 -08:00
HouseTransferGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
NoticeGump.cs fix: Adds more null checks for text definition to prevent NPEs (#936) 2022-02-18 11:13:38 -08:00
PetResurrectGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
PlayerVendorGumps.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
PolymorphGump.cs C# 9 Cleanup (#325) 2020-11-27 00:29:21 -08:00
ReclaimVendorGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
ResurrectGump.cs fix: Overhauls virtue system (#1376) 2023-07-19 21:43:47 -07:00
RewardGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
RunebookGump.cs fix: Fixes badly formatted files (#878) 2021-12-05 08:56:09 -08:00
SetSecureLevelGump.cs Formats UO Content (#201) 2020-08-27 18:30:38 -07:00
SkillsGump.cs fix(cleanup): Consolidate the duplicate code in Properties, PropsGump, and PropsConfig (#540) 2021-04-14 22:58:56 -07:00
TithingGump.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00
ToTAdminGump.cs Cleanup & Fixes for .NET 5 (#309) 2020-11-15 10:03:50 -08:00
VendorInventoryGump.cs cleanup: Fixes bugs and cleans up code (#660) 2021-07-19 20:49:59 -07:00
VendorRentalGumps.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
ViewHousesGump.cs chore: Cleans up pattern checks. (#892) 2021-12-24 15:53:59 -08:00
WarningGump.cs fix: Adds more null checks for text definition to prevent NPEs (#936) 2022-02-18 11:13:38 -08:00
WhoGump.cs fix(cleanup): Consolidate the duplicate code in Properties, PropsGump, and PropsConfig (#540) 2021-04-14 22:58:56 -07:00
YoungGumps.cs Fixes brace style (#248) 2020-09-13 21:49:46 -07:00